openwisp / openwisp-controller

99%

LAST BUILD ON BRANCH master

branch: SELECT

CHANGE BRANCH

x

• No branch selected
• 0.8.x
• 1.0
• 1.0.x
• 1.1
• 1.1-1031
• 1.1-update-test_zerotier_vpn_client_template
• 1.2
• 1.2-fixes
• 1061-replace-thirdparty-jsonfield-with-django-builtin1
• Fx-VPN-templates-conflict
• add_missing_sample_config_tests_on_master
• adjust_test_selenium_for_custom_config
• allauth-update
• api-cleanup
• backport/1257-to-1.2-1772820939
• backport/1292-to-1.2-1773869681
• backport/1303-to-1.2-1774628819
• backport/1312-to-1.2-1774565802
• backport/1322-to-1.2-1774589082
• bump-version
• changelog/1.1.2
• channels-deps
• channels-live-server-tests
• check-ci
• chore/add-publiccode-parser-action
• chore/port-changelog-1.2.1
• chore/port-changelog-1.2.2
• chores/add-ci-failure-bot-caller
• chores/add-gsoc25-brances-in-ci
• chores/failure-bot-improvements
• ci
• ci/changelog-bot
• cleanup-deprecated-1-2-0
• config_app_label_in_selenium_tests
• crypto-crl
• css-fixes
• dependabot/github_actions/actions/cache-5
• dependabot/github_actions/actions/checkout-5
• dependabot/github_actions/actions/checkout-6
• dependabot/github_actions/actions/setup-python-6
• dependabot/github_actions/pypa/gh-action-pypi-publish-1.12.2
• dependabot/github_actions/pypa/gh-action-pypi-publish-1.12.3
• dependabot/github_actions/pypa/gh-action-pypi-publish-1.12.4
• dependabot/pip/django-cache-memoize-approx-eq-0.2.1
• dependabot/pip/django-flat-json-widget-approx-eq-0.3.1
• dependabot/pip/django-import-export-approx-eq-4.1.1
• dependabot/pip/django-import-export-approx-eq-4.3.10
• dependabot/pip/django-import-export-approx-eq-4.3.13
• dependabot/pip/django-import-export-approx-eq-4.3.14
• dependabot/pip/django-import-export-approx-eq-4.3.7
• dependabot/pip/django-import-export-approx-eq-4.3.8
• dependabot/pip/django-import-export-approx-eq-4.3.9
• dependabot/pip/django-redis-approx-eq-6.0.0
• dependabot/pip/django-reversion-approx-eq-6.0.0
• dependabot/pip/django-taggit-approx-eq-6.1.0
• dependabot/pip/paramiko-ed25519--approx-eq-3.5.1
• dependabot/pip/psycopg2-binary-approx-eq-2.9.10
• dependabot/pip/pytest-cov-approx-eq-6.1.0
• dependabot/pip/pytest-cov-approx-eq-6.1.1
• dependabot/pip/pytest-cov-approx-eq-6.2.1
• dependabot/pip/pytest-cov-approx-eq-7.0.0
• dependabot/pip/pytest-timeout-approx-eq-2.4.0
• dependabot/pip/responses-approx-eq-0.25.6
• dependabot/pip/responses-approx-eq-0.25.7
• dependabot/pip/responses-approx-eq-0.25.8
• dependabot/pip/responses-approx-eq-0.26.0
• device-id-consistency
• devicecommand_organisation_bug
• docs/websocket_API_created
• drop-python-3.9
• feature/1157-new-ws-endpoint-for-all-location
• feature/828-api-indoor-map-coordinates
• feature/894-rest-api-revisions
• feature/backport-workflow
• feature/bot-autoassign
• feature/vpn-cache-invalidation-1098
• filippociandy/ow_zt-to-global
• fix-celery-sync-execution
• fix-command-input-data-type
• fix-command-modified-timestamp
• fix-command-none-connection-guard
• fix-command-null-connection
• fix-command-str-null-input
• fix-common-name-bug
• fix-config-checksumdb-migration
• fix-config-problem-notification
• fix-device-get-deferred-values
• fix-django-loci-deps
• fix-django-styling
• fix-docs
• fix-docs-reference
• fix-launch-command-idempotency
• fix-launch-command-logging
• fix-modified-timestamp
• fix-multivaluedictkeyerror-1057
• fix-name-replace
• fix-org-limits-screenshot
• fix-recreating-vpn-client
• fix-refresh-from-db-missing-call
• fix-related-device-model-perm-mixin
• fix-relevant-templates
• fix-send-command-updates
• fix-subnet-division-invalidates-checksum-cache
• fix-subnet-division-ip-index
• fix-test_update_vpn_server_configuration
• fix-update-strategy-typo
• fix-vpn-auto-client
• fix-vpnclient-inconsistent-checksum
• fix/1221-vpn-peer-cache-desync
• fix/1221-vpn-peer-cleanup
• fix/deactivation-test-exercises-correct-path
• fix/fix-mentioning-ci-failure-bot
• fix/get-common-name-device-mutation
• fix/invalidate-controller-views-cache-on-org-context-change
• fix/manage-devices-group-templates-return-to-continue
• fix/update-config-self-detection
• fix/update-config-ssh-leak-silent-failure
• fix/update-config-task-self-match
• fix/vpn-get-common-name-device-mutation
• fix/vpn-server-cert-validation
• fix_ignored_command_timeout
• fix_migration_graph
• fix_widget_hard_coded_url
• gsoc23
• gsoc25-map
• gsoc25-whois
• gsoc25-whois-modified
• improve-help-texts-variables-metadata
• issue/1040-added-recency-tests
• issues/1016-command-connection-check
• issues/1024-update-config-self-detection
• issues/1026-whois-display
• issues/1034-fuzzy-location-creation
• issues/1035-fuzzy-task-alert
• issues/1047-send-command-docs
• issues/1049-send-generic-message
• issues/1058-update-whois
• issues/1064-cache-vpn-configuration
• issues/1070-device-config-status
• issues/1071-device-group-filter-label
• issues/1096-prevent-changes-in-ipam
• issues/1097
• issues/1110-crash-without-superuser-permission
• issues/1128-update_config
• issues/1133-perennial-config-modified
• issues/1162-replace-hardcoded-colors-with-ow-vars
• issues/1204-celery-execution-skip
• issues/1204-celery-update-config-self-detection
• issues/1224-separate-geo-logic-from-config
• issues/1231-fallback-fileds-db-migrations
• issues/1263-fix-modified-timestamp
• issues/204-sortedm2m-queries
• issues/442-fix-tests-monitoring
• issues/480-auto-add-templates
• issues/525-disable-advanced-editor-for-commands
• issues/560-readonly-map
• issues/682-NoReverseMatch-error
• issues/789-disallow-changing-configuration-backend-ui
• issues/809-custom-command-expects-string-type
• issues/812-ui-command-highlight
• issues/818-show-inherited-vars
• issues/831-delete-vpnclients
• issues/832-multiple-template-same-vpn
• issues/836-template-history
• issues/848-readonly-config-field
• issues/868-preview-keyboard-keys-selenium-test
• issues/902-fix-selenium-unsaved-changes
• issues/922-mac-address-uppercase
• issues/936-recovering-device-with-location
• issues/949-delete-offline-devices
• issues/953-test-failures-with-python-3.12
• issues/964-update_config
• issues/ci-build-failing
• issues/device-location-floorplan-filter
• leaflet-withforms
• limit-recent-comands
• location-api-uuid
• master
• misc-fixes
• paramiko-4.0.0
• patch-1
• prettier
• qa
• recent-commands-tab
• release-1.1.1
• release-1.1.2
• release/1.2.0
• release/1.2.2
• replicate-version-branch
• runtests
• session_cache_enabled
• test-hanging
• tests/launch-command-timeout-exception
• trigger-vpn-endpoint
• update-ci-failure-bot
• update-geo-tests
• update-hostname-on-registration
• update-selenium-tests
• updated-multitenant-tests
• vpn-template-validation

Build # 24082370186

Build Type

push

github

Committed by web-flow

Commit Message

[chores:fix] Separated geo.estimated_location from config.whois #1224

The new WHOIS and Estimated Location features were interwined
and referenced each other, leading to maintainability issues.
This patch resolved this problem and introduced more separation
of responsibilities and decoupling.

Closes #1224

---------

Co-authored-by: Federico Capoano <f.capoano@openwisp.io>

Coverage Stats

7400 of 7506 relevant lines covered (98.59%)

10.84 hits per line