zopefoundation / zope.server

100%

master: 99%

LAST BUILD ON BRANCH issue5

branch: issue5

CHANGE BRANCH

x

Reset

• issue5
• 100_coverage
• 4.0.0
• 4.0.1
• 4.0.2
• 5.0
• CCjGM6D2qkc2rLXX
• appveyor
• config-with-pure-python
• config-with-pure-python-template-58e05f0f
• fix-pipetrigger
• fix-pypy
• fix-tests
• fix-warnings
• issue4
• lint
• master
• modernize-python
• py3
• py37

Build # 68

Build Type

push

travis-ci

Committed by jamadden

Commit Message

Implement OverflowableBuffer in terms of SpooledTemporaryFile

Fixes #5

Even for small buffers (the 8192 that previously were guaranteed to be
kept in a simple string) this should be faster, depending on the
number of writes possibly. Previously the strbuf was built up with
concatenation: `buf = buf + data`. Now we go directly into BytesIO and
avoid the extra copying.

Microbenchmarks on Python 3.6:

In [1]: def append():
   ...:     buf = b''
   ...:     while len(buf) < 8192:
   ...:         buf += b'data' * 100
   ...:

In [4]: %timeit append()
10.9 µs ± 268 ns per loop (mean ± std. dev. of 7 runs, 100000 loops each)

In [8]: def bio():
   ...:     b = io.BytesIO()
   ...:     cnt = 0
   ...:     while cnt < 8192:
   ...:         cnt += b.write(b'data'*100)
   ...:

In [9]: bio()

In [10]: %timeit bio()
8.55 µs ± 282 ns per loop (mean ± std. dev. of 7 runs, 100000 loops each)

Run Details

4481 of 4481 relevant lines covered (100.0%)

5.0 hits per line