zopefoundation / Zope
82%
master: 82%

LAST BUILD BRANCH: modernize_product_enumeration
DEFAULT BRANCH: master
Repo Added
Files 357
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH maurits-ensure-publishable
branch: maurits-ensure-publishable
CHANGE BRANCH
x

coverage: 82.414% (-0.001%) from 82.415%
8806350432

push

github

mauritsvanrees 
Do not fail when request has no ensure_publishable method.

This may happen in tests.
In a Plone core development buildout with Zope master there are failures in `plone.dexterity`:

```
$ bin/test -s plone.dexterity -u
...
Error in test test_acquire_without_dav (plone.dexterity.tests.test_webdav.TestDAVTraversal.test_acquire_without_dav)
Traceback (most recent call last):
  File "/Users/maurits/.pyenv/versions/3.11.7/lib/python3.11/unittest/case.py", line 57, in testPartExecutor
    yield
  File "/Users/maurits/.pyenv/versions/3.11.7/lib/python3.11/unittest/case.py", line 623, in run
    self._callTestMethod(testMethod)
  File "/Users/maurits/.pyenv/versions/3.11.7/lib/python3.11/unittest/case.py", line 579, in _callTestMethod
    if method() is not None:
  File "/Users/maurits/shared-eggs/cp311/plone.dexterity-3.0.5-py3.11.egg/plone/dexterity/tests/test_webdav.py", line 1174, in test_acquire_without_dav
    r = traversal.publishTraverse(request, "item")
  File "/Users/maurits/shared-eggs/cp311/plone.dexterity-3.0.5-py3.11.egg/plone/dexterity/browser/traversal.py", line 40, in publishTraverse
    defaultTraversal = super().publishTraverse(request, name)
  File "/Users/maurits/community/plone-coredev/6.0/src/Zope/src/ZPublisher/BaseRequest.py", line 142, in publishTraverse
    self.request.ensure_publishable(subobject)
AttributeError: 'DAVTestRequest' object has no attribute 'ensure_publishable'

...

Error in test test_get_acquired (plone.dexterity.tests.test_webdav.TestDexterityPublishTraverse.test_get_acquired)
Traceback (most recent call last):
  File "/Users/maurits/.pyenv/versions/3.11.7/lib/python3.11/unittest/case.py", line 57, in testPartExecutor
    yield
  File "/Users/maurits/.pyenv/versions/3.11.7/lib/python3.11/unittest/case.py", line 623, in run
    self._callTestMethod(testMethod)
  File "/Users/maurits/.pyenv/versions/3.11.7/lib/python3.11/unittest/case.py", line 579, in _callTestMethod
    if method() is not None:
  File "/Users/mauri... (continued)

4497 of 7120 branches covered (63.16%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

28119 of 32456 relevant lines covered (86.64%)

0.87 hits per line

Relevant lines Covered
32456 RELEVANT LINES 28119 COVERED LINES
0.87 HITS PER LINE
Source Files on maurits-ensure-publishable

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
8806350432 maurits-ensure-publishable Do not fail when request has no ensure_publishable method. This may happen in tests. In a Plone core development buildout with Zope master there are failures in `plone.dexterity`: ``` $ bin/test -s plone.dexterity -u ... Error in test test_acqui... push mauritsvanrees github
82.41
See All Builds (4018)