zopefoundation / AccessControl

81%

master: 82%

LAST BUILD ON BRANCH fix/dict-views

branch: fix/dict-views

CHANGE BRANCH

x

Reset

• fix/dict-views
• 123-prevent-race-condition
• 123-prevent-race-condition-2
• 1letter/patch-owner
• 4.0
• 4.0a5
• 4.0a6
• 4.0a7
• 4.0b5
• 4.0b6
• 4.0b7
• 4.1
• 4.2
• 5.0
• 5.3
• 5.3.1
• 5.4
• 5.5
• 5.6
• 5.7
• 6.0
• 6.1
• 6.2
• 6.3
• 7.0
• 7.1
• 7.2
• 83-allow-bytes-as-simple-object-policies
• TaintedBytes
• add-deprecations
• all-repos_autofix_all-repos-sed
• config-with-c-code
• config-with-c-code-II
• config-with-c-code-template-1c0f31f5
• config-with-c-code-template-4dc0484e
• config-with-c-code-template-4eec7859
• config-with-c-code-template-54befd0e
• config-with-c-code-template-9f78efd3
• config-with-c-code-template-a361e1fd
• config-with-c-code-template-a7193216
• config-with-c-code-template-e45966cd
• dataflake/packaging-update
• dict_kvi_iteration#89
• drop-history
• drop-py313
• drop-py34
• drop-record-dependency
• fewer-doctests
• fix-81
• fix-85
• fix-deprecations
• fix-lint
• fix-macos-build-errors
• fix-py34
• fix-rolemanager
• fix-roles-order
• fix_94
• fix_deprecation_warnings
• fix_impl_python
• fix_importerror
• flake8_isort
• icemac-patch-1
• master
• maurits/setup-py-keywords
• origin/plone-hotfix20171128-format-master
• perrinjerome/PURE_PYTHON
• perrinjerome/getattr_unauthorized
• proper_args_kwargs
• pure-python
• pure-python-switch
• py3-pure-python
• py312
• py37-appveyor
• py39
• py3_impor
• py3_imports
• python3.7support
• re-60-simplify-import-guard
• remove-deprecations
• remove-old-deprecations
• remove-outdated-comment
• rolemanager-py3k-compat
• rotonen-purepython
• sallner-update-link
• str-format-master
• update-isort
• update_zmi_icon
• zmi-bootstrap
• zodbupdate

Build # 8261778867

Build Type

Pull #148

github

Committed by perrinjerome

Commit Message

Make dict views behave like their unrestricted versions

unlike the restricted versions, the unrestricted versions:
 - are not iterators, they are views
 - have a len
 - are false when the mapping is empty, true otherwise
 - are instances of collections.abc.MappingView

This change aligns the behavior of restricted versions with the behavior
of unrestricted one, while keeping the "guard", which validates the
access with the security manager.

During this refactoring, also change `.items()` to validate
ach keys and values, like `.keys()` and `.values()` do.

Co-authored-by: Dieter Maurer <d-maurer@users.noreply.github.com>

Pull Request Pull Request #148: Make dict views behave like their unrestricted versions

Run Details

951 of 1475 branches covered (64.47%)

Branch coverage included in aggregate %.

72 of 72 new or added lines in 3 files covered. (100.0%)

5055 of 5911 relevant lines covered (85.52%)

5.12 hits per line