zhaozg / lua-openssl
93%
master: 94%

LAST BUILD BRANCH: HEAD
DEFAULT BRANCH: master
Repo Added
Files 45
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH copilot/improve-openssl-code-review
branch: copilot/improve-openssl-code-review
CHANGE BRANCH
x

coverage: 93.154%. Remained the same
19190194259

push

travis-ci

Copilot 
Fix Provider API OpenSSL/LibreSSL compatibility and improve test handling

Address maintainer feedback for proper version adaptability:

Changes:
1. Enhanced version guards to explicitly exclude LibreSSL
   - src/provider.c: Added !defined(LIBRESSL_VERSION_NUMBER) check
   - src/openssl.h: Updated declaration guard
   - src/openssl.c: Updated registration guard
   - Added comment explaining LibreSSL exclusion

2. Improved test file error handling and messaging
   - test/provider.lua: Enhanced version detection
   - Better error messages when provider is unavailable
   - Display current OpenSSL version when tests are skipped
   - Check for both module availability and _error flag

3. Added verification script
   - test/provider_check.lua: Quick diagnostic tool
   - Shows OpenSSL version, LibreSSL detection
   - Lists available providers on compatible systems
   - Clear compatibility status reporting

Version Guard Pattern:
  Old: #if (OPENSSL_VERSION_NUMBER >= 0x30000000L)
  New: #if (OPENSSL_VERSION_NUMBER >= 0x30000000L) && !defined(LIBRESSL_VERSION_NUMBER)

This ensures provider module:
- Compiles only on OpenSSL 3.0+
- Skips compilation on LibreSSL (any version)
- Provides stub with error message on incompatible versions
- Tests gracefully skip with clear messaging

Test Behavior:
- OpenSSL 3.0+: All tests run normally
- OpenSSL < 3.0: Tests skip with version message
- LibreSSL: Tests skip with LibreSSL message
- Build system: Compiles cleanly on all platforms

Co-authored-by: zhaozg <542599+zhaozg@users.noreply.github.com>

9811 of 10532 relevant lines covered (93.15%)

2076.23 hits per line

Relevant lines Covered
10532 RELEVANT LINES 9811 COVERED LINES
2076.23 HITS PER LINE
Source Files on copilot/improve-openssl-code-review

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
19190194259 copilot/improve-openssl-code-review Fix Provider API OpenSSL/LibreSSL compatibility and improve test handling Address maintainer feedback for proper version adaptability: Changes: 1. Enhanced version guards to explicitly exclude LibreSSL - src/provider.c: Added !defined(LIBRESS... push Copilot travis-ci
93.15
19189553740 copilot/improve-openssl-code-review Add Provider API support for OpenSSL 3.0+ Implement comprehensive provider module with Lua bindings: - src/provider.c: Full provider API implementation - load/unload providers (default, fips, legacy, base, null) - Query provider name, availab... Pull #339 Copilot travis-ci
93.15
19189336343 copilot/improve-openssl-code-review Fix deprecated OpenSSL API usage in digest.c and pkey.c Replace EVP_MD_CTX_create/destroy with EVP_MD_CTX_new/free - Replace all EVP_MD_CTX_create() calls with EVP_MD_CTX_new() - Replace all EVP_MD_CTX_destroy() calls with EVP_MD_CTX_free() - Rem... Pull #339 Copilot travis-ci
93.15
See All Builds (495)