zendframework / zend-mvc

76%

master: 36%

LAST BUILD ON BRANCH release-2.4.8

branch: release-2.4.8

CHANGE BRANCH

x

Reset

• release-2.4.8
• develop
• master
• next
• release-2.4.9
• release-2.7
• release-3.1.1

Build # 81

Build Type

push

travis-ci

Committed by weierophinney

Commit Message

Fix 'Call to a member function hasChildren() on boolean'

- This seems to occur when the DefaultRenderingStrategy tries to render
  a result that is not an instance of Zend\View\Model\ModelInterface, in
  my case the result was a boolean true.
- I'm checking for ModelInterface rather than ConsoleModel as the render
  method seems to work with any ModelInterface, not just ConsoleModel

This patch also fixes several testing issues, and CS, to ensure QA tools will
pass on the 2.4 series:

- Adds in test assets from other components to ensure they can be used in tests
  locally.
- Updates tests to use local test assets.
- Updates composer.json dependencies to reference `~2.4.0` (or next significant
  maintenance release) instead of `self.version`.
- Fixes the `.php_cs` configuration to specify the directories to run within.

Run Details

2860 of 3757 relevant lines covered (76.12%)

13.04 hits per line