zakoverflow / note-c

93%

push

github

Fix card.binary HIL test build on STM32 Arduino core 3.x (#256)

* Fix card.binary HIL test build on STM32 Arduino core 3.x.

- PlatformIO's ststm32 20.0.0 platform brings in STM32 Arduino core 3.0.
  The test's platformio.ini does not pin the platform, so CI picked it up.
- Core 3.x declares Serial2 and Serial3 itself. The test's own Serial2 and
  Serial3 objects then fail with "conflicting declaration".
- Core 3.x also makes HardwareSerial an abstract class. Uart is now the
  concrete UART class.
- Remove Serial2. No code uses it.
- Rename Serial3 to notecardSerial. It keeps the same pins (A5 RX, A4 TX).
- Pick Uart on core 3.x and HardwareSerial on core 2.x, so the test builds
  on both cores.
- Checked with local builds on core 3.0 (ststm32 20.0.0) and core 2.12
  (ststm32 19.7.1).

This commit message was written by Claude, an AI agent.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* Mask Notehub and MD5 server tokens in card.binary HIL workflow logs.

- The workflow writes NOTEHUB_ACCESS_TOKEN and MD5SRV_TOKEN to GITHUB_ENV.
  GitHub does not mask values that a step writes there. It printed both
  tokens in plain text in the env block of every later step.
- The "Notehub HTTP route request" log line also printed MD5SRV_TOKEN.
- Send ::add-mask:: for each token before the step writes it to
  GITHUB_ENV. GitHub then shows *** in place of the token in all later
  output.

This commit message was written by Claude, an AI agent.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* Fail the card.binary HIL upload when GDB can't flash the Swan.

- The upload command passed each GDB command with -ex and ended with
  "quit". GDB runs later -ex commands after one fails, and "quit" exits 0.
  A failed connect or load looked like a successful upload.
- The job then waited for the Swan's USB port and failed with a
  misleading "Timed out waiting for test port" error.
- Move "monitor reset halt", "load", and "monito... (continued)

1229 of 1409 branches covered (87.22%)

Branch coverage included in aggregate %.

2526 of 2611 relevant lines covered (96.74%)

80.3 hits per line