yuin / goldmark

87%

master: 83%

LAST BUILD ON BRANCH refs/tags/v1.7.8

branch: refs/tags/v1.7.8

CHANGE BRANCH

x

Reset

• refs/tags/v1.7.8
• feature/emb-map-data
• fix/walk-and-replace
• master
• refs/tags/1.1.27
• refs/tags/v.1.1.13
• refs/tags/v.1.1.21
• refs/tags/v1.1.10
• refs/tags/v1.1.11
• refs/tags/v1.1.12
• refs/tags/v1.1.14
• refs/tags/v1.1.15
• refs/tags/v1.1.16
• refs/tags/v1.1.17
• refs/tags/v1.1.18
• refs/tags/v1.1.19
• refs/tags/v1.1.20
• refs/tags/v1.1.21
• refs/tags/v1.1.22
• refs/tags/v1.1.23
• refs/tags/v1.1.24
• refs/tags/v1.1.25
• refs/tags/v1.1.26
• refs/tags/v1.1.27
• refs/tags/v1.1.28
• refs/tags/v1.1.29
• refs/tags/v1.1.30
• refs/tags/v1.1.31
• refs/tags/v1.1.32
• refs/tags/v1.1.33
• refs/tags/v1.1.4
• refs/tags/v1.1.5
• refs/tags/v1.1.6
• refs/tags/v1.1.7
• refs/tags/v1.1.8
• refs/tags/v1.1.9
• refs/tags/v1.2.0
• refs/tags/v1.2.1
• refs/tags/v1.3.0
• refs/tags/v1.3.1
• refs/tags/v1.3.2
• refs/tags/v1.3.3
• refs/tags/v1.3.4
• refs/tags/v1.3.5
• refs/tags/v1.3.6
• refs/tags/v1.3.7
• refs/tags/v1.3.8
• refs/tags/v1.3.9
• refs/tags/v1.4.0
• refs/tags/v1.4.1
• refs/tags/v1.4.10
• refs/tags/v1.4.11
• refs/tags/v1.4.12
• refs/tags/v1.4.13
• refs/tags/v1.4.14
• refs/tags/v1.4.15
• refs/tags/v1.4.2
• refs/tags/v1.4.3
• refs/tags/v1.4.4
• refs/tags/v1.4.5
• refs/tags/v1.4.6
• refs/tags/v1.4.7
• refs/tags/v1.4.8
• refs/tags/v1.4.9
• refs/tags/v1.5.0
• refs/tags/v1.5.1
• refs/tags/v1.5.2
• refs/tags/v1.5.3
• refs/tags/v1.5.4
• refs/tags/v1.5.5
• refs/tags/v1.5.6
• refs/tags/v1.6.0
• refs/tags/v1.7.0
• refs/tags/v1.7.1
• refs/tags/v1.7.10
• refs/tags/v1.7.11
• refs/tags/v1.7.12
• refs/tags/v1.7.13
• refs/tags/v1.7.2
• refs/tags/v1.7.4
• refs/tags/v1.7.5
• refs/tags/v1.7.6
• refs/tags/v1.7.7
• refs/tags/v1.7.9
• v1.0.0
• v1.0.1
• v1.0.10
• v1.0.2
• v1.0.3
• v1.0.4
• v1.0.5
• v1.0.6
• v1.0.7
• v1.0.8
• v1.0.9
• v1.1.0
• v1.1.1
• v1.1.2
• v1.1.3

Build # 11365329513

Build Type

push

github

Committed by yuin

Commit Message

Deprecate Node.Text

Node.Text was intended to get a text value from some inline nodes.
A 'text value' of a Text node is clear.

But

- BaseNode had a default implementation of Node.Text
- Lacks of GoDoc description that Node.Text is valid only for
  some inline nodes

So, some users are using Node.Text for BlockNodes.

A 'text value' for a BlockNode is not clear.

e.g. : Text value of a ListNode

- It should be contains list markers?
- What do characters concatinate List items with? newlines? spaces?
- If it contains codeblocks, codeblocks should be fenced or indented?

Now we would like to avoid such ambiguous method.

Run Details

12 of 13 new or added lines in 2 files covered. (92.31%)

8298 of 9570 relevant lines covered (86.71%)

249579.56 hits per line