yuce / pot

100%

master: 100%

Pull #24

travis-ci

Add return_interval option to valid_hotp

There is a flaw in the `valid_hotp` logic introduced in https://github.com/yuce/pot/pull/15 that prevents it from being effectively used: because it returns a raw `boolean`, there is no way to know *which* interval matched: the next one, the 1000th one, or somewhere in between? In order to effectively implement a proper HOTP scheme, you need to track the interval number of the last valid HOTP to prevent its reuse, OR the reuse of a HOTP from any previous interval.

For backwards compatibility, I have retained the default `boolean()` response, but if the `return_interval` option is set, the interval will be returned when a hotp is valid, like `{true, interval()}`.

3 of 3 new or added lines in 1 file covered. (100.0%)

140 of 140 relevant lines covered (100.0%)

7200.06 hits per line