youtube / vitess

44%

master: 61%

LAST BUILD ON BRANCH invalid-heap-pointer

branch: invalid-heap-pointer

CHANGE BRANCH

x

Reset

• invalid-heap-pointer
• ResultSet_Changes
• VitessDatabaseMetadataTest
• aaijazi_access_control_for_vtworker
• aaijazi_add_back_error_tests
• aaijazi_add_influxdb_support
• aaijazi_add_monitoring_docs
• aaijazi_add_vars_to_workers
• aaijazi_add_vitess_error_enum
• aaijazi_add_worker_tests
• aaijazi_batch_insert_in_worker_test
• aaijazi_context_for_workers
• aaijazi_correct_casing_of_flag
• aaijazi_debug_querylogs
• aaijazi_demote_deadlocks_in_logs
• aaijazi_disable_query_service
• aaijazi_error_code_for_tablet_errors
• aaijazi_export_target_tablet_type
• aaijazi_fix_flaky_tests
• aaijazi_fix_influxdb_flags
• aaijazi_fix_tmclient_timeout_error
• aaijazi_fix_vtgate_status
• aaijazi_improve_vtworker_retries
• aaijazi_interrupt_workers_via_context
• aaijazi_remove_callinfo_from_vtgate
• aaijazi_resharding_robustness_test
• aaijazi_sharding_guide
• aaijazi_vitess_errors_prototype
• aaijazi_vtgate_streaming_errors
• aaijazi_vtgate_use_callinfo
• aaijazi_vtworker_insert_as_client
• aaijazi_worker_better_retries
• aaijazi_workers_reresolve
• aaijazi_workers_reresolve_integration_testing
• aaijazi_workers_resolve
• aaijazi_workers_retry_on_error
• add_tabletaddr_to_topo
• additional_bind_fields
• andywork
• ashudeep_temp
• autoCommitChanges
• automation_first_minimal_version
• automation_first_minimal_version_review
• avoid-rebuilds
• backport_java_test_fix
• bootstrap-proxy
• bootstrap-skip
• broader_coverage
• broader_coverage_gocovmerge
• bsongen_test
• callerid2
• caseInsensitiveMap
• ceph1
• cephImprove
• cgzip_test
• client_lib
• cname
• coveralls-newrelic-skip
• date-locale
• debug_travis_memory_usage
• diff_utils_test
• discovery_filter_helpers
• docker
• docker-test
• etcd-explorer
• etcdtopo-test
• examples
• exp-retry
• experimental
• export_nerd
• export_stathooks
• failing-test
• fast-external-reparent
• fix-flaky-tests
• fix_docker_run_permissions_root
• fix_grpc_go
• fix_grpc_python
• fix_small_test
• gcloud-alpha
• getsrvshard
• getting-started
• go-1.4
• go-generate
• goclient_flags
• godep
• golint
• guestbook
• hc
• health
• healthcheck
• healthcheck_resolver_review
• import_java_changes
• integration-test-coverage
• java-mvn-repo
• java_example
• jdbc
• jdbc-work1
• jdbc_preparedstatement_func
• k8s-doc
• k8s-proxy-js
• kube-down-failfast
• kube-etcd
• kube-init-tablet
• kube-startup
• kubernetes
• list_var
• local-cluster
• local-setup
• log
• log-fatal
• lookupVindex
• make_disable_parallel_make_for_test
• make_test_add_java
• master
• michael-berlin-patch-1
• minio-v-upgrade
• mutl-row-insert
• mysql-force-close
• mysql56
• mysql_flags
• mysql_flags_java_client
• mysql_upgrade
• orchestrator
• osgateway
• php
• proc-test
• proto
• protorename
• publish-site
• py_keys
• release-2.0
• replication
• resharding
• revert-1209-aaijazi_cleanup_error_flag
• revert-1223-change_protocol_defaults_to_grpc
• revert-1229-export_internal_changes
• revert-1235-patch-1
• revert-1599-splitquery_e2e
• rulesdemo
• sandbox
• schema-editor-dir
• shardconn
• shardconn2
• short-name
• split-host-port
• split-query-fixes
• squirrel
• stream_health_query_service_fake
• sugudoc
• sugufix
• suguwork
• table-acl-fix
• test-main
• test.go
• throttler_filtered_replication_plumbing
• topo
• topo_dependency_removal
• topoclean
• trace
• travis
• travis-fix-deps
• travis-flaky-tests
• travis-go-1.4
• travis-low-mem
• travis_go15
• travis_sauce
• tx_not_found
• tx_timeout
• unbreak_my_heart
• unittest
• unsecure-username
• update_mariadb_download
• v2.0
• v2.0.0
• v2.0.0-alpha1
• v2.0.0-alpha2
• v2.0.0-alpha3
• v2.0.0-alpha4
• v2.0.0-alpha5
• v2.0.0-beta.1
• v2.0.0-beta.2
• v2.0.0-rc.1
• v2.0.0-rc.2
• vindex_varchar_support
• vitess_1994
• vitess_drop_IfExists_Flag
• vitess_issue_1731
• vitess_issue_1731_2
• vtclient
• vtctl_webdriver_test
• vtctld-explorer
• vtctld-explorers
• vtctld_webdriver_test
• vtgate
• vtgate-fail-fast-test
• vtgate_exc_cleanup
• vtgatechg
• vtgateclose
• vtgatecode
• vtgatecommit
• vtgateconn
• vtgateerr
• vtgateerror
• vtgatelog
• vtgatescatter
• vtgatevarz
• vtworker_fake_pool_connection
• webdriver2
• zktopo-lock-timeout

Build # 431

Build Type

push

travis-ci

Committed by enisoc

Commit Message

Fix "invalid heap pointer" crash when built with Go 1.4.

The CGO wrapper for ZK was casting arbitrary integers to unsafe.Pointer.
For example, it would call C.something(unsafe.Pointer(1)) in order to
call "void something(void* tag)" with a tag value of (void*)1.

In Go 1.4, if a GC happens to occur while C.something() is executing, it
will find the unsafe.Pointer(1) on the stack and crash because 1 is not
a valid memory address.

Run Details

17178 of 38713 relevant lines covered (44.37%)

0.44 hits per line