yitsushi / totp-cli

40%

master: 20%

LAST BUILD ON BRANCH 95-fix-no-newline-input

branch: 95-fix-no-newline-input

CHANGE BRANCH

x

Reset

• 95-fix-no-newline-input
• master
• put-windows-back
• v1.1.10
• v1.1.11
• v1.1.12
• v1.1.13
• remove-util
• main
• import-command
• add-prefix
• refs/tags/v1.2.0
• refs/tags/v1.2.1
• fix-release-build
• refs/tags/v1.2.2
• update-checkout-action
• return-nil
• remove-panic
• refs/tags/v1.2.3
• refs/tags/v1.2.4
• refs/tags/v1.2.5
• 47-clear-prefix
• refs/tags/v1.2.6
• refs/tags/v1.2.7
• improve-kdf-test-pr-check
• refs/tags/v1.3.0
• document-default-cred-path
• refs/tags/v1.3.1
• refs/tags/v1.3.2
• 74-fix-update-error-handling
• refs/tags/v1.3.3
• use-urfave
• refs/tags/v1.4.0
• pass-with-env
• refs/tags/v1.5.0
• small-changes
• update-deps
• refs/tags/v1.5.1
• refs/tags/v1.5.2
• refs/tags/v1.5.3
• some-random-fixes
• refs/tags/v1.6.0
• 88-remaining-time
• refs/tags/v1.7.0
• rename-account
• update-workflow-versions
• remove-update-command
• v1.8.0
• try-to-fix-autocomplete
• v1.8.1
• v1.8.2
• v1.8.3
• dependabot/go_modules/golang.org/x/crypto-0.17.0
• v1.8.4
• v1.8.5
• 38-auto-versioning
• v1.8.6
• add-release-signing
• v1.8.7
• add-signing-keys-to-readme
• update-some-comments
• refactor-storage
• some-cleanup
• update-deps-20240619

Build # 6585536680

Build Type

Pull #96

github

Committed by yitsushi

Commit Message

fix: empty string when new newline at the end of stdin

The code reads the token from `stdin` until newline. If there is no
newline, it counts the content as empty string.

We use `bufio.NewReader` with `reader.ReadString('\n')` which "reads
until the first occurrence of delim in the input". When it can't find a
newline character before the stream ends we return with an error and an
empty string.

Fix: As `reader.ReadString` returns with the content before the error in
all cases, we can return with the content even if we meet an error.

Note: We should check if the error was EOF on caller side everywhere.

Fixes #95

References:
* https://github.com/yitsushi/totp-cli/issues/95

Signed-off-by: Efertone <efertone@pm.me>

Pull Request Pull Request #96: fix: empty string when new newline at the end of stdin

Run Details

1 of 1 new or added line in 1 file covered. (100.0%)

152 of 384 relevant lines covered (39.58%)

3.78 hits per line