yext / search-ui-react
88%

DEFAULT BRANCH: main
Repo Added
Files 108
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH main
branch: main
CHANGE BRANCH
x

coverage: 88.287% (+0.7%) from 87.593%
16808152136

push

github

web-flow 
Deduplicate generative direct answer calls (#554)

The effect hook that triggers a GDA call has two dependencies: the search results and the search ID. These both change when a search is made. In React 18, these updates are batched together so only one call to GDA gets made when the search is updated. However, in React 17, no batching is performed and updates are handled in order, meaning a call to GDA is made when the search results are updated and when the search ID is updated, even if the same search triggers both updates. This change tracks the search results and only executes a new GDA call if the search results have changed.

J=WAT-4861
TEST=manual

Created a local test site that runs on React 17. Made a local tarball with my changes to search-ui-react using npm pack and pointed the local test site's import of search-ui-react to the tarball. Confirmed that only one GDA call is made per-seasrch.

Also spun up the search-ui-react test-site (which runs on React 18) and confirmed that GDA calls are still made once per search as expected.

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

820 of 1026 branches covered (79.92%)

Branch coverage included in aggregate %.

3 of 4 new or added lines in 1 file covered. (75.0%)

2067 of 2244 relevant lines covered (92.11%)

135.95 hits per line

Relevant lines Covered
2244 RELEVANT LINES 2067 COVERED LINES
135.95 HITS PER LINE
Source Files on main

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
16808152136 main Deduplicate generative direct answer calls (#554) The effect hook that triggers a GDA call has two dependencies: the search results and the search ID. These both change when a search is made. In React 18, these updates are batched together so onl... push web-flow github
88.29
16731600472 main Revert "Debounce generative direct answer calls" This reverts commit 5523946e1. push mkouzel-yext github
87.59
16731549985 main Debounce generative direct answer calls The effect hook that triggers a GDA call has two dependencies: the search results and the search ID. These both change when a search is made. In React 18, these updates are batched together so only one call... push mkouzel-yext github
88.29
16503306612 main Apply FitBoundsOptions to MapboxMap if present (#551) Passes the FitBoundsOptions to the MapboxMap's fitBounds handler if present on the MapboxOptions prop. These options are defined in https://docs.mapbox.com/mapbox-gl-js/api/map/#map#fitbounds.... push web-flow github
88.34
16419564668 main Fix CurrentLocationIcon prop names (#548) Incorrect names were throwing warnings. Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> push web-flow github
87.59
16152090902 main Add name property for near field value filters (#545) Bumps search-headless-react version to include change that added optional name property for near field value filters. * Update snapshots --------- Co-authored-by: github-actions <41898282+g... push web-flow github
88.34
16125266659 main Use react-i18next for default translations (#543) * Use react-i18next for default translations The default translations live in the locales/ folder. To enable translation on the react components, use <SearchI18nextProvider/> wrapper. SearchI18ne... push web-flow github
88.34
15907528776 main Version 1.8.15 ### Changes - allow specifying Matchers in StaticFilters push web-flow github
88.19
15858323119 main Version 1.8.14 ### Changes - Adds support for OpenAt Matcher push web-flow github
87.43
15739140045 main Cleanup various event listeners (#534) * Cleanup various event listeners Also make sure localizeMap() is executed when map style changes as well. TEST=manual verified map is localized upon style changes as well * Update snapshots --------- C... push web-flow github
88.19
See All Builds (1638)