woothemes / woocommerce

22%

master: 53%

LAST BUILD ON BRANCH variation-no-parent-fix

branch: variation-no-parent-fix

CHANGE BRANCH

x

Reset

• variation-no-parent-fix
• 2.2
• 2.2.0
• 2.2.10
• 2.2.11
• 2.2.4
• 2.2.5
• 2.2.6
• 2.2.7
• 2.2.8
• 2.2.9
• 2.3.0
• 2.3.0-RC1
• 2.3.0-beta-1
• 2.3.0-beta-2
• 2.3.0-beta-3
• 2.3.1
• 2.3.10
• 2.3.11
• 2.3.12
• 2.3.13
• 2.3.2
• 2.3.3
• 2.3.5
• 2.3.6
• 2.3.7
• 2.3.8
• 2.3.9
• 2.4.0
• 2.4.0-RC1
• 2.4.0-beta-1
• 2.4.0-beta-2
• 2.4.0-beta-3
• 2.4.0-beta-4
• 2.4.1
• 2.4.10
• 2.4.11
• 2.4.12
• 2.4.2
• 2.4.3
• 2.4.4
• 2.4.5
• 2.4.6
• 2.4.7
• 2.4.8
• 2.4.9
• 2.5.0
• 2.5.0-RC1
• 2.5.0-RC2
• 2.5.0-RC3
• 2.5.0-beta-2
• 2.5.0-beta-3
• 2.5.1
• 2.5.2
• 2.5.3
• 2.5.4
• 2.5.5
• 2.6.0
• 2.6.0-RC1
• 2.6.0-RC2
• 2.6.0-beta-1
• 2.6.0-beta-2
• 2.6.0-beta-3
• 2.6.0-beta-4
• 2.6.1
• 2.6.2
• 2.6.3
• 2.6.4
• 4-4-term-meta-handling
• 6226-fix-order-fields-on-checkout
• 6711-opt-in-tracking
• 7733-allow-saving-empty-download-expiry-date
• 9251-wc-cart-functions
• 9381-help-tip-icon-font
• MarinaWoo-patch-1
• SiR-DanieL-patch-1
• SiR-DanieL-patch-2
• Tax-rate-matching-logic
• WC-CRUD
• WC_Data_Exception
• WPprodigy-patch-1
• WPprodigy-patch-1-1
• WPprodigy-patch-2
• WPprodigy-patch-flat-rate
• add-email-notification-for-partial-refunds-issue-8278
• add-empty-order-item-meta-issue8-339
• add-refunds-to-orders-endpoint
• add-to-cart-handlers
• add/10954-shipping-zones-api
• add/10954-shipping-zones-api-endpoint
• add/allow-checkout-refresh-without-failure-result
• add/alternate-email-sender
• add/esc_attr_e
• add/id-based-section-loading-shipping-and-checkout
• add/more_esc_attrs
• add/photoswipe
• add/product-galleries
• add/product-reviews-create-and-update
• add/select-all-buttons-multiselect-field
• add/shipping-zone-method-hooks
• add/system-status-tools-api
• add/wc-api-loading-hooks
• add/wcc-related-tracker-data
• add/wp.template-templating
• added-changelog-for-api-changes
• adjust-campaign-tags
• admin-ajax-variations
• ajax-variations
• allow-paths-in-file-urls
• alternative-myaccount-structure
• api-auth-endpoint
• api-product-attributes
• api-signature-tweak
• api-tax-endpoint
• api-test-base
• api-tweaks
• avoid-multi-get-default-calls
• background-updates
• better-ip-check
• blank-slates
• breadcrumbs-class
• bulk-taxes-endpoint
• cart-undo
• changelogs
• chosen-to-select2
• cli
• cli-taxes
• code-style/bulk_post_updated_messages
• code-style/feature-update-variations-from-cart
• code-style/feature/schema-offer-improvements
• code-style/fix-grouped-addtocart-message
• code-style/fix-paypal-api-link
• code-style/improve-wp-count-comments
• code-style/improved-structured-data
• code-style/internationalization_fix
• code-style/master-068e169
• code-style/master-1ff19a3
• code-style/master-2ed2b6d
• code-style/master-6faeb89
• code-style/nav-filters-on-search
• code-style/order-pagination
• code-style/patch-1
• code-style/patch-3
• code-style/small-fixes
• code-style/status_report_db_prefix
• consistant-triggers-11119
• contextual-storefront-button
• contributing-guide-update
• copy-update
• coupon-calc
• coupon-exceptions
• crud-meta-id
• crud-orders
• crud-private-protected
• customer-exceptions
• discount-calculation
• discount-calculation-class-4404
• discount-rounding-mode
• download-layout-11806
• email-settings-ui
• email-styling-issues
• enhancement/6502
• enhancement/checkout-order-review-error-handling
• exensible-addons-screen
• extendable-addons-screen
• feature/wp-cli_support
• fix-10135
• fix-11245
• fix-11262
• fix-11570
• fix-readme-requirements
• fix-reports-custom-daterange
• fix/11543-undefined-custom-reports
• fix/api-check_permission
• fix/batch-api-typo
• fix/button-opacity
• fix/customer-api-avatar-url
• fix/install-wp-tests-latest-wp
• fix/misc-api-issues
• fix/mysql-status-report
• fix/no-instance-id-for-non-classname-shipping-methods
• fix/pinking-shears
• fix/product-api-filter-wp-query
• fix/product-bulk-edit-webhook
• fix/secondary-button-opacity
• fix/wc-2-6-travis-config
• fix/wc-payment-tokens-older-php
• flat-rate-shipping-refactor
• form-fields-11326
• generic-login-error-message
• geolocate-cache
• get-coupon-code-by-id
• group-notices-11226
• hotfix-duplicate-session-errors
• hotfix-logout-endpoint
• hotfix-orders-search
• hotfix-partial-refunds-rounding
• hotfix-tracker-updates
• hotfix-update-product-cat-links
• image-upload-error-messages
• improve-categories-image
• improve-configure-terms
• improve-endpoints
• improve-get-downloads-speed
• improve-log-viewer
• improve-product-attributes
• improve-refund-reporting
• include-all-methods-in-count
• issue-9583/order-items-escape
• issue-9584/fix-price-ordering
• issue-9592/SVG-variation-images
• issue-9641/zips
• issue-9681/lingering-gallery-images
• issue/8458-refactor-verified-purchase-review-meta
• issue/8587
• issue/8804-reload-mini-cart-refresh-nonces
• issue/9166-reset-order-customer-id-on-user-delete
• issue/9268-get-coupon-id-from-code-caching
• issue/9284-fix-potential-fatal-for-earlier-init-plugins
• issue/9727-order-review-payment-method-change-ui
• issue/9769-set-current-gateway-php-fatal
• issue/simplify-commerce-address-fields
• issues/10837/fix-data-updater
• issues/10946/add-classes-for-payment-method-row
• issues/11664/fix-func_get_args-warning
• issues/8482
• issues/8879-categories-tags-api-addition
• issues/8948
• issues/8971-filter-products-by-tax
• issues/9101-dont-show-undo-if-product-is-not-purchasable
• issues/9110-fix-failed-log-test
• issues/9125-report-does-not-match-with-chart
• issues/9223-attribute-tax-permission-issues
• item-box-tweaks
• layered-nav-wp-query
• legacy-shipping-method-notice-tweak
• localization-tweaks
• master
• memcache-install-welcome-redirect
• minor-edits
• move-exit-download
• msdesign21-patch-1
• multisite-login-11409
• oauth1-headers
• onboarding
• order-crud-api
• order-notes-sanitisation
• orders-crud-classes
• orders-crud-function-update
• out-of-stock-threshold-11322
• pages-cant-be-created-on-install-issue-8269
• password-reset-flow
• payment-gateway-api
• payment-gateway-wizard-refactor
• payment-request-api
• payment-token-checkout-update-11492
• paypal-auto-capture-10563
• paypal-use-price_num_decimals-option
• plain-text-email
• pr/9034
• price-filter-widget-pagination
• price-inc-tax-hell-11626
• product-data-css-fix
• products-crud
• release/2.3
• release/2.4
• release/2.5
• release/2.6
• remove-order-items-query-speed
• reports-api-fixes
• rest-api-load-priority
• rest-api-orders-search
• revised-single-variation-cart-template
• save-fields-refactor-8495
• scrutinizer-patch-1
• select2-admin
• settings-and-api-fixes
• settings-api
• shipping-costs
• shipping-method-api
• shipping-methods
• shipping-wizard-removal
• shipping-zones
• shipping-zones-in-array
• simplify
• simplify-ireland-support
• slash1andy-patch-1
• system-status-api
• system-status-tools-options
• tabbed-my-account
• tax-rate-auto-ordering
• tax-settings-escape
• test-price-filter
• text-attribute-handling
• tooltip
• tracking-duplicate-optins
• transient-tweaks
• ua-tracking-11848
• unit-test-country-state-string
• universal-pricing-test
• update/coupon-api-crud
• update/customer-api-crud
• update/normalization-functions-from-unit
• update/wp-admin-system-status
• upsell-variations
• utm-links
• v2.2.0-RC1
• v2.2.1
• v2.2.2
• v2.2.3
• variable-weight-display-10621
• variation-desc
• variation-prices-sync
• variations-8477
• variations-hijax
• video-hash-updates
• wc-ajax-endpoint
• webhooks-settings-tab
• webhooks-ui
• wizard-language-download
• woocommerce
• wp-api
• wp-api-batch

Build # 6868

Build Type

push

travis-ci

Committed by mikejolley

Commit Message

Prevent variations being created/returned without parents

Nasty bug discovered by @RiaanKnoetze where it would get a variation
without parent, and due to the return, it wouldn’t be ‘seen’ as a
variation, therefore creating fatal errors when props are called.

To prevent this, lets allow product constructors to throw exceptions.
If they do, the factory class will catch them and return false instead
of an invalid product object.

@claudiosmweb Thoughts on this one before merge?

Run Details

13 of 13 new or added lines in 2 files covered. (100.0%)

6292 of 28460 relevant lines covered (22.11%)

10.33 hits per line