wooga / atlas-release
98%
master: 81%

LAST BUILD BRANCH: PR-118
DEFAULT BRANCH: master
Repo Added
Files 10
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH PR-50
branch: PR-50
CHANGE BRANCH
x

3

push

jenkins

Fix Snapshot branchname strategy

Description
===========

The `PartialSemVerStrategy` `STAGE_BRANCH_NAME` tries to generate a
unique semver 2.0 prerelease pattern. The provided tests where mostly
written in an optimistic fashion. This patch fixes the strategy when
branch names are in use which contain unusual characters or character
combinations.

As an example:

The branchName `feature/button_01` would yield a prerelease part of:
`branch.feature.button.01` which is not semver 2 compatible. Numerical
parts are not allowed to be `0` padded. The strategy also kept hanging
characters like `-`,`+`,`_`.

This patch tries to fix this cases.

_excerpt from the tests in `ReleasePluginSpec`

```
_  | 10   | "ci"  | _  | "test/build01-"            | "1.1.0-branch.test.build.1.10"
_  | 22   | "ci"  | _  | "test/build01+"            | "1.1.0-branch.test.build.1.22"
_  | 45   | "ci"  | _  | "test/build01_"            | "1.1.0-branch.test.build.1.45"
_  | 204  | "ci"  | _  | "test/build01"             | "1.1.0-branch.test.build.1.204"
_  | 100  | "ci"  | _  | "test/build.01"            | "1.1.0-branch.test.build.1.100"
_  | 55   | "ci"  | _  | "test/build002"            | "1.1.0-branch.test.build.2.55"
_  | 66   | "ci"  | _  | "test/build.002"           | "1.1.0-branch.test.build.2.66"
_  | 789  | "ci"  | _  | "test/build000000000003"   | "1.1.0-branch.test.build.3.789"
_  | 777  | "ci"  | _  | "test/build.000000000003"  | "1.1.0-branch.test.build.3.777"
_  | 789  | "ci"  | _  | "test/build000000.000003"  | "1.1.0-branch.test.build.0.3.789"
_  | 3    | "ci"  | _  | "test/build.000000.000003" | "1.1.0-branch.test.build.0.3.3"
_  | 3    | "ci"  | _  | "release/1.00.x"           | "1.0.1-branch.release.1.0.x.3"
```

Changes
=======

![FIX] Snapshot branchname strategy

6 of 6 new or added lines in 1 file covered. (100.0%)

251 of 256 relevant lines covered (98.05%)

1.96 hits per line

Relevant lines Covered
256 RELEVANT LINES 251 COVERED LINES
1.96 HITS PER LINE
Source Files on PR-50
Coverage ∆ File Lines Relevant Covered Missed Hits/Line

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
3 PR-50 Fix Snapshot branchname strategy Description =========== The `PartialSemVerStrategy` `STAGE_BRANCH_NAME` tries to generate a unique semver 2.0 prerelease pattern. The provided tests where mostly written in an optimistic fashion. This patch fixes... push jenkins pending completion  
2 PR-50 Fix Snapshot branchname strategy Description =========== The `PartialSemVerStrategy` `STAGE_BRANCH_NAME` tries to generate a unique semver 2.0 prerelease pattern. The provided tests where mostly written in an optimistic fashion. This patch fixes... push jenkins pending completion  
See All Builds (337)