wooga / atlas-github

99%

master: 39%

LAST BUILD ON BRANCH PR-24

branch: PR-24

CHANGE BRANCH

x

Reset

• PR-24
• master
• v0.1.0
• v0.2.0
• v0.3.0
• refactor/lazy_release_properties
• v0.4.0
• refactor/abstract_github_task
• v0.6.0
• PR-7
• PR-9
• PR-10
• PR-11
• PR-19
• PR-20
• PR-21
• PR-22
• PR-23
• PR-25
• PR-26
• PR-29
• release/2.x
• PR-33
• PR-32
• PR-34
• PR-35
• PR-37
• PR-36
• PR-38
• PR-39
• PR-41
• PR-45
• PR-47
• PR-48
• PR-49
• PR-51
• PR-53
• PR-54
• PR-60
• PR-59
• PR-57
• PR-50
• PR-61
• PR-64
• PR-65
• PR-66
• PR-67
• PR-68
• PR-69
• PR-70
• PR-71
• PR-72
• PR-75
• PR-76
• PR-74
• PR-79
• PR-80
• PR-81
• PR-82
• PR-83
• PR-84
• PR-86
• PR-87
• PR-89
• PR-91
• PR-94
• PR-96
• PR-97
• PR-100
• PR-101
• PR-105
• PR-110
• PR-117
• PR-116
• PR-112
• PR-113
• PR-118
• PR-120
• PR-122

Fix release asset upload with special characters in filename

Description
===========

The API `GHAsset uploadAsset(File file, String contentType)` in
`GHRelease` is does no `URLEncode` for the given file name. The filename
is used in the github API call as is:

```java
    String url = format("https://uploads.github.com%s/releases/%d/assets?name=%s",
                     owner.getApiTailUrl(""), getId(), filename);
```

This leads to upload errors when trying to publish files with special
characters. This patch circumvents this issue by calling the second API
`GHAsset uploadAsset(String filename, InputStream stream, String contentType)` with a URL encoded filename.

Note
----

Github renames release assets with special characters.

Changes
=======

![FIX] release asset upload with special characters in filename