wikimedia / svgtranslate

78%

master: 72%

LAST BUILD ON BRANCH image-preview-T207203

branch: image-preview-T207203

CHANGE BRANCH

x

Reset

• image-preview-T207203
• coveralls-2
• docker-webpack
• fallback
• fontstack
• lang-switching-T207709
• letter-spacing-T212293
• lighttpd_accesslog
• master
• partial-translations-T210872
• remaining-updates-T212270
• rsvg-rendering
• svg-warnings
• ui-fixes
• ui-fixes-T206712
• update-dependencies
• update_dependencies
• url-normalization
• zoom-and-pan

Build # 454

Build Type

push

travis-ci

Committed by samwilson

Commit Message

Add auto-preview of image as labels are changed

This adds functionality to be able to live-preview translations as
they're changed in the form. To do this, it updates the API to be
able to first receive (via POST) a new set of translations, which
are then added to the SVG file and a PNG rendered out to the
filesystem. Then, when a 2nd request (GET this time) is received
for that rendered PNG file, it's returned. This is done by creating
a temporary unique identifier for the file (based on the submitted
translations).

The front-end is modified to make this first request, and when it
receives the response all it has to do is update the image's src
attribute and the 2nd request happens.

The process of adding these strings back into SvgFile was a bit
cumbersome, so a new method SvgFile::setTranslations() was
added, which handles adding the new text and tspan node info.

Tests were updated, but the broken controller test remains for
the time being.

Bug: https://phabricator.wikimedia.org/T207203

Run Details

488 of 628 relevant lines covered (77.71%)

3.53 hits per line