wegamekinglc / Derivatives-Algorithms-Lib
81%
master: 81%

LAST BUILD BRANCH: docs/full-review-and-perf-reflect
DEFAULT BRANCH: master
Repo Added
Token RCHt5bHBHiesAZrXN9ctLtgBNi9sbYmV8 regen
Build 3548 Last
Files 221
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH chore/dedup-math-structural
branch: chore/dedup-math-structural
CHANGE BRANCH
x
Sync Branches

coverage: 80.556% (-0.1%) from 80.658%
28288380668

Pull #152

github

wegamekinglc 
Fix AAD tape Clear regression: clear adjointsMulti_ unconditionally

Copilot on PR #152 correctly flagged that the ForEachBlock refactor changed
Clear's semantics: the original native-branch Clear cleared adjointsMulti_
unconditionally, but ForEachBlock guarded it on Tape_::multi_ (a runtime flag
toggled by SetNumResultsForAAD). A tape that ran multi (populating
adjointsMulti_), then toggled to non-multi, would retain stale adjoints on
Clear instead of wiping them.

- Split ForEachBlock (guarded, for Mark/Rewind/RewindToMark) from
  ForEachBlockAll (unconditional, for Clear) so each function preserves its
  original adjointsMulti_ clearing semantics. Mark/Rewind/RewindToMark were
  already guarded in the original and stay guarded.
- Add a one-line comment at ForEachBlockAll explaining why adjointsMulti_ is
  cleared unconditionally (so the next reader/Copilot sees it is intentional).
- Add regression test TestClearEmptiesAdjointsMultiAfterMultiToNonMultiToggle
  (native-gated) that toggles multi->non-multi and asserts adjointsMulti_ is
  emptied by Clear. Verified it fails against the buggy ForEachBlock-only form
  (8 stale adjoints retained) and passes with the fix.
- Add // namespace Dal closing-brace comments to fdm1dmesher.hpp and
  concentrating1dmesher.cpp (style item, files were touched by this PR).

Native: 753/753. XAD: 752/752 (regression test compiled out).
Pull Request #152: chore: dedup math structural (AAD iterators, tape loop, Sobol seek, mesher epilogue)

24 of 26 new or added lines in 4 files covered. (92.31%)

122 existing lines in 8 files now uncovered.

6293 of 7812 relevant lines covered (80.56%)

3223299.49 hits per line

Relevant lines Covered
7812 RELEVANT LINES 6293 COVERED LINES
3223299.49 HITS PER LINE
Source Files on chore/dedup-math-structural

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
28288380668 chore/dedup-math-structural Fix AAD tape Clear regression: clear adjointsMulti_ unconditionally Copilot on PR #152 correctly flagged that the ForEachBlock refactor changed Clear's semantics: the original native-branch Clear cleared adjointsMulti_ unconditionally, but ForEac... Pull #152 wegamekinglc github
80.56
28287373833 chore/dedup-math-structural Dedup math structural: unify AAD iterators, tape block loop, Sobol seek, mesher epilogue - blocklist.hpp: collapse near-identical Iterator_ and ConstIterator_ into a single template IteratorImpl_<bool Const_> with two using aliases; removes t... Pull #152 wegamekinglc github
80.5
28287382108 chore/dedup-math-structural Merge c3f2a0f0a into 02c84df9e Pull #152 web-flow github
80.66
See All Builds (2160)

Badge your Repo: Derivatives-Algorithms-Lib

We detected this repo isn’t badged! Grab the embed code to the right, add it to your repo to show off your code coverage, and when the badge is live hit the refresh button to remove this message.
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

Refresh