weaveworks / promrus

90%

master: 90%

LAST BUILD ON BRANCH v1.2.0

branch: v1.2.0

CHANGE BRANCH

x

Reset

• v1.2.0
• issues/11-rename-counters-to-match-convention
• issues/3-newer-prom-client
• issues/5-multiple-inits
• master
• mention-coc
• mustnew
• remove-vendor
• reuse-log-metric
• v1.0.0-legacy
• v1.0.1
• v1.0.1-legacy
• v1.2.0-legacy

Build # 21

Build Type

push

travis-ci

Committed by marccarre

Commit Message

Initialise counters w/o using CounterVec#Set.

`CounterVec#Set` was present in `v0.8.0` but has been removed in `v0.9.0-pre1`.
Simply calling the counter with a label initialises it, so that is what we are now doing.
If not calling it at all, then the metric is not exposed for this label until actually incremented, which is probably not the desired behaviour -- i.e. people would most likely still want to know that the number of debug/info/warning/error log messages is zero, and to confirm that their monitoring is not broken.

Run Details

27 of 30 relevant lines covered (90.0%)

13.6 hits per line