warner / foolscap

93%

master: 89%

LAST BUILD ON BRANCH 258-allocate-port

branch: 258-allocate-port

CHANGE BRANCH

x

Reset

• 258-allocate-port
• 267-connectioninfo
• 270-tor-cep-maker
• WIP-allocate-port
• WIP-tor
• endpoints
• endpoints2
• fix-tests
• fix-travis
• foolscap-0.10.0
• foolscap-0.10.1
• foolscap-0.12.2
• foolscap-0.12.3
• foolscap-0.12.4
• foolscap-0.12.5
• foolscap-0.8.0
• latest-release
• logtest
• master
• new-twisted
• no-auto
• pr28
• remove-tcp0
• server-endpoint
• stopservice
• stopservice-tests
• tor-no-mkdir
• tox-dev

Build # 215

Build Type

push

travis-ci

Committed by warner

Commit Message

fix allocate_tcp_port()

On both OS-X and Linux, this would occasionally return a port which was
actually in use, causing a subsequent listen() to fail (with
EADDRINUSE). The issues are are platform-dependent, and explained in
detail in the new function body.

The fix requires us to actually listen() on the newly-allocated socket,
twice, and keep trying until we get a port that works. There is a
hard-coded limit of 100 tries, in case the system has so many open
connections that all the randomly-allocated port numbers fail.

Run Details

15969 of 17240 relevant lines covered (92.63%)

0.93 hits per line