volCommunity / vol-django

99%

master: 99%

LAST BUILD ON BRANCH improve-page-spead

branch: improve-page-spead

CHANGE BRANCH

x

Reset

• improve-page-spead
• add-code-of-conduct-1
• add_contributing_file
• add_country_to_org_in_api
• add_organisation_description
• allow_saving_of_jobs
• allow_spaces_update_search_suggesions_and_defaults
• bug_org_validation
• check_versions
• compose_wait_for_it
• coveralls
• debug_toolbar
• dependabot/pip/django-1.11.23
• dependabot/pip/django-1.11.28
• dependabot/pip/django-1.11.29
• dependabot/pip/djangorestframework-3.11.2
• dependabot/pip/djangorestframework-3.9.1
• dependabot/pip/jinja2-2.11.3
• dependabot/pip/urllib3-1.24.2
• fail_fast
• feature_flags
• get_version_from_config
• improve_coverage
• improve_mailchimp_signup
• increase_description_size
• increase_field_size
• increase_job_description_field_size
• irc_notifications
• job_card
• job_view
• license
• list_countries
• login
• mailchimp
• makefile
• master
• move_scripts
• organisation_nullable
• page_speed
• pagination
• plural_version_of_resources_names
• prioritise_location
• readme
• refactor_ui_for_mobile
• remove_lowering
• rest_adjustments_for_crawlers
• secret_key
• slugs
• swagger_versioning
• tidy
• travis_deploy
• uk
• update_contrib_api_section
• update_readme
• uuids_nested_job
• uuids_only
• v0.0.2
• v0.0.3
• v0.0.4
• web_view_tests

Build # 196

Build Type

push

travis-ci

Committed by damienklinnert

Commit Message

This pull request should greatly boost page speed (without breaking the site).

Assuming that all JS files are currently only required to make the typeahead inputs
on the index page work, we can make the following optimisation, which moves loading
and parsing out of the entire path to the first DOMContentLoaded event.

We simply require a single async JS file, which moves the file out of the critical
path. The file will then load the remaining scripts, making sure they are loaded
and parsed in order.

Be aware that on slow networks the user might run into cases where the input boxes
are not yet enhanced with TypeScript and won't show autocomplete. I guess this falls
under progressive enhancement.

Admittedly, the current solution is a bit primitive, but it will do for now. When
the page dependencies get more complex, you might want to introduce a proper
dependency loader instead.

Closes #54

Run Details

675 of 680 relevant lines covered (99.26%)

2.98 hits per line