vocdoni / saas-backend

62%

main: 62%

LAST BUILD ON BRANCH fix/processes-orgaddress-hexbytes

branch: fix/processes-orgaddress-hexbytes

CHANGE BRANCH

x

Reset

• fix/processes-orgaddress-hexbytes
• 219-fix-duplicate-members-warning-for-census-creation
• add-mocksms
• adding-census-participant-after-census-created
• api-test-refactor
• argos/issue-440-argos-test-add-changelog-md-skeleton-at
• argos/issue-445-argos-test-refactor-duplicate-error-wrap
• argos/issue-446-argos-test-add-unit-test-for-utils-packa
• argos/issue-450-argos-test-bump-zerolog-to-latest-patch
• argos/issue-453-argos-test-add-integration-style-test-fo
• argos/issue-456-argos-test-log-organization-id-in-succes
• argos/issue-458-argos-test-pagination-cursor-not-url-enc
• argos/issue-461-argos-test-add-brief-quickstart-section
• argos/issue-462-argos-test-add-get-api-info-endpoint-ret
• argos/issue-464-argos-test-add-smtp-timeout-seconds-env
• argos/issue-470-argos-test-add-w-error-wrapping-in-db-se
• argos/issue-471-argos-test-add-test-for-utils-randomhex
• argos/issue-475-argos-test-add-make-lint-strict-target-t
• argos/issue-476-argos-test-add-request-id-middleware-tha
• argos/issue-477-argos-test-guard-against-nil-deref-in-ap
• argos/issue-480-argos-test-enforce-minimum-password-leng
• argos/issue-481-argos-test-add-regression-test-for-verif
• argos/issue-487-argos-test-add-benchmark-for-utils-hashp
• argos/issue-489-argos-test-add-contributing-md-with-pr-c
• argos/issue-492-allow-removing-organizations-from-the-da
• b/docker-minor-issues
• b/fix-mail-from
• b/fixes-v2.3
• b/lint-fixes
• b/public-addresses
• b/secret-keys
• b/swagger
• b/user-weight-get-handler
• b/voter-no-login-weight-0
• bi
• bug/add-auth-2fa-json-unmarshalling
• bug/fix-resend-verification-code
• c/docker-compose-watch
• c/minor-changes
• c/promo-codes
• cascade-member-update-to-censuses
• chore/api-cleanup
• chore/deprecate-legacy-process
• chore/disable-claude-coauthor
• chore/remove-csp-expiry-warning
• ci-lint-commits
• cli
• debug-mongodb-death-race
• docs/chain-abstraction-plan-phase6
• docs/clarify-group-census-publish-auth
• docs/swagger-census-vote-csp-fixes
• docs/swagger-integrator-endpoints
• docs/swagger-journey-endpoints
• drop-dead-code
• enforce-unique-login-hashes
• f/101_org_participants_groups
• f/106_handle_org_member
• f/110_organization_meta
• f/117_expose_memberid
• f/126_resend_member_inivation
• f/137-improve-members-crud
• f/144-census-creation
• f/146-email-clear-text
• f/148-bis-rename-cenus-membership
• f/148-memberID-not-unique
• f/149-update-members-columns
• f/150-members-filtering
• f/227-2fa-warnings
• f/244_national-id-validation
• f/276-remove-deleted-members-from-groups
• f/279-montly-subscriptions
• f/370-endpoint-voter-weight
• f/372-improve-csp-verification-msg
• f/415-enforce-memberbase-add-limit
• f/421-set-default-memberbase-order
• f/424-add-census-particiapants
• f/426-http-client-census
• f/427-resend-csp-notifications
• f/495-find-election-participants
• f/add-census-size
• f/apikeys-integrator-only
• f/autogroups-434
• f/better-telephone-parsing
• f/birthdate
• f/bulk-members-ops
• f/bulk_org_members_validation_errors
• f/cascade-delete
• f/census-check
• f/ci-fix-golangci-lint
• f/circuits_assets_included_in_docker_image
• f/cmd-client-allow-email-only-census
• f/complete-census-creation-flow
• f/complete-census-creation-flow-followup
• f/complete_dev_local_deploy
• f/csp-refactor
• f/csp-refactor-fixes
• f/csp-remove-membernumber
• f/custom-plan-field
• f/delete-managed-organization
• f/do-not-limit-processes-small-census
• f/drat-delete
• f/drop-unused-sendsms
• f/empty-census-hotfixes
• f/fix-2fa-mail-or-phone-login
• f/fix-oauth-password-reset
• f/fix-roles
• f/fix-verification-template
• f/fix_census_creation_flow
• f/ghcr_action_fix
• f/granular-write-access
• f/hotfix-census-participant
• f/lang-param
• f/leave-empty-groups
• f/list-org-member-group-pagination-bug
• f/mongodb-migrations
• f/move-stripe-webhook
• f/multiple-oauth-providers-286
• f/new_org_bundles_endpoint
• f/oauth-specific-error-286
• f/pending-user-invitation-fixes
• f/persistent-errors
• f/qt-haslen
• f/real_census_size
• f/remove-price-tiers
• f/rename-all
• f/rename-org-members
• f/rename-org-participants
• f/review-more-hex
• f/send-email-when-import-finished
• f/sets_constant_max_vote_overwrite
• f/small-lint
• f/stripe-custom-checkout
• f/stripe-declutter
• f/stripe-rewrite
• f/stripe-upgrade-v82
• f/unify-pagination
• f/update-process-flow
• feat/100_org_participants_api
• feat/105_support_email
• feat/111_stripe_phoneSupport
• feat/285-add-org-member-weight
• feat/347-add-weight-to-census-csp
• feat/358-csp-sign-return-weight
• feat/asserts-always-commentf
• feat/cc-support-email-to-user
• feat/chain-abstraction-backend
• feat/cline-rules
• feat/coverage
• feat/csp-blind-signatures
• feat/csp-blind-signing-only
• feat/csp-use-db-package
• feat/draft-process
• feat/drop-unused-code
• feat/embedded-meta
• feat/enforce-draft-limits
• feat/expose-chainid
• feat/expose-integrator-flag
• feat/expose-managed-by
• feat/extend-members-job-to-report-errors
• feat/fable-review
• feat/free-integrator-tier
• feat/integrator-api-keys
• feat/integrator-apikey-self-context
• feat/integrator-plan-enablement
• feat/integrator-plan-stripe-sync
• feat/integrator-usage-counters
• feat/managed-org-integrator-limits
• feat/more-db-refactors
• feat/noop-refactors
• feat/processes-api
• feat/question-status-sync
• feat/refactor-CheckGroupMembersFields
• feat/resend-mail-provider
• feat/vote-memo
• fix-395
• fix/527-oauth-signature-verification
• fix/527-password-reset-bypass
• fix/add-invalid-login-error
• fix/add-members-errors
• fix/api-camelcase
• fix/api-error-codes
• fix/apikey-allowlist-route-mismatches
• fix/apikey-delete-process-draft
• fix/backfill-process-start-date
• fix/bundle-accept-processid
• fix/check-matched-count
• fix/ci-api-retries
• fix/ci-go-version
• fix/ci-testCreateUser
• fix/csp-lastcspauth-race
• fix/csp-random-otp-secret
• fix/errors-on-async-job
• fix/flaky-email-test
• fix/high-severity-auth-vulns
• fix/integrator-flag
• fix/last-admin-orphan
• fix/leftover-renames
• fix/make-swagger
• fix/managed-org-persist-meta
• fix/managed-process-quota-on-transactions
• fix/memberbase-partial-match
• fix/normalize-member-emails-lowercase
• fix/orgaddress-is-now-a-common-address
• fix/process-metadata-resolution
• fix/process-objectid-ids
• fix/race-condition-org-users-counter
• fix/relay-vote-endpoint
• fix/relayvote-email-flake
• fix/remove-email-on-member-edit
• fix/remove-redundant-birdhdate-parsing
• fix/sanitize-hex-addresses
• fix/test-max-users-reached
• fix/trim-member-whitespace
• fix/verifation_flow
• handle-annual-limits
• hotfix-0005_rename_verifications_code
• hotfix-TestDecryptTokenFromHexErrors
• hotfix-add-members-job
• hotfix-migration-verifications-code
• hotfix-weight-pointer
• hotfix/2fa-field-phone
• hotfix/bson-omitempty
• hotfix/missing-return
• hotfix/orgMembersByIDs
• hotfix/orgmembers
• hotfix/phone-normalization-bug
• hotfix/wrong-error-voter-login
• i/extend_errors
• improve-lint
• limit-process-creation
• main
• multiple_email_providers
• r/upgrade-testcontainers
• refactor-csp-and-smtp
• refactor/stripe-plans-single-source
• remove-org-name-from-email
• revert-hotfix
• sentEmails-counter
• small-cleanup
• small-fixes-in-census-handlers
• stage
• templates
• test-helper-funcs
• worktree-bubbly-popping-volcano
• worktree-fix-swagger-phantom-response-fields
• worktree-notify-queue-reunite
• wt/new-task

Build # 29494374805

Build Type

Pull #579

github

Committed by lucasmenendez

Commit Message

chore(processes): address review feedback

- reject the all-zero org address with 400 (the length-only check let it
  through to the role check, returning 401 and changing prior behavior).
- use a full 20-byte (40-hex) orgAddress swagger example instead of the
  4-byte "deadbeef" on the request and response types.
- add TestVotingProcessOrgAddressWireFormat: inspects the raw HTTP body and
  asserts orgAddress serializes as bare lowercase hex (no 0x / no checksum),
  which struct-parsing tests can't catch.

Pull Request Pull Request #579: fix(processes): serialize org address as internal.HexBytes (bare hex)

Coverage Stats

8 of 9 new or added lines in 2 files covered. (88.89%)

11494 of 18489 relevant lines covered (62.17%)

44.91 hits per line