vinyl-linux / mint

94%

main: 94%

LAST BUILD ON BRANCH nil_empty_collections

branch: nil_empty_collections

CHANGE BRANCH

x

Reset

• nil_empty_collections
• benchmarking
• code_generation
• complex_marshall_support
• default-build-perms
• documentation
• enums
• main
• refs/heads/main
• refs/heads/move_binary_out
• refs/tags/0.1.0
• refs/tags/v0.2.0
• refs/tags/v0.3.0
• refs/tags/v0.4.0
• refs/tags/v0.4.1
• refs/tags/v0.4.2
• refs/tags/v0.4.3
• run_ci_on_pr
• to_from_binary
• uint16_type
• updateses
• uuid_type

Build # 5276861276

Build Type

push

github

Committed by jspc

Commit Message

Set empty collections to nil value

Given a type:

```golang
type Foo struct {
     Bar []string
}
```

When `Foo.Bar` is uninitialised/ `nil`, we Marshall with a Len of
0. When we then Unmarshall we initialise a `[]string` of length 0.

The problem here is that a `nil` slice and a slice of `len()` 0 are two
different things. Thus, when we try:

```golang
in := new(Foo)
in.Marshall(buf)

out := new(Foo)
out.Unmarshall(buf)
```

our types don't match up.

By testing whether `f.Len() == 0` and setting `Foo.Bar` as the nil
value, rather than anything else, we know our collection should be nil.

Of course, this wont work if the collection _should_ be of length 0.

Run Details

1073 of 1145 relevant lines covered (93.71%)

3138.07 hits per line