vikingco / wingmonkey

93%

master: 93%

LAST BUILD ON BRANCH INT-5394/only-use-required-params-for-mergefields-patch

branch: INT-5394/only-use-required-params-for-mergefields-patch

CHANGE BRANCH

x

Reset

• INT-5394/only-use-required-params-for-mergefields-patch
• 0.1.0
• 0.1.10
• 0.1.11
• 0.1.12
• 0.1.13
• 0.1.14
• 0.1.15
• 0.1.16
• 0.1.17
• 0.1.18
• 0.1.19
• 0.1.20
• 0.1.21
• 0.1.4
• 0.1.5
• 0.1.6
• 0.1.7
• 0.1.8
• 0.1.9
• 0.2.0
• 0.2.1
• 0.2.2
• BatchOperationResourceCollectionSerializer-read-in-chunks
• Handle-exception-in-MailChimpSession-close
• INT-1923/upgrade-to-python-3.7
• INT-2074/catch-asyncio-timeouts
• INT-4962/update-requests-requirmenent-to-recommended-secure-version
• MA-1213/handle-None-value-in-unsubscribe-reason
• MA-985/get-member-activity
• MA-993/group-id-for-async-member-updates
• MA-997/add-timeout-to-aiohttp-requests
• MVGR-856/brand-agnostic-refactor
• TEST-extra-logging-for-troubleshooting
• async_delete
• async_member_update_performance_tweaks
• bump-version
• close-async-session-properly
• fix-admin-unsubscribes
• fix-setup
• get_all_members_async-refactor
• improve-exception-handling-MailchimpSession
• increase-coverage
• master
• pip10-refactoring
• self-aware-nested-serializers
• send_immutable_data_to_callback
• serializers-refactor
• set-correct-_links-field-type-for-MergeFieldSerializer-and-MergeFieldCollectionSerializer

Build # 180

Build Type

push

travis-ci

Committed by JonasSteur

Commit Message

Only send required fields when doing mergefield create or patch

By setting the `only` attribute on a marshmallow schema we can limit the
fields that get sent by a request. Before the python 3.7 upgrade it wasn't needed
to set this explicitly as empty fields would not be sent. Now empty
fields will be send with a NULL value which causes
errors.(https://sentry.unleashed.be/unleashed/budskap/issues/283282/?query=is:unresolved)
The only required field by mailchimp for mergefield is the name: https://developer.mailchimp.com/documentation/mailchimp/reference/lists/merge-fields/#%20
Budskap will always send a name, type and tag.

Run Details

183 of 251 branches covered (72.91%)

Branch coverage included in aggregate %.

1706 of 1778 relevant lines covered (95.95%)

1.92 hits per line