• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

veeso / suppaftp
73%
main: 73%

Build:
Build:
LAST BUILD BRANCH: fix-re-export-tls-streams
DEFAULT BRANCH: main
Repo Added 20 Aug 2021 02:15PM UTC
Files 26
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH fix-retr-cannot-be-used-with-async
branch: fix-retr-cannot-be-used-with-async
CHANGE BRANCH
x
Reset
  • fix-retr-cannot-be-used-with-async
  • 112-tokio-ftp-stream
  • 115-generic-custom-command-support-for-data-streams
  • 121-tls-stream-should-be-public
  • 19-feature-request-allow-using-rustls-instead-of-native-tls
  • 24-cant-work-with-some-sepecial-ftp-response
  • 33-bug-features-are-not-additive
  • 37-feature-request-set-a-timeout-on-ftp-connect
  • 4.1.3
  • 4.2.0
  • 4.3.0
  • 4.5.0
  • 64-feature-request-timeouts-for-active-data-connection-acceptance
  • 89-passive-mode-with-custom-provided-tcpstream
  • abor-command
  • add-executable-rustls-example
  • appe-command
  • clear-channel-command
  • close-ssl-stream
  • commands-as-enum
  • develop
  • feature/sync-get-ref-tls
  • fix-async-native-tls-with-tokio
  • fix-chrono-version
  • fix-feat-parser
  • fix-re-export-tls-streams
  • imgbot
  • implicit-ftps
  • list-fails-on-non-utf8-encoded-filenames
  • main
  • migrate-to-futures-rustls
  • pasv-nat
  • patch-1
  • refs/tags/v4.1.1
  • refs/tags/v4.1.2
  • refs/tags/v4.2.0
  • refs/tags/v4.3.0
  • refs/tags/v4.4.0
  • refs/tags/v4.5.0
  • refs/tags/v4.5.2
  • refs/tags/v4.6.0
  • refs/tags/v4.6.1
  • refs/tags/v4.7.0
  • refs/tags/v5.0.0
  • refs/tags/v5.0.1
  • refs/tags/v5.1.0
  • refs/tags/v5.1.1
  • refs/tags/v5.1.2
  • refs/tags/v5.2.1
  • refs/tags/v5.2.2
  • refs/tags/v5.3.0
  • refs/tags/v5.3.1
  • refs/tags/v5.4.0
  • refs/tags/v6.0.0
  • refs/tags/v6.0.1
  • refs/tags/v6.0.2
  • refs/tags/v6.0.3
  • refs/tags/v6.0.4
  • rest-command
  • v6.1.0
  • v6.1.1
  • v6.2.0
  • v6.2.1
  • v6.3.0
  • v7.0.0
  • v7.0.4
  • v7.0.5
  • v7.0.6

05 Jun 2025 08:13AM UTC coverage: 72.503% (+0.4%) from 72.134%
15461980225

Pull #110

github

veeso
fix(async): Fixed `retr` method signature on the `AsyncFtpStream` to allow passing a closure taking the stream reader.

The signature of the `retr` method was not allowing any argument, because the dyn Read needs to be Unpin, but it's a mutable reference at the same time and this with Async causes several issues. The mutable reference is required by the finalize_retr_stream which is called immediately after calling the closure. Because of this, the signature has been changed to return both the result and the stream back to be able to finalize it.

closes #88
Pull Request #110: fix(async): Fixed `retr` method signature on the `AsyncFtpStream` to allow passing a closure taking the stream reader.

12 of 12 new or added lines in 1 file covered. (100.0%)

2650 of 3655 relevant lines covered (72.5%)

13.17 hits per line

Relevant lines Covered
Build:
Build:
3655 RELEVANT LINES 2650 COVERED LINES
13.17 HITS PER LINE
Source Files on fix-retr-cannot-be-used-with-async
  • Tree
  • List 20
  • Changed 2
  • Source Changed 2
  • Coverage Changed 1
Coverage ∆ File Lines Relevant Covered Missed Hits/Line

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
15461980225 fix-retr-cannot-be-used-with-async fix(async): Fixed `retr` method signature on the `AsyncFtpStream` to allow passing a closure taking the stream reader. The signature of the `retr` method was not allowing any argument, because the dyn Read needs to be Unpin, but it's a mutable re... Pull #110 05 Jun 2025 08:15AM UTC veeso github
72.5
See All Builds (301)
  • Repo on GitHub
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc