vaadin / vaadin-date-picker

90%

master: 92%

LAST BUILD ON BRANCH fix-enter-error-before-overlay-initalized

branch: fix-enter-error-before-overlay-initalized

CHANGE BRANCH

x

Reset

• fix-enter-error-before-overlay-initalized
• 3.3
• 4.0
• 4.1
• 4.2
• 4.3
• 4.4
• @vaadin/vaadin-component-dev-dependencies
• add-auto-open-disabled-demo
• add-rtl-support
• cherry-pick-4-1
• cherry-pick-722-to-4.0
• cherry-pick-722-to-4.1
• chore/perf-cleanup
• cp/pr-716
• date-range-example
• disable-upgrade-fix
• dx/#148
• feat/clear-button-visible
• feature/auto-open-disabled
• feature/material-visual-test
• feature/propagate-theme
• fix-721-input-value-on-value-changed-event
• fix-defining-vaadin-date-picker-current-year
• fix-input-value-on-value-changed-event
• fix-ios9-layout
• fix-iso-formatting
• fix-month-last-date
• fix-rtl-overlay-flip
• fix-theme-propagation
• fix-typo-in-theme-module-id
• fix/#564-remove-redundant-font-icon
• fix/681-clear-mobile
• fix/calendar-a11y
• fix/disabled-material
• fix/ie11-today
• fix/invalid-input-handling#643
• fix/required-invalid
• fix/rtl
• fix/rtl-issues
• fix/simplify-demos
• fix/validate-before-change
• fix/validate-on-blur
• fix/visual-tests
• fixIndexPageForImproveDatePickerDemo
• gemini-changes
• helper-text
• improveDatePickerDemos
• improveVaadinDatePickerSecond
• master
• optimize-validation
• overlay-content-getter
• p3-preview
• pekam-patch-1
• postpone-overlay-render
• refactor/apply-tertiary-theme
• remove-android-visual
• revert-focused-date
• saucelabs-visual-chrome-firefox-only
• update-deps-stable-4.1
• update-deps-stable-master
• update-to-xenial
• v3.2.0-alpha4
• v3.2.0-beta2
• v3.3.0-alpha1
• v3.3.1
• v3.3.2
• v4.0.1
• v4.0.4
• v4.0.5
• v4.0.6
• v4.0.8
• v4.1.0
• v4.1.0-alpha1
• v4.1.0-alpha2
• v4.1.1
• v4.2.0
• v4.3.0
• v4.3.0-alpha1
• v4.3.0-alpha3
• v4.3.0-beta1
• v4.4.0

Build # 3243

Build Type

Pull #657

travis-ci

Committed by web-flow

Commit Message

fix: prevent overlay opening on empty input event

The overlay should not be opened when clicking the clear-button. This
functionality broke with a failing test case after text-field 2.4
update, which fires an input-event on clear-button click.

Since we don't know if the input-event was fired from a clear-button
click or keyboard-input, the opening is prevented every time when the
input value is empty. As a tradeoff, this causes a rare issue: When the
input is focused, overlay is not opened and the input is cleared with a
single keypress, the overlay is not opened.

Pull Request Pull Request #657: Fix enter error before overlay initalized and overlay opening on clear-button click

Run Details

471 of 542 branches covered (86.9%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

755 of 820 relevant lines covered (92.07%)

10373.5 hits per line