vaadin / vaadin-combo-box

92%

master: 93%

LAST BUILD ON BRANCH duplicate-custom-value-set

branch: duplicate-custom-value-set

CHANGE BRANCH

x

Reset

• duplicate-custom-value-set
• 229-load-indicator
• 386-improve-undefined-size-scrolling
• 5.0
• 5.1
• 5.2
• 5.3
• 5.4
• 957-empty-items
• @vaadin/vaadin-component-dev-dependencies
• ImproveComboBoxDemos
• attr-jsdoc
• bug-783
• bump-text-field
• chore/perf-cleanup
• clear-button-lazy-loading
• clear-button-visible
• clear-value-in-listener
• cp/combo-box-item-type
• data-provider-docs
• data-provider-pool
• data-provider-scroll
• dont-request-empty-loaded-page-again
• dx/#148
• dynamic-size-change-tests
• feat/add-helper-slot
• feature/auto-open-disabled
• feature/lazy-loading
• feature/material-visual-test
• feature/propagate-theme
• feature/renderer
• filter-items-auto-open
• fix-973
• fix-clear-pending-requests
• fix-combo-box-allow-value
• fix-custom-value
• fix-custom-value-bug
• fix-custom-value-event
• fix-custom-value-issue
• fix-demo-renderers
• fix-fast-scroll
• fix-only-3-items-rendered-first
• fix-scroll-test
• fix-visual-tests
• fix/#652-root-level-item-template
• fix/#717-itemLabelPath-undefined-error
• fix/529-overlay-width
• fix/622
• fix/694-perf
• fix/758
• fix/778
• fix/780
• fix/787
• fix/792
• fix/815
• fix/900_Valid_item_is_not_selected_if_ComboBox_has_a_dataprovider_and_autoopendisabled
• fix/big-size-crash
• fix/clearcache-error
• fix/close-on-empty-data
• fix/comboboxitem-type
• fix/custom-value-focus
• fix/filtered-items
• fix/flow-components/915/Server_side_filtering_seems_to_be_case_sensitive
• fix/handle-null-value-label-properties
• fix/heightOverlayScroller
• fix/invalid-value-multiple-times
• fix/loading
• fix/loading-selected-items
• fix/opened-when-no-items
• fix/placeholder-reuse
• fix/readonly-a11y
• fix/redundant-icon-font
• fix/remove-polymer-from-readme-code
• fix/reorganize-demos
• fix/scroll-performance
• fix/simple-first-demo
• fix/visual-tests
• force-next-request-after-clearCache
• gemini-changes
• gen-ts-defs
• improveVaadinComboBoxDemos
• manual-render
• master
• md-preview
• move-ipad-to-cronplatforms
• p3-preview
• pekam-patch-1
• position-target-update
• postpone-overlay-render-with-dom-if
• prepare-wc-deps-14.3
• preserve-propagate-dir
• preserve-rtl
• refactor-selector
• refactor/disable-upgrade
• renderer-preview
• reset-size-on-clearCache
• revert-752
• rtl-support
• stop-enter
• test-rtl
• update-filteredItems-when-size-changes
• update-modulizer
• update-screenshot
• update-to-xenial
• v4.1.0-alpha1
• v4.1.0-beta1
• v4.1.0-beta2
• v4.2.0-alpha1
• v4.2.0-alpha3
• v4.2.0-alpha4
• v4.2.0-alpha5
• v4.2.0-alpha7
• v4.2.0-beta2
• v4.2.1
• v4.2.2
• v4.2.3
• v4.2.5
• v4.2.6
• v4.2.8
• v5.0.0-alpha1
• v5.0.10
• v5.0.11
• v5.0.2
• v5.0.3
• v5.0.4
• v5.0.5
• v5.0.6
• v5.0.7
• v5.0.8
• v5.0.9
• v5.1.0
• v5.1.0-alpha1
• v5.2.0
• v5.2.0-alpha1
• v5.2.0-alpha2
• v5.3.0
• v5.3.0-alpha1
• v5.3.0-alpha2
• v5.3.0-alpha3
• v5.3.0-alpha4
• v5.3.0-alpha5
• v5.3.0-beta1
• v5.4.0
• v5.4.0-alpha1
• v5.4.1
• v5.4.2
• v5.4.3
• v5.4.4
• v5.4.5
• v5.4.6
• v5.4.7

Build # 4038

Build Type

Pull #799

travis-ci

Committed by web-flow

Commit Message

Fix duplicate custom-value-set events fired

The _onClosed function was running twice when the overlay was closed:
- once by reacting to the dropdown closing event
- another time by the opened property observer

Because of this, the custom-value-set event was fired twice.

This was not caught by the tests, because the test combo box didn't
have any items, so there was no overlay, which would be closed to make
the extra _onClosed call.

Fix https://github.com/vaadin/vaadin-combo-box-flow/issues/167

Pull Request Pull Request #799: Fix duplicate custom-value-set events fired

Run Details

459 of 523 branches covered (87.76%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

636 of 668 relevant lines covered (95.21%)

10378.55 hits per line