ushahidi / platform

21%

master: 20%

LAST BUILD ON BRANCH refactor/update-create-usecase-to-allow-entity-default-values

branch: refactor/update-create-usecase-to-allow-entity-default-values

CHANGE BRANCH

x

Reset

• refactor/update-create-usecase-to-allow-entity-default-values
• 0000-config-update
• 1000-image-upload
• 1005-csv-export
• 1006-single-file-install
• 1151-image-size-error
• 1174-survey-colours
• 1209-saved-search-not-triggering-notification
• 1236-unique-survey-titles
• 1281-change-post-statuses
• 1283-survey-update
• 1284-post-validation
• 1305-frontline-update
• 1348-validate-lat-and-lon
• 1362-editable-post-dates
• 1366-add-collection-creation
• 1366-csv-improvements
• 1366-fix-status
• 1376-export-column-labels
• 1392-unmapped-posts
• 1397-labels-edit-ui
• 1397-new-labels
• 1434
• 1452-video-embed
• 1462-collection-archived
• 1469-change-default-fields
• 1486-savedsearches
• 1509-imap-email
• 1511-field-level-locking
• 1550-comrades-yodie-integration
• 1584-twitter-hashtags
• 1595-intercom
• 166-hash-password
• 1677-caption-field-optional
• 1886-lock-bug
• 2028
• 2447-data-export-job-api
• 2491-manage-collections
• 2710-webhooks-enable-usage-with-no-form-specified
• 3198-add-freeze-state-and-end-state
• 3264-fix-user-search
• 3305-fix-heroku-deployment
• 3385-get-in-touch
• 3506-composer-deps-update
• 3836-fix-ohanzee-runtime
• 3922-two-locations-regression
• 4073-cache-control-middle
• 443-message-threads
• 501-rate-limiting
• AllContributors-skipCi-imagesize
• Updating-readme
• actions/ship-docker-image
• all-contributors-readmeupdate
• all-contributors/add-Akshansh99
• all-contributors/add-Angamanga
• all-contributors/add-Erioldoesdesign
• all-contributors/add-MigDinny
• all-contributors/add-UdokaVrede
• all-contributors/add-anje123
• all-contributors/add-brianherbert
• all-contributors/add-brylie
• all-contributors/add-cvele
• all-contributors/add-dariatsvetkova
• all-contributors/add-gausam
• all-contributors/add-individual-it
• all-contributors/add-jasonmule
• all-contributors/add-jcbashdown
• all-contributors/add-muchirijane
• all-contributors/add-niksseif
• all-contributors/add-rjmackay
• all-contributors/add-rowasc
• all-contributors/add-spaudanjo
• all-contributors/add-tobiasziegler
• all-contributors/add-tuxpiper
• all-contributors/add-webong
• all-contributors/add-willdoran
• all-contributors/add-ymohii
• ansible-deploy-fix-control-path
• api-blueprint
• arch-docs
• branch
• build-codeclimate-coverage
• cache-user-for-session
• cleanup-logging
• cleanup-pre-export-job-queues
• codeship-tests
• config-dotenv-path
• contact-hydration
• csv-array-import
• cycle-3-sms-add-order-by
• delete-users-shouldnt-delete-posts
• develop
• develop-from-master-20200309
• develop-test
• docker-fixes-20190822
• docker/show-lumen-logs
• draft-all-contributors-page
• duplicate-locations
• eng-105-docker
• feat-add-translations-to-minimal
• feat-geolocation-locale
• feat/gmail-datasource
• feature/2fa
• feature/actually-multisite-job-queues
• feature/add-protected-status-to-roles
• feature/add-review-workflow-toggle-1282
• feature/cache-repos
• feature/csv-configure
• feature/migration
• feature/multisite-job-queues
• feature/post-date-filter
• feature/post-published-filter
• feature/refactor-multisite-dataproviders
• feature/twitter-geolocation
• fix-demo-expiration
• fix-demo-posts
• fix-demo-posts-prep
• fix-edit-own-post
• fix-master-no-export
• fix-recursive-diff-comparison
• fix-select-query-how-did-this-ever-work
• fix-setup-alternatives-dir
• fix-travis-coverage
• fix/lint-20200602
• fix/media-urls-in-csv
• fixFormIdContentTitleValidation
• geojson-optimization
• geolocation-service
• github-actions-test
• heroku-cronjob
• hotfix/1091-settings-redirect
• hotfix/1271-attribute-validation
• hotfix/1400-update-tags
• hotfix/avoid-duplicate-combine-jobs
• hotfix/dont-try-to-combine-failed-batches
• hotfix/handle-hdx-not-configured
• hotfix/mobile-invalid-scopes
• hotfix/savedsearch-status-filter
• initial-cli-migration-command
• installer-helper
• isdbready
• isdbreadyprod
• language-switcher-1651
• livity-reintegration
• lumen
• lumen-reintroduce-inbound-fields
• lumen-update-v5
• master
• media-formatter-cache
• merge-prod-to-master
• messingwithkube
• migrating-to-yaml-syntax
• migration-tool
• migration-tool-dev-update
• migration/add-import-and-mapping-models
• migration/allow-long-titles
• migration/batch-insert-post-values
• migration/import-custom-form-fields
• migration/import-custom-forms
• migration/import-incident-media-links
• migration/import-incidents
• migration/import-messages
• migration/import-tags
• migration/import-users
• mustang/filter-system
• optimize-posts-messages-join
• pr-4065
• pr3991/fix-validation-issue-on-post-create-and-update
• prep-lumen-update-packages
• prep-release-user-search
• production
• production-aws
• psr-ushahidi-classes
• rc-v4.4.2
• refactor-features-limits
• refactor-listeners
• refactor/csv-import-in-job
• refactor/fix-migration-so-it-can-be-reverted
• refactor/legacy-validator
• register-validation-fixes
• release/v330
• remove-console-importer
• remove-location-for-twitter
• remove-old-redis-code
• remove-unneeded-extensions
• revert-1234-livity-reintegration
• revert-3880-test-gwcheck
• revert-3925-twitter-urls-fix
• revert-3991-fix-validation-issue-on-post-create-and-update
• rjmackay-document-queues
• roles
• rowasc-contributing.md
• rowasc-hdx-enable
• rowasc-hdx-off
• schedule-commands
• security-md
• staging
• support-php-7.2-7.3
• support-php-72
• test-action
• tests-on-gh-actions
• transifex-release
• twitter-refactor-data
• twitter-urls-fix
• uchaguzi-2017
• update-default-saved-searches
• update-locales-20200309
• upgrade-aura-di
• use-mysql-strict
• v3.4.0
• v3.4.1
• v3.4.2
• v3.4.3
• v3.4.4
• v3.4.5
• v3.4.6
• v3.4.7
• v3.5.0
• v3.5.1
• v3.6.0
• v3.6.1
• v3.6.2
• v3.6.3
• v3.7.1
• v4.0.0
• v4.4.0
• v4.4.1
• v4.5.0
• v4.6.0
• v4.6.1
• v4.6.2
• v4.6.3
• v4laravel
• v4laravel-posts
• v5
• v5.0.0-rc.1
• v5.0.0-rc.2
• v5.0.0-rc.3
• v5.0.0-rc.4
• v5.0.0-rc5
• v5.0.0-rc8

Build # 7762

Build Type

Pull #3450

travis-ci

Committed by web-flow

Commit Message

refactor: Update CreateUsecase to allow default values on entities

Previously we created a blank entity and set state on it, this meant
that any values that had a default value *and* were marked as immutable
could not be set ie. `Post->type`. Instead CreateUsecase now creates
the entity with the full payload data, so the default are only applied
where the values doesn't appear in the payload, and the immutable
check works correctly because the value isn't yet set.

Pull Request Pull Request #3450: refactor: Update CreateUsecase to allow default values on entities

Run Details

3 of 3 new or added lines in 3 files covered. (100.0%)

1865 of 9086 relevant lines covered (20.53%)

3.08 hits per line