umputun / stash

84%

master: 84%

LAST BUILD ON BRANCH fix/server-code-review-improvements

branch: fix/server-code-review-improvements

CHANGE BRANCH

x

Reset

• fix/server-code-review-improvements
• api-list-keys
• conflict-detection
• dependabot/github_actions/actions/setup-go-6
• feat-public-access
• feat/git-ssh-key
• feat/key-history
• feat/rate-limiting
• feat/selective-session-invalidation
• feat/sighup-auth-reload
• feat/syntax-highlighting
• feat/value-validation
• feature/auth-hot-reload
• feature/cache-layer
• feature/enum-types
• feature/git-versioning
• feature/granular-auth
• feature/web-pagination
• fix/git-concurrency-and-error-handling
• json-schema-validation
• master
• persistent-sessions
• refactor/split-server-subpackages
• refs/tags/v0.1.0
• refs/tags/v0.1.1
• refs/tags/v0.10.0
• refs/tags/v0.10.1
• refs/tags/v0.10.2
• refs/tags/v0.10.3
• refs/tags/v0.10.4
• refs/tags/v0.11.0
• refs/tags/v0.12.0
• refs/tags/v0.12.1
• refs/tags/v0.13.0
• refs/tags/v0.13.1
• refs/tags/v0.13.2
• refs/tags/v0.2.0
• refs/tags/v0.2.1
• refs/tags/v0.2.2
• refs/tags/v0.3.0
• refs/tags/v0.3.1
• refs/tags/v0.4.0
• refs/tags/v0.5.0
• refs/tags/v0.6.0
• refs/tags/v0.7.0
• refs/tags/v0.7.1
• refs/tags/v0.7.2
• refs/tags/v0.7.3
• refs/tags/v0.8.0
• refs/tags/v0.8.1
• refs/tags/v0.8.2
• refs/tags/v0.9.0
• refs/tags/v0.9.1
• refs/tags/v0.9.2

Build # 19998833863

Build Type

Pull #29

github

Committed by umputun

Commit Message

fix(server): address code review issues in web and auth handlers

- fix missing template fields in handleKeyCreate/handleKeyUpdate permission denied paths
- add context cancellation check in auth hot-reload debounce callback
- add error logging to InvalidateSession
- extract session cookie names to internal/cookie package
- add cookie name constants (NameSecure, NameFallback) for consistency
- add tests for permission denied, invalid base64, and validation error scenarios

Pull Request Pull Request #29: fix(server): address code review issues in web and auth handlers

Run Details

43 of 47 new or added lines in 5 files covered. (91.49%)

2 existing lines in 1 file now uncovered.

2635 of 3149 relevant lines covered (83.68%)

83.87 hits per line