umputun / secrets

88%

master: 83%

LAST BUILD ON BRANCH fix-content-type-header

branch: fix-content-type-header

CHANGE BRANCH

x

Reset

Sync Branches

• fix-content-type-header
• audit-logging-improvements
• auth-for-link-generation
• bump-ver
• bump_modules
• dependabot
• dependabot/github_actions/github-actions-updates-167a898cab
• dependabot/github_actions/github-actions-updates-2d3733e69a
• dependabot/github_actions/github-actions-updates-822744b99e
• dependabot/github_actions/github-actions-updates-c0bc7ccf5f
• dependabot/go_modules/github.com/go-pkgz/routegroup-1.6.0
• dependabot/go_modules/github.com/stretchr/testify-1.11.0
• dependabot/go_modules/go-modules-updates-1bff98da5a
• dependabot/go_modules/go-modules-updates-3f2513770d
• dependabot/go_modules/go-modules-updates-709908b018
• dependabot/go_modules/go-modules-updates-891cda64be
• dependabot/go_modules/go-modules-updates-be53f05598
• dependabot/go_modules/go-modules-updates-dc9768f38b
• dependabot/go_modules/go-modules-updates-dd7da38a6b
• dependabot/go_modules/golang.org/x/crypto-0.17.0
• dependabot/go_modules/golang.org/x/crypto-0.31.0
• dependabot/go_modules/golang.org/x/crypto-0.41.0
• dependabot/go_modules/golang.org/x/crypto-0.43.0
• dependabot/go_modules/golang.org/x/crypto-0.44.0
• dependabot/go_modules/golang.org/x/crypto-0.46.0
• dependabot/npm_and_yarn/frontend/copy-props-2.0.5
• dependabot/npm_and_yarn/frontend/decode-uri-component-0.2.2
• dependabot/npm_and_yarn/frontend/engine.io-and-browser-sync-6.2.1
• dependabot/npm_and_yarn/frontend/follow-redirects-1.14.8
• dependabot/npm_and_yarn/frontend/ini-1.3.8
• dependabot/npm_and_yarn/frontend/lodash-4.17.19
• dependabot/npm_and_yarn/frontend/minimist-1.2.6
• dependabot/npm_and_yarn/frontend/socket.io-parser-3.3.3
• dependabot/npm_and_yarn/frontend/ua-parser-js-0.7.33
• e2e-tests
• feat/file-upload
• feat/file-upload-v2
• feat/ui-redesign
• feature/email-sharing
• feature/paranoid-mode-sqlite
• fix/file-upload-review-fixes
• humanDuration-fix
• increase-test-coverage
• issue-31-new-ui
• issue-40-fix-http
• issue-refactor-for-issue-40
• master
• migrate-router-to-routegroup
• modern
• modern-ui-redesign
• multiple-domains
• paskal/dependabot-security-updates
• paskal/fix_golangci_lint
• refs/tags/v1.0.0
• refs/tags/v1.0.1
• refs/tags/v1.1.0
• refs/tags/v1.2.0
• refs/tags/v1.2.1
• refs/tags/v1.2.2
• refs/tags/v1.2.3
• refs/tags/v1.2.4
• refs/tags/v1.3.0
• refs/tags/v1.4.0
• refs/tags/v1.4.1
• refs/tags/v1.4.2
• refs/tags/v1.4.3
• refs/tags/v1.4.4
• refs/tags/v1.4.5
• refs/tags/v1.5.0
• refs/tags/v1.5.1
• refs/tags/v1.6.0
• refs/tags/v1.6.1
• refs/tags/v1.6.2
• refs/tags/v1.6.3
• refs/tags/v1.7.0
• refs/tags/v1.7.1
• refs/tags/v1.8.0
• refs/tags/v1.8.1
• refs/tags/v1.9.0
• refs/tags/v1.9.1
• refs/tags/v1.9.2
• refs/tags/v1.9.3
• remove-old-frontend
• seo-improvements

Build # 20283717316

Build Type

Pull #90

github

Committed by paskal

Commit Message

fix Content-Type header not being set for JSON responses

WriteHeader() locks response headers, so calling RenderJSON() after
WriteHeader() results in Content-Type not being set (silently ignored).
Use EncodeJSON() which sets Content-Type before WriteHeader.

See: https://github.com/go-pkgz/rest/issues/38

Pull Request Pull Request #90: fix Content-Type header not being set for JSON responses

Run Details

2 of 2 new or added lines in 1 file covered. (100.0%)

1298 of 1474 relevant lines covered (88.06%)

22.41 hits per line