umputun / remark42
84%
master: 85%

Repo Added 07 Feb 2020 09:18PM UTC

Token eqCnozHBf54UGZ8kokrZbOvkEkhZY23aj regen

Build 1777 Last

Committed 17 Apr 2026 11:36PM UTC coverage: 84.345%. Remained the same

Committed by

Commit Message

test: use testing/synctest to eliminate wall-clock sleeps

Go 1.25's testing/synctest package (GA) provides a fake clock bubble
for deterministic goroutine and timer testing. Convert tests that
waited on real-time durations to use synctest, removing most wall-clock
time.Sleep workarounds.

Converted (11 tests, 9 files):
- notify/notify_test.go — all tests, replaced 17 time.Sleep(110ms) with synctest.Wait()
- store/service/service_test.go — VoteSameIPWithDuration, UserReplies, submitImages,
  ResubmitStagingImages, deleteImagesOnCommentDelete
- store/image/{image,bolt_store}_test.go — Cleanup, Submit, SubmitDelay
- store/engine/bolt_test.go — FlagListBlocked
- providers/telegram_test.go — DispatchTelegramUpdates
- migrator/backup_test.go — TestBackup_Do
- _example/memory_store/accessor/data_test.go — FlagListBlocked

Simplifications along the way:
- notify/notify_mock.go: dropped the 10ms time.After delay and
  ctx.Done select in MockDest — the artificial I/O simulation is
  pointless and blocked synctest.Wait from draining the queue
- Removed three dead-code time.Sleep(1s) calls in EditCommentDurationFailed,
  EditCommentAdmin, and Info tests: prepopulated comments from 2017
  already exceed any EditDuration/ReadOnlyAge under real clock, making
  the sleeps meaningless
- UserReplies: replaced the Eventually+Sleep+mutex polling with a
  direct time.Sleep under fake clock

Skipped (incompatible with synctest):
- fs_store_test.go: relies on OS file mtime (real wall clock)
- rss_test.go: needs real wall-clock second boundary for pubDate
- admin/rest_private/rest_public tests: httptest network I/O
- cmd/server_test.go: real HTTP server startup polling

Notes on quirks encountered:
- synctest.Wait() does NOT advance fake time, contrary to what one
  might expect. It only returns once all other bubble goroutines are
  durably blocked. To advance the fake clock, the test goroutine must
  itself call time.Sleep
- BoltDB keys the "last" bucket by comment.Timest... (continued)

Coverage Stats

6223 of 7378 relevant lines covered (84.35%)

34.33 hits per line

7378 RELEVANT LINES 6223 COVERED LINES

34.33 HITS PER LINE

Builds	Branch	Commit	Type	Ran	Committer	Via	Coverage
24591322614	tests/synctest-refactor	test: use testing/synctest to eliminate wall-clock sleeps Go 1.25's testing/synctest package (GA) provides a fake clock bubble for deterministic goroutine and timer testing. Convert tests that waited on real-time durations to use synctest, removi...	Pull #2048	17 Apr 2026 11:39PM UTC	paskal	github	84.35

umputun / remark42
84%
master: 85%

umputun / remark42 84% master: 85%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

CHANGE BRANCH x

Relevant lines Covered

Source Files on tests/synctest-refactor

Recent builds

umputun / remark42
84%
master: 85%

README BADGES
x

CHANGE BRANCH
x