umputun / dkll

83%

master: 83%

LAST BUILD ON BRANCH fix/syslog-parser-panic

branch: fix/syslog-parser-panic

CHANGE BRANCH

x

Reset

• fix/syslog-parser-panic
• agent
• chore/deps-and-go-1.26
• ci/workflow-hardening
• demo
• dependabot/github_actions/github-actions-updates-d2f953908f
• dependabot/go_modules/github.com/docker/docker-25.0.6incompatible
• dependabot/go_modules/github.com/fsouza/go-dockerclient-1.12.1
• dependabot/go_modules/github.com/fsouza/go-dockerclient-1.4.1
• dependabot/go_modules/github.com/go-chi/chi/v5-5.2.1
• dependabot/go_modules/github.com/go-chi/chi/v5-5.2.2
• dependabot/go_modules/github.com/go-chi/chi/v5-5.2.3
• dependabot/go_modules/github.com/go-pkgz/lgr-0.12.0
• dependabot/go_modules/github.com/go-pkgz/lgr-0.12.1
• dependabot/go_modules/github.com/go-pkgz/rest-1.20.3
• dependabot/go_modules/github.com/go-pkgz/rest-1.20.4
• dependabot/go_modules/github.com/opencontainers/runc-1.1.12
• dependabot/go_modules/go-modules-updates-2d978dc9b6
• dependabot/go_modules/go-modules-updates-8dcc27ee2b
• dependabot/go_modules/go-modules-updates-ac3c29601d
• dependabot/go_modules/go-modules-updates-dc9768f38b
• dependabot/go_modules/go.mongodb.org/mongo-driver-1.17.3
• dependabot/go_modules/go.mongodb.org/mongo-driver-1.17.4
• fix/client-test-log-setup
• fix/compose-mongo-url-typo
• gsyslog
• master
• migrate-to-routegroup
• mongo-driver
• paskal/dependabot-disable-updates
• paskal/dependabot-security-updates
• refs/tags/v0.2.0
• refs/tags/v0.3.0
• refs/tags/v0.3.1
• v0.1.0
• v0.1.1
• v0.1.2
• v0.1.3

Build # 32312717712

Build Type

Pull #57

github

Committed by paskal

Commit Message

Fix panic on truncated syslog lines

Previously, NewEntry sliced the line by the offset of the host and the
service token without checking that anything follows them, so a line
ending right after the timestamp, the host or the service token panicked
with an index out of range. The same applied to the RFC3339 branch of
parseTime when the line carried nothing but a timestamp. Since the syslog
server accepts unauthenticated UDP and TCP input, such a line terminated
the whole process.

After this change both use strings.Cut and return an error for a line with
a missing token or separator, so the forwarder logs it and carries on.

Pull Request Pull Request #57: Fix panic on truncated syslog lines

Coverage Stats

16 of 16 new or added lines in 1 file covered. (100.0%)

1021 of 1224 relevant lines covered (83.42%)

19773.39 hits per line