umputun / cronn

74%

master: 75%

LAST BUILD ON BRANCH web-execution-history

branch: web-execution-history

CHANGE BRANCH

x

Reset

• web-execution-history
• auth-implementation
• brute-force-protection
• conditional-execution
• dependabot/github_actions/github-actions-updates-a2e7793ad6
• dependabot/go_modules/github.com/go-pkgz/lgr-0.12.0
• dependabot/go_modules/go-modules-updates-07f3a6036d
• dependabot/go_modules/go-modules-updates-24b9848b30
• dependabot/go_modules/go-modules-updates-5acbcdf0e0
• dependabot/go_modules/go-modules-updates-e08d9a54d9
• dependabot/go_modules/go-modules-updates-e7f7ae579a
• feat/alt-template-delimiters
• feat/filter-and-template-refactoring
• feat/neighbors-selector
• feat/run-now-button
• feature/manual-job-customization
• feature/settings-modal
• feature/web-base-url
• feature/web-hostname
• feature/web-manual-disable-options
• fix-execution-id-type
• fix/web-parser-reuse-sqlite-locking
• gorelease
• improve-conditions-validation
• jitter-duration
• master
• paskal/clarify_email_notifications
• paskal/dependabot-disable-updates
• paskal/dependabot-security-updates
• paskal/fix_successful_notifications
• paskal/more_notifications
• paskal/notify
• paskal/update
• refs/tags/v0.2.0
• refs/tags/v0.3.0
• refs/tags/v0.3.1
• refs/tags/v0.4.0
• refs/tags/v1.0.0
• refs/tags/v1.1.0
• refs/tags/v1.1.1
• refs/tags/v1.2.0
• refs/tags/v1.3.0
• refs/tags/v1.4.0
• refs/tags/v1.5.0
• refs/tags/v1.5.1-beta.1
• refs/tags/v1.5.10
• refs/tags/v1.5.11
• refs/tags/v1.5.2
• refs/tags/v1.5.3
• refs/tags/v1.5.4
• refs/tags/v1.5.5
• refs/tags/v1.5.6
• refs/tags/v1.5.7
• refs/tags/v1.5.8
• refs/tags/v1.5.9
• refs/tags/v1.6.0
• refs/tags/v1.6.1
• refs/tags/v1.7.0
• refs/tags/v1.7.1
• refs/tags/v1.8.0
• refs/tags/v1.8.1
• refs/tags/v1.9.0
• sighup
• site
• web-ui
• yaml-config-support

Build # 19323480760

Build Type

Pull #51

github

Committed by umputun

Commit Message

fix: address QA and architecture review findings

**Critical fixes:**
- fix race condition in TestScheduler_resumeInterrupted test
  - add mutex synchronization around capturedNotification variable
  - verified with race detector (now passes)

**Code cleanup:**
- remove dead code from OutputCapture (SetError, Error methods, err field)
  - leftover from ErrorWriter refactoring
  - removed 40+ lines of unused code and tests

**Refactoring:**
- extract duplicate code in handleJobEvent to recordExecutionAndCleanup helper
  - removes duplication between EventTypeCompleted and EventTypeFailed cases
  - improves maintainability

**Performance:**
- optimize database index from two separate indexes to composite index
  - replace idx_executions_job_id and idx_executions_started_at
  - with idx_executions_job_started(job_id, started_at DESC)
  - optimizes queries with WHERE job_id AND ORDER BY started_at DESC

**Testing:**
- all tests pass (90.7% service, 88.1% web, 84.0% persistence)
- race detector clean
- linter: 0 issues

Pull Request Pull Request #51: Add execution history with SQLite storage and web UI display

Run Details

206 of 227 new or added lines in 5 files covered. (90.75%)

6 existing lines in 4 files now uncovered.

2482 of 3345 relevant lines covered (74.2%)

36.4 hits per line