ukeeper / ukeeper-readability

78%

master: 78%

LAST BUILD ON BRANCH fix/textarea-crlf

branch: fix/textarea-crlf

CHANGE BRANCH

x

Reset

Sync Branches

• fix/textarea-crlf
• ci-dockerhub-soft-fail
• ci/workflow-hardening
• cleaner_frontend_structure
• dependabot/docker/node-22
• dependabot/github_actions/github-actions-updates-14cb627f6c
• dependabot/github_actions/github-actions-updates-1ee787ebfb
• dependabot/github_actions/github-actions-updates-5714300483
• dependabot/github_actions/github-actions-updates-640176b5ab
• dependabot/github_actions/github-actions-updates-7aa8621bec
• dependabot/github_actions/github-actions-updates-afd9e15987
• dependabot/go_modules/backend/go-modules-updates-08b33d1c25
• dependabot/go_modules/backend/go-modules-updates-0bc617739e
• dependabot/go_modules/backend/go-modules-updates-407dd4786b
• dependabot/go_modules/backend/go-modules-updates-5e29427af7
• dependabot/go_modules/backend/go-modules-updates-5e519fa3dd
• dependabot/go_modules/backend/go-modules-updates-71a6db2b89
• dependabot/go_modules/backend/go-modules-updates-751992312c
• dependabot/go_modules/backend/go-modules-updates-a616c34cc0
• dependabot/go_modules/backend/go-modules-updates-c1eb5b8ad9
• dependabot/go_modules/backend/go-modules-updates-c2169da76e
• dependabot/go_modules/backend/go-modules-updates-d01d85479d
• dependabot/go_modules/backend/go-modules-updates-d6af324dbd
• dependabot/go_modules/backend/go-modules-updates-ec788c1f9d
• dependabot/go_modules/backend/go-modules-updates-f885172778
• dependabot/go_modules/backend/golang.org/x/crypto-0.31.0
• dependabot/go_modules/backend/golang.org/x/net-0.36.0
• dependabot/go_modules/go-modules-updates-0b36ab2f83
• dependabot/npm_and_yarn/frontend/npm-development-modules-updates-89027bf77e
• dependabot/npm_and_yarn/frontend/npm-development-modules-updates-e6f6ae78c6
• deps/update-latest-go1.25
• fix-cf-maxretries-doc
• fix-top3-review
• fix/docker-gha-cache
• fix/image-fetch-streaming
• fix/ssrf-ip-guard
• generic-updates
• htmx
• master
• modularise-retrieval
• openai-auto-extraction
• openai_rules_generator
• openai_rules_improver
• paskal/bump_modules
• paskal/clarify_comment
• paskal/cleanup_readme
• paskal/fix_build
• paskal/improve_docker_compose
• paskal/index_to_htmx
• paskal/migrate_to_htmx
• paskal/offline_tests
• paskal/remove_edit_html
• paskal/return_rule_id_on_update
• paskal/safe_password_check
• refs/tags/v0.1.0
• refs/tags/v0.1.1
• refs/tags/v0.1.2
• refs/tags/v0.2.0
• remove-jquery
• remove_chi
• typos_fixes
• umputun/add-chatgpt-endpoints
• update-deps-2026-04-11
• worktree-ci-hardening

Build # 28681291847

Build Type

Pull #84

github

Committed by paskal

Commit Message

Trim and drop empty lines when saving multi-line rule fields

saveRule split match_url, excludes and test_urls on "\n" only, so
browser-submitted \r\n left a trailing \r on every entry and blank lines
became empty-string entries, and this junk accumulated on every round-trip
through the edit form. New splitTrimLines trims each line and drops empties;
handlePreview reuses it in place of its ad-hoc split-and-trim loop.

Because splitTrimLines yields an empty slice for a blank textarea, the bson
"omitempty" on match_urls/excludes would have dropped the field from the
$set on update, silently keeping stale values. Drop the omitempty tags on
the form-editable fields (match_urls, excludes, use_cloudflare; test_urls
already lacked one) so clearing a field or unchecking the Cloudflare box
actually clears it, and normalise nil slices to []string{} in Save so
cleared arrays are stored as BSON arrays rather than null.

Pull Request Pull Request #84: Trim and drop empty lines when saving multi-line rule fields

Coverage Stats

23 of 23 new or added lines in 2 files covered. (100.0%)

783 of 1000 relevant lines covered (78.3%)

9.77 hits per line