uber / zanzibar

68%

master: 69%

LAST BUILD ON BRANCH argo/qparam_fixes

branch: argo/qparam_fixes

CHANGE BRANCH

x

Reset

• argo/qparam_fixes
• 0.4.4
• 0.4.5
• 0.5.0
• 0.5.1
• 284-handleBackendPanic
• ADD-SUPPORT-PENDING-OBJECT-TYPE-SERVER-HTTP-RESPONSE
• OVERRIDE-ENV-FOR-SHADOW-REQUEST
• RouterPatternPath
• T1442423-defaultHeaders
• T1459853-tchannelClient-loggerPanic
• T1460341-fixLicense
• T1569727
• T1979589
• UberSourceHeaderFix
• WhitelistedPaths
• able-todisable-gen-mock
• add-ability-to-attach-env-vars-to-root-scope
• add-automaxprocs
• add-default-header-forward
• add-delete-client-mechanism
• add-field-accessor
• add-field-accessors
• add-generation-for-client
• add-import
• add-logging
• add-peekbody
• add-recognition-of-transform-err
• add-rk-support
• add-service-config-update
• add-shadow-mode
• add-static-value
• add-support-for-multiple-exceptions-same-status-code
• add-tchannel-redirect
• add-url-logging
• add-url-pattern-field
• addMoreLogging
• add_application/json
• add_clientless_endpoint
• add_copyrights
• add_empty_header_get
• add_logger_endpoint_to_resp
• address-comment
• alignnamespace
• annotate_endpoint_spec
• argo/allow_param_rewrite
• argo/debug-tchan-error
• argo/disambiguate-close-query-params
• argo/exposeOneMethod
• argo/fix-http-cktbreaker
• argo/fix-nil-ptr-tmpl
• argo/fix-slice-out-of-bounds
• argo/fix_coverage_script
• argo/fix_qparam_enum
• argo/glide-up
• argo/hystrix-tweak
• argo/increase-latency-buckets
• argo/latency-bucket-override
• argo/m3_timer_to_histogram
• argo/make-histo-with-timer
• argo/more_descriptive_errors
• argo/query_params_for_all
• argo/query_params_for_all_methods
• argo/query_with_set_fix_codegen
• argo/set-qparam-as-list
• argo/sets_in_query
• argo/suppress-noise-logs
• argo/travis-go-update
• argo/write_http_request_body
• as.context
• as.http
• bench-exit-code
• bench_gateway
• best-ip
• bump-tchannel
• bypass_breaking_change
• bypass_yarpc_client_change
• check-if-file-is-thrift
• circuit_breaker
• class_config
• cleanup-middlewares
• cli.allow-update-diff
• cli.error-validation
• cli.fix-flaky-tests
• cli.fix-tests
• cli.json-format
• cli.lockfree-repository
• cli.refactor-test-stub
• cli/add-sidecar-routing-update
• cli/add-type-converter-integration-test
• cli/bug-fixes
• cli/bump-tchannel
• cli/bump-travis
• cli/case-sensitive-headers
• cli/chain-trace-id
• cli/change-log
• cli/change-log-1
• cli/extend-context-logger
• cli/fix-bug-in-header-propagate
• cli/fix-crash
• cli/fix-i64-path
• cli/fix-linter
• cli/fix-master
• cli/fix-middeware-crash
• cli/fix-setdownstream-sig
• cli/fix-type-converter
• cli/handle-primary-types
• cli/header-case
• cli/header-convert-full
• cli/headers-test
• cli/implement-timeout
• cli/improve-header-schema
• cli/read-test-json-while-testing
• cli/refactor-header-cast
• cli/support-anno-from-config
• cli/test
• cli/type_converter_refactor
• cli/validate-exceptions
• clientRoutingKey
• client_config
• client_config_2
• codemonkeycxy-patch-1
• comment-module-deps
• commitMessage
• config_file_path
• content-type-response
• contextGetter
• convert-nested-bodies
• deletes-can-now-have-a-body
• disable-request-and-response-body-logging
• disable_lint
• dynamic_channel_rd
• dynamic_channels
• dynamic_channels_rd
• easy_json_parallelize
• easyjson-checksum
• easyjson-generated-comments
• edwin.apprentice
• edwin.http
• edwin.httpScope
• edwin.interface
• edwin.revert
• edwin.tmplFunc
• eh
• emit-logger-metrics
• enable-delete-with-body
• endpoint-init
• enum_support
• export_metrics
• expose-endpointClassConfig
• exposePendingResponse
• exposeWithEndpointField
• expose_api_construct_config
• expose_readInstance
• extractHeader
• faster-builds
• feature/procedureheader
• filtered_thrift_spec
• fix-assign
• fix-benchmarks
• fix-code-coverage-script
• fix-endpoint-name
• fix-golient
• fix-lint
• fix-lint-1
• fix-modtime-bindata
• fix-nested-containers
• fix-optional-headerval
• fix-pkg-json
• fix-reg-imports
• fix-register-template
• fix-staticcheck-errors
• fix-string-return
• fix-type-initial
• fix-uuid-key
• fixEndpointRequest
• fix_acronyms
• fix_compatibility
• fix_headers_in_endpoint_to_client
• fix_json_yaml_marshalling
• fix_nil_pointer_dereference
• fix_service_config
• fix_start_prefix
• fixtest
• fixup-double-ip
• flexible-default-middleware
• fm.code-to-parsed
• fm.thrift-code
• fx
• googlenow_test_202
• gverma/extend-header-interface-return-all-values
• gverma/extend-test-gateway-to-support-header-values
• handle-same-method-name
• header-propogate-bug
• headers-support
• hostname-pid-zone
• hothero/support-not-follow-redirect
• hs/remove_unwanted_error
• http-alternative-routing
• http-client-class
• http-client-header-validate
• http-client-read-all-always
• http-client-request
• http-client-response
• http-header-validation
• http-json-docs
• http-send
• http-server-response-tests
• http-status-code
• i64-update-1
• ignore_populate_spec_stage_err
• improve-import-management
• improve-makefile
• improveLogging
• improved-cover
• improved-status-code
• improved-tests
• inject-jsonparser-interface-option
• install_yq
• jacobgreenleaf-patch-1
• jacobgreenleaf-patch-2
• jacobgreenleaf-patch-3
• jacobgreenleaf-patch-4
• jaeger-inject
• jaeger-inject-1
• jg-app-metrics
• jg-appfolders
• jg-bench-logger
• jg-build-ordering
• jg-bumpdeps-multierr
• jg-changelog-lie
• jg-client-http-ctx
• jg-client-logger
• jg-context-logger-mockserver
• jg-context-logger-requuid
• jg-delete-http-body
• jg-doubledot
• jg-expose-logfields
• jg-fixup-log-fields-tests
• jg-folderstructure-idlfolder
• jg-folderstructure-mockgen
• jg-fx
• jg-fxify-main
• jg-glidefx
• jg-goimports-precedence
• jg-grpc-mockserver
• jg-http-contextlogs
• jg-httpendpoint-ctor
• jg-inc-justone
• jg-inc-physicaldir
• jg-inc-postgen
• jg-incremental-generate-dependencies
• jg-lint-master
• jg-logger-development
• jg-mock-grpc
• jg-mock-tasks
• jg-module-serialized
• jg-panic-list
• jg-router-iface
• jg-router-unit
• jg-tchannel-contextlogs
• jg-thriftrw-srcs-idldir
• jl/add_tracing
• jl/dc_fixups
• jl/errs
• jl/fix_compare
• jl/middle_schema
• jl/middleware_config
• jl/mw_clients
• jl/mw_shared_state
• jl/shared_state_fixup
• jl/skip_no_config
• jl/type_converter
• jl/type_converter_copy
• jl/type_converter_map_typedef_fix
• jl/xform
• jpemberthy-patch-1
• json_neutral
• keepdeprecatedsignature
• less-picky-about-get
• log-fields
• logFieldExtractor
• log_filtering_framework_client
• logger
• logging_fix_router
• lu.app
• lu.backend
• lu.bazel
• lu.bench
• lu.boxed
• lu.bump
• lu.cc
• lu.changelog
• lu.cleanup
• lu.client-interface
• lu.clients
• lu.co
• lu.codegen
• lu.cover
• lu.ct
• lu.ctx
• lu.custom
• lu.debug
• lu.defer
• lu.doc
• lu.eclint
• lu.ej
• lu.endpoint
• lu.env
• lu.fix
• lu.g
• lu.genmock
• lu.go1.11
• lu.golden
• lu.gr
• lu.grpc
• lu.gs
• lu.hook
• lu.hp
• lu.hr
• lu.import
• lu.init
• lu.isstruct
• lu.l
• lu.lint
• lu.list
• lu.log
• lu.logger
• lu.logheaders
• lu.mc
• lu.metrics
• lu.mm
• lu.mock
• lu.mockgen
• lu.mockserver
• lu.module
• lu.ms
• lu.mspec
• lu.multidir
• lu.nodep
• lu.ph
• lu.post
• lu.proto
• lu.query
• lu.race
• lu.rc
• lu.reflect
• lu.reg
• lu.res-type
• lu.router
• lu.routing
• lu.service
• lu.sub
• lu.sweeptodo
• lu.tag
• lu.tally
• lu.tc
• lu.tchan
• lu.tchan-baz
• lu.tchan-baz1
• lu.tchan2
• lu.tchan3
• lu.tend
• lu.test
• lu.testbackend
• lu.thrift
• lu.thriftrw
• lu.timeout
• lu.toc
• lu.todo
• lu.tracer
• lu.travis
• lu.ts
• lu.type
• lu.typedef
• lu.typo
• lu.variadic
• lu.wf
• lu.wj
• lu.yarpc
• lu.zap
• make-middleware-optional
• make-success-logging-debug
• makefile
• mandatory-middleware
• master
• me.clientspec.source
• me.config.args
• me.dep.structs
• me.generate.instance
• me.init.service
• me.module.config
• me.modules
• me.modules.clients
• me.packageinfo
• me.resolve.deps
• me.return.spec
• me.service.module
• me.template.cleanup
• me.template.generalize
• me.templates.public
• metrics_hystrix
• middleware-file-fix
• middleware-options
• middleware-schema-embed
• middleware_configs
• middleware_stack
• mock_client_interfaces
• mock_workflow
• module-path-fix
• module_idl_paths
• more-converters
• multiple-workflows
• nested-query-params
• nturner/deputy-fix
• omitempty_for_config_fields
• optional-datacenter-file
• options_to_create_mocks
• panic-handler
• parallelization_module
• parallelize
• parallelize_resolve_module
• parallelize_second
• paramaterize_bench_gateway
• parseMethodNamesHandler
• parse_either_json_or_yaml
• peek-response-body
• pending_stat
• per-worker-prefix
• pin_atomic
• po
• postGenHookFix
• pre-steps-vendor
• ptr_template_fix
• query-params-client
• raw-body-error
• read-dc-once
• read_task_config
• recursive-call
• refactor_write_json
• refs/heads/master
• register_middlewares
• relative-tests
• remove-check
• remove-check-gateway-idl
• remove_cycle_in_template_files_bundle
• remove_easyjson
• rename
• renameClientlessMiddleware
• rename_runtime
• rename_serverheaderinterface
• resolvei64-sort
• revert-401-middleware-tchannel
• revert2
• revertBranch
• revertBranch1
• revert_easyjson
• revert_qparam_all
• rj.benchmark
• rj.clientID
• rj.deps
• rj.entity
• rj.fix
• rj.stats
• rj.tchannel
• ronaldhsu/support-not-follow-redirect
• rpatali-github-action
• rpatali/binaryspec
• rpatali/boxed
• rpatali/bug-get-ancestors
• rpatali/casing
• rpatali/defaultHeaders
• rpatali/export
• rpatali/fix-coverage
• rpatali/fixslash
• rpatali/getter_starttime
• rpatali/header-params
• rpatali/http_noContent
• rpatali/hystrixMetric
• rpatali/incremental-build
• rpatali/lowercase
• rpatali/proto-client-gen
• rpatali/respNoBody
• rpatali/shutdown_health
• rpatali/static_config
• rpatali/template_go1.10_compat
• rpatali/yarpc-client-template
• rpatali/yarpc-outbounds
• rpatali/yarpcClientConfig
• runtime-metrics-2
• runtime-stacktrace
• sc-binary-check-nil
• scopefield
• selective_module_generate
• serverless-zanzibar
• set-shardkey-and-routingdelegate-in-calloptions
• set-shardkey-in-tchannel-client
• shutdown_tchannel
• skip-writing-content-with-status-code-204-no-content
• skipping_module
• squash_log
• standardize_goimports_formatting
• status-code-logging
• status-code-tag
• support-nested-structures
• support-non-vendor
• tahmid.addtestscope
• tahmid.fixheaders
• tahmid.fixslice
• tahmid.fixworkflowmock
• tchaneldeputy
• tchaneldeputytest
• tchannel-always-close
• tchannel-metrics-clean
• tclient
• tclienttest
• test
• test-default
• test-olivia
• test_endpointt_rollback
• test_tchannel_fix
• testbuild
• testfailure
• thrift-exception-client
• thrift-exception-server
• thrift-update
• thriftrw_bump
• transforms
• travis-integration
• travis-update
• unbreak-metrics
• uniq-id-in-loop
• unique-id
• unmarshal_body_check
• unmarshal_response_struct
• update-deps
• update-managed-thrift
• update-test-all
• update_logging
• update_metric_name
• update_use_context_logger
• url-params-server-side
• use-bindata
• use-go-instead
• use-thriftrw-args
• use_context_logger
• v0.1.0
• v0.1.1
• v0.1.2
• v0.2.0
• v0.3.0
• v0.3.1
• v0.4.0
• v0.4.1
• v0.4.2
• v0.4.3
• v0.4.4
• v0.4.5
• v0.4.6
• v0.6.0
• v0.6.1
• v0.6.2
• v0.6.3
• v0.6.4
• v0.6.6
• v1.0.0
• v1.0.1
• vendor_goimport
• verify-binary-works
• verify-enum
• verify-i64
• verify-require-optional
• wip.wut
• write-resp-bytes
• xuan.test
• xuantest
• xuantest2
• xuantestbuild
• yaml_env_config
• yaml_for_configs
• yaml_support
• yaml_support_for_static_config
• yq_install
• zanzibar-read-service-from-env
• zw.add-land-diff-handler
• zw.compiled-thrift-to-code
• zw.errors
• zw.expose-methods
• zw.fix-make-test
• zw.fix-writing-endpoint-meta-file
• zw.idl-registry
• zw.more-handlers
• zw.rename-googlenow
• zw.repo-handler
• zw.repo-manager
• zw.thrift-compile
• zw.thrift-structure
• zw.update-client
• zw.update-endpoint
• zw.update-middleware-config-tags

Build # 422

Build Type

Pull #655

travis-ci-com

Committed by web-flow

Commit Message

Fix query-param handling on the client side

There are scenarios where the annotations are ignored when the client thrift actually specifies it.
Similarly on the endpoint thrift, handling had some bugs. This fixes both.

Pull Request Pull Request #655: Fix query-param handling on the client side

Run Details

46 of 46 new or added lines in 4 files covered. (100.0%)

8088 of 11922 relevant lines covered (67.84%)

1.36 hits per line