uber / tchannel-go

85%

dev: 88%

LAST BUILD ON BRANCH flaky_requeststate

branch: flaky_requeststate

CHANGE BRANCH

x

Reset

• flaky_requeststate
• ajs-cleanup
• master
• thrift_headers
• v1.0.0
• pv_version
• josh_streaming_explore
• thrift_struct
• rw-interface
• rw-able-interface
• such_lint
• changelog_gen_script
• error_handler_func
• peer_heap
• fix_error_logger
• peer_heap_unexport
• fix_lint
• avoid_host
• travis_lint
• error_log
• remove_peer
• version_cut
• v1.0.1
• dev
• readarg23
• go-thrift-stream
• hyperbahn_retry
• dial_timeout
• rank_test
• go_tip
• hyperbahn_log
• travis_golint
• ajs-xpr
• v1.0.2
• dial_timeout_test
• ignore_lint
• read_test_failure
• test_frag_slow
• imalison
• track_channels
• mex_safe
• mex_readerwriter
• ajs-relay
• muttley
• flaky_readtimeout
• flaky_streamcancelled
• thrift_byte
• stream_stuck
• v_1.0.3
• v1.0.3
• vet_err
• logfields
• hyperbahn_stub
• stream_unblock_readers
• unblock_on_close
• imalison2
• conn_err
• set-handler
• atomic_race
• introspect_order
• increase_timeout
• thrift_nilerr
• sleep_leak
• stats_flake
• flaky_fragmentation_test
• remove_outbound
• ajs-conns
• rand_conn
• ajs-leaks
• ajs-travis
• v1.0.4
• ajs-sync-refs
• ajs-fixme
• ajs-atom
• get_args
• context-with-headers
• ajs-lint
• ysh-context-with-headers
• ajs-atomics
• peer_state
• close_states
• close_test
• eats_logger
• ajs-structy
• thrift_ctx
• coveralls_flaky
• cancel_ctx
• flaky_test
• enable_logging
• ajs-cache
• ajs-install-test
• leak_end
• frame_pool
• no_leak_test
• ajs-flake1
• log_err
• cleanup_examples
• verified_server
• logger_faster
• state_ignore
• peer_test_cleanup
• ignore_settimeout
• timeout_no_goroutine
• leak_detector_skip
• log_fields
• improve_logging
• testserver_client
• stream_test
• retry_request_state
• inner_server
• created_stacktrace
• stack_fix
• test_server
• stream
• log_fail
• unexpected_conn_change
• conn_change
• 1.0.5
• v1.0.5
• unmarshal_text
• eats_logger_updated
• muttley_inbounds
• health
• connect_timeout
• thrift_gen_case
• pengzhai
• muttley_declined
• flaky_tests
• muttley_forwarderr
• muttley_lazy_frame
• ajs-tests
• muttley_flaky_close
• muttley_better_introspection
• ajs-git
• peer_test_close
• ajs-copy
• muttley_remove_relaytest
• muttley_runcount
• fix_goroutine_leaks
• muttley_testserver
• testutils_again
• ajs-moar
• connect_flake
• interceptor
• long_test
• race_flaky
• ajs-evenmoar
• timeout_multiplier
• remove_verify
• bench_binaries
• fix_flaky_arg3
• interceptor_dev
• glide
• muttley_bench
• writer_after_connerr
• repeat_bench
• interceptor_thrift
• muttley_repeat_bench
• relay_missing_logger
• relay_no_ctx
• interceptor_thrift_wip
• relay_method
• ajs-metrics
• bench
• womp
• copy_api
• dup_check
• peer_score_calc
• close_fix
• flaky_writearg3
• get_handler
• test_flakes
• init_res
• relay_atomic
• remove_unused
• relay_logger
• testutils
• race_add_close
• ajs-metrics2
• close_conn
• relay_not_closing
• misc_introspection_logging
• init_res_handling
• coverage_introspection
• ch_active_conn
• interceptor_original
• lock_peers
• no_start_close
• relay_race_timeout
• flaky_relay
• relay_default
• fix_flaky_test
• move_ctx_inside
• remove_atomic
• ajs-caller
• ajs-err-names
• ajs-metrics3
• ajs-metrics6
• lazy_frame
• interceptor_master
• non-error-code
• v1.0.6-dev
• tracing_span_order
• release_1.0.6
• v1.0.6
• import_ordering
• validate_pre_connection
• call_span
• relay_assignment
• byte_slice_params
• hosts_err
• close_err
• fake_call_frame
• eats_logger_compatible
• benchmark_logging
• ajs-benchbug
• pv_relay_pool
• pv_benchmark_logging
• add-caller-forwarding
• pv_finishes_bug
• ajs-zones
• set_request_size
• integrate-opentracing
• relay_outgoing_nohostport
• enable_1.7
• always_set_assignment
• fix-glide-install
• flaky_responseclosed
• flaky_peer_remove_closed
• ajs-fluent
• travis_1.7rc1
• flaky_peerscorenewconn
• release_1.0.7
• v1.0.7
• remove_test_deps
• v1.0.8_notes
• v1.0.8
• no_test_deps
• relay_enable_test
• remote_hp_mismatch
• introspect_num_connections
• no_mock
• flaky_relay_closed_peers
• introspection_tchannel
• introspection_include_version
• goroutine_leak_multiexclude
• update_changelog
• v1.0.9
• call_logging
• relay_handle_call
• pass-context-to-response-callback
• partial_read_stream
• integrate-opentracing-glide-xdock
• integrate-opentracing-crossdock-tests
• go_version
• mock_real_forward
• ajs-conn-prefixes
• include_others
• json_err
• ajs-expose-routing-delegate
• relay_outgoing
• add_tracing
• remove-tracer-from-registrar
• crossdock-in-travis
• export_remote_peer
• go17
• fix_0_ttl
• dev-fix-moe
• require-thrift-fields
• fix-peer-ip-tag
• release_1.1
• v1.1.0
• struct_sizes
• eats_logger_compatible_rebase
• ajs-stats-race
• relay_dest_log
• rk
• sc_options_on_new
• v1.2.0-dev
• v1.2.0
• xichen-fix-peer-connection-race
• nathan/add_dispatcher
• mock_peerselection
• cancel_connect
• use_root_peers
• aniketpant-req-cancel
• fix-concurrent-map-writes
• travisbranchinenv
• v1.2.1
• increase_tombstones
• lint_16
• cleanup_logs
• ephemeral_py
• connection_process
• conn_transition
• aniketpant-expire-exchange
• dscp_tos
• aniketpant-err-req-cancelled
• peer_active_conn
• relay_channel_closed
• rate_limit
• log_conn_dir
• refactor_relay_test
• relay_queuefull
• ajs-timer-pool
• ajs-clamp-introspection
• relay_interface
• relay_err_alloc
• local_peer
• testutils_register
• robskillington/always-call-post-response-cb-if-ctx-fn-called
• use-dialcontext
• concurrent_relay_connect
• flaky_relay_concurrent_test
• ajs-timer-wheel
• wrap_ctx
• clone_ctx
• add_onclosed
• remove_remote_process_match
• ajs-test-cleanups
• pv_timer_wheel
• v1.2.2
• add_listenip_tests
• ignore_docker
• parse_version_headers
• thrift_gen
• thrift_gen_namespace
• thrift_gen_tests
• handle_empty_frame
• listenip_local
• unknown_exception
• moreargs_err
• conn_options_refactor
• changelog
• publicize-root-peers
• v1.2.3
• pin-glide
• notify-peer-change
• for-yarpc-peer-lists
• use_package_filename
• v1.3.0-prep
• v1.3.0
• v1.3.0-post
• add_version_local
• consistent_score
• alxn/580-SetStrategy-should-rescore
• pre_conn
• flaky_inbound_test
• root-handler
• reduce_conn_refused
• flaky_close_test
• fix_flaky_introspect
• inbound_accept_multiple
• call_id
• consistent_init_error
• v1.4.0
• expose_conn_directly
• relay_close_conn
• alun/peers-len
• alun/get-force-map
• docker-thrift-gen
• apache-thrift-0.10.0
• schallert/dscp_tos_rebase
• thrift-v1.0.0-dev
• bump_version
• v1.5.0
• apache-thrift-0.9
• remove_unused_field
• resilient_frame_parsing
• log_new_channel
• peer-status-change-on-close
• relax-write-arg3-after-timeout
• v1.6.0-pre
• v1.6.0
• v1.6.0-post
• keon-patch-1
• glide_up
• rand-load-balance
• invaliddeadline
• pin-thrift-0.10.0
• closefix
• relay_log
• without-headers
• pin-thrift-0.9
• v1.7.0
• conn_gc
• shard-relay
• go1.9
• fix_deps
• version_lint
• relayer
• delayed_frame_alloc

Build # 1547

Build Type

push

travis-ci

Committed by prashantv

Commit Message

Fix ErrInvalidConnectionState not being retried

It's possible that ErrInvalidConnectionState is retried in a race
between selecting a connection, and the connection being closed.

This should be treated as a network error which can be retried.

Caught this while debugging why TestRequestStateRetry was flaky, this
fixes the flakiness.

Run Details

3330 of 3905 relevant lines covered (85.28%)

8576.9 hits per line