uber / cherami-client-go

81%

master: 83%

LAST BUILD ON BRANCH v2.6.0

branch: v2.6.0

CHANGE BRANCH

x

Reset

• v2.6.0
• aandrade.nack-delivery-when-closed
• cg_retry
• client_option
• client_option_default
• close-synchronous
• example
• fd-leak-fix
• fix-double-close-wait
• fix_metric
• glide
• glideUp
• graceful_drain
• hbClient
• master
• more_metrics
• more_tags
• pause
• processTimeMetric
• readme_build
• reconfig_interval
• release20160626
• remove_childreporter
• singleton-tchannel
• stuck_read
• t_up
• tchannal_up
• update_cherami_thrift_version
• update_cthrift
• v0.1.0
• v0.2.0-rc1
• v1.16.1-rc1
• v1.17.0-rc1
• v1.18.0-rc1
• v1.19.0-rc0
• v1.20.0
• v1.20.1
• v1.21.0
• v1.21.0-rc1
• v1.22.0
• v1.23.0
• v1_hotfix
• v2.0.0
• v2.1.0
• v2.2.0
• v2.3.0
• v2.4.0
• v2.5.0

Build # 516

Build Type

push

travis-ci

Committed by web-flow

Commit Message

Backoff retry is not needed for ReadConsumerGroupHosts() (#38)

Some users complained that Consumer.Open() does not respect the timeout setting in the client config. After digging I found that ReadConsumerGroupHosts() has a backoff retry wrapping the thrift call. For Open() such retry is not needed. The other use of ReadConsumerGroupHosts() is in reconfiguration which itself is a big retry loop. Therefore, we don't need to have backoff retry for ReadConsumerGroupHosts().

Run Details

233 of 288 relevant lines covered (80.9%)

2208.19 hits per line