uber-go / tally

94%

master: 91%

LAST BUILD ON BRANCH abg/tagged-defer-map

branch: abg/tagged-defer-map

CHANGE BRANCH

x

Reset

• abg/tagged-defer-map
• add-multi-reporters
• add-native-histogram-support
• arcpatch-D518950
• cached-reporter
• filter
• fix-readme
• gouberatomic
• histograms
• jeromefroe/http/add-http-endpoint
• jra3/better_timers
• jra3/flush
• jra3/manual_report
• jra3/statsdreporter
• jra3/test
• jra3/test_improvements
• jra3/ticktick
• m3-reporter
• martinm-lru
• master
• mway/fqn-sprintf
• mway/licenses
• mway/mem
• mway/mem-2
• mway/mem-3
• mway/opt/0-fix-metric-sizing
• mway/opt/1-histogram-storage
• mway/opt/2-reporter-storage
• mway/opt/3-remove-scope-status
• mway/opt/4-subscope-close
• mway/opt/5-borrowed-tags
• mway/opt/6-reporter-metrics
• mway/opt/7-no-drop-metrics
• mway/opt/8-buckets-identity-validation
• prefix-tags-access
• r/add-coverage-for-subscope-inheriting-tags
• r/add-non-default-registry
• r/add-process-flush-integration-test
• r/call-on-register-error-when-listen-on-inuse-port
• r/fix-batch-sizes-test
• r/fix-possible-flush-after-close
• r/fixup-documentation
• r/instrumented-call-emit-latency-on-error
• r/m3-example
• r/m3-reporter-avoid-send-on-closed-channel
• r/pin-deps-to-semver
• r/refactor-instrumented-call-into-instrument-package
• r/remove-facebook-clock
• r/rewrite-prometheus-import-path
• r/test-remove-proto-init
• r/update-readme-clarify-newrootscope-api
• r/zero-alloc-stopwatch
• readme
• reporter-access
• return-existing-scopes-instead-of-duplicates
• revert-149-mway/mem-2
• simplify-interfaces
• stopwatch
• tcalc_no_atomic
• udp_write_string
• unpin-clock
• v/fmt
• v/go_modules
• v/revert_gomod
• v/test_fix
• v/travis
• v/tudp
• v1.0.0
• v1.1.0
• v2.0.0
• v2.1.0
• v3.0.0
• v3.0.1
• v3.0.2
• v3.1.0
• v3.2.0
• v3.3.0
• v3.3.1
• v3.3.10
• v3.3.11
• v3.3.12
• v3.3.13
• v3.3.14
• v3.3.15
• v3.3.16
• v3.3.17
• v3.3.2
• v3.3.3
• v3.3.4
• v3.3.5
• v3.3.6
• v3.3.7
• v3.3.8
• v3.3.9
• v3.4.0
• v3.4.1
• xichen-reset-metric-tags-after-return-to-pool

Build # 545

Build Type

Pull #133

travis-ci

Committed by web-flow

Commit Message

subscoping: Defer tag merging

This improves the performance of creating subscopes with new tags by
deferring merged map creation.

We currently create the merged map of tags first, and then calculate the
key which we use to determine if we have a cached subscope.

With this change, we calculate the key with slightly more complex logic
that inspects the unmerged maps and avoids paying the cost of merging
the maps if not needed.

Pull Request Pull Request #133: subscoping: Defer tag merging

Run Details

102 of 102 new or added lines in 3 files covered. (100.0%)

1003 of 1070 relevant lines covered (93.74%)

1059.27 hits per line