uber-go / mapdecode

96%

master: 97%

LAST BUILD ON BRANCH structRecurse-part_2.0

branch: structRecurse-part_2.0

CHANGE BRANCH

x

Reset

• structRecurse-part_2.0
• _start_-otherOption-part_1.0
• _start_-structRecurse-part_1.0
• _start_-structRecurse-part_2.0
• _start_-structRecurse-part_3.0
• fixTest
• loose
• master
• otherOption-part_1.0
• readme-travis
• structRecurse-part_1.0
• structRecurse-part_3.0
• travis-migrate
• v0.2.0
• v0.3.0
• v0.3.1
• v1.0.0
• yarpc-import

Build # 28

Build Type

push

travis-ci

Committed by willhug

Commit Message

Refactor fieldHook function

Summary: I was having a hard time reasoning about the fieldHook function
so I did some refactoring to make it easier to add the embedded struct
fields.

- Remove the in-place data value updates (this appears to have been an
optimization, but, it's not necessary and make the code hard to reason
about)
- Extract getting the updates struct into it's own function.
- Extract getting decodable Struct fields into it's own function.
- Extract applying updates to the srcData into it's own function.
- Rename variables to be more explicit
- Don't use the `from` field, which should be equivalent to
srcData.Type()

Test Plan: tests pass

Run Details

264 of 274 relevant lines covered (96.35%)

3.41 hits per line