uber-go / fx

92%

LAST BUILD ON BRANCH master

branch: master

CHANGE BRANCH

x

Reset

• master
• 1.0rc-yarpc
• GFM-115-godoc-package-docs
• abg-fix-test
• add-examples
• add-noop-logger
• ajs-copyrights
• ajs-sentry
• ajs-zap
• allow-ints-for-floats
• alsam-NopProvider
• alsam-beta4
• alsam-cachedProvider
• alsam-commandLine
• alsam-configErrorPath
• alsam-configLoader
• alsam-configPopulate
• alsam-configStackCallbacks
• alsam-configTypeAliases
• alsam-configWithDots
• alsam-currDirLoader
• alsam-expandProvider
• alsam-expandStaticProvider
• alsam-expandYAML
• alsam-fileName
• alsam-glideLockYARPC
• alsam-groupProviderFix
• alsam-httpModule
• alsam-ifaceConfig
• alsam-mapKeyTypeConversion
• alsam-mockDynamicProvider
• alsam-numericConversion
• alsam-parallelConfigTests
• alsam-populateNonPointerError
• alsam-removeBuckets
• alsam-removeConfigScope
• alsam-removeNetContextFromTests
• alsam-rstDocs
• alsam-scopeGroupProvider
• alsam-startStopTimeouts
• alsam-testYARPCConfig
• alsam-uhttpClient
• alsam-unmarshallerChanFunc
• alsam-updateCheramiTimeout
• alsam-updateConfigDocs
• alsam-useRolesAfterSetup
• app_root
• async
• auth-cleanup
• auth-client-registration
• auth-doc
• auth-interface
• auth-metrics
• auth-package-rename
• auth-setup
• auth-update
• bench-improvement
• benchmarkHttpClient
• beta-launch
• bool-pointer
• cached_provider
• change
• change-context-import
• changelog
• checkListener
• cherami
• clarify-noop-context
• clean-output
• clean-up-keyvalue
• cleanup-core
• cleanup-rpc-metrics
• client
• clientRace
• close-dig-objects
• config
• config-cleanup
• config-files
• config-fix
• config-parameter
• configDecoder
• configPanic
• configRefactor
• constructor-errors
• context
• context-benchmark
• context-followup
• context-prop
• context-stub
• count-logging-levels
• coverage-img
• covermode
• ctx
• ctxenc
• defaultGraph
• defaultRPCName
• delete-kafka
• dev
• development
• di
• di-first-defaults
• di-refactor
• diDispatcher
• dig-add-must-funcs
• dig-better-cycle-error
• dig-cleanup
• dig-interface
• dig-internal-cleanup
• dig-panics
• dig-prevent-cycles
• doc
• doc-err-update
• doc-fix
• docker
• docker-travis-cache
• document-testutils
• dynamic-level
• export-logger
• exposeDispatcher
• filter-registration
• finalizeGraph
• fix-auth-setup
• fix-bench-target
• fix-dev-logging
• fix-example-dependencies
• fix-examples
• fix-examples-build
• fix-flags
• fix-function-node
• fix-links
• fix-race-on-state
• fix-shadow
• fix-task-metrics-setup
• fix-thriftsync
• fix-tip-test
• fix-travis-docker
• fix-typo
• fix-vendor-log-check
• fx-context
• fx-context-1
• fx-context-update
• fx-fix-docs
• fx-test
• gendoc-task-service
• generic
• get-rename
• glib-config-interpolate
• glib-config-interpolate-expand
• glib-move-dig
• glib-nuke-env-provider
• glib-semver-dig
• glide-up
• glide-version
• global-logger-references
• glue-dig
• glue-dig-b3
• go-tools
• gs-fix-http-port
• gsm-beta3.1-patch
• gsm-dedupe-changelog
• gsm-di-first
• gsm-fix-yaml-passwords
• gsm-minor-readme-cleanup
• gsm-spiffy-up-changelog
• gsm-tidy-up
• hoist-core
• host
• hostname
• http
• http-metrics
• http-refactor
• incl
• info-logger
• init
• initialization-fix
• interfacer
• internal-context-to-log
• is-test
• items-rename
• jaeger-client
• language-cleanup
• licenceFix
• link-to-examples
• lint-changelog
• lock-yarpc
• log
• log-doc
• log-documentation
• log-metrics-panic
• log-refactor
• logger-update
• logging-config
• logging-fix
• lonelyDispatcher
• lucie
• make-license
• make-use-vendor
• maxe-examples
• md-to-godoc
• mergeObjects
• metrics-globals
• middleware
• mod
• modular
• module
• module-provider
• module-rewrite
• more-metrics
• more-things
• must-register
• name
• neutral-email
• no-test-twice
• nonglobal-fx-plugin
• noop-authclient
• nophost-fix
• one-point-seven
• only-log
• overcommit-delete-make-lint
• package
• parallelClient
• parallelSentry
• pin-tally
• pin-yarpc
• pin-zap
• pkgName
• post-zap
• preDIGUpdated
• private-logger
• publicYARPC
• race
• readme-defrag
• recursiveStaticProvider
• ref-server
• refactorConfig
• remove-errant-config
• remove-extra-pointer
• remove-is-development
• remove-package-enumeration
• remove-resources-from-host
• rename-config-provider
• rename-noop
• rename-owner
• rename-rpc-to-yarpc
• rename-uhttp-client
• report-test-failures
• reporter
• resolve_path
• revert-151-unstutter-config-change
• richgo-example
• rootNode
• roundTripper
• rpc-auth
• rpcHTTP
• runtime
• runtime-metrics
• scopedProvider
• secrets-nit-fix
• sentry
• sentry-config
• sentry-timeout
• sentryConfig
• service-cleanup
• service-options
• simplify
• simplify-tracer
• small-fix
• speed-up-make-lint
• spelling
• stackTrace
• startObserver
• state-tracking
• stats
• stats-rpc-no-global
• stats-task-no-global
• stats-uhttp-no-global
• stringTrace
• svc
• sync_yarpc
• tally
• tally-reporter-update
• tally-update
• task
• taskdoc
• tchan-context
• tdoc
• temp-disable-tip
• test
• test-commit
• test-examples
• test-term-output
• testMerge
• testfilter-check
• testing-loggers
• thrift
• thriftsync
• thriftsync-args
• thriftsync-docs
• thriftsync-update
• tidy-test-output
• timeout
• trace
• tracer
• travis-go-version
• travis-make-examples-remove
• travis-update
• try-float
• typo
• ulogDoc
• unmarshalText
• unparallelTest
• unstutter-config-change
• update-changelog
• update-dig
• update-examples
• update-jaeger-rpc
• update-license
• update-md-to-godoc
• update-md-to-godoco
• update-plugin
• update-thriftsync
• update-to-dpanic
• updateTally
• upgrade-yarpc
• v1-beta-patches
• v1.0.0-beta1
• v1.0.0-beta3
• v1.0.0-beta3.1
• vendor-richgo
• with-logger
• yaml-benchmark
• yaml-fix
• yaml-map
• yaml-or-yml
• yaml-perf
• yarpc
• yarpc-cleanup
• yarpc-fx-context
• yarpc-middleware
• yarpc-oneway-middleware
• yarpc-thrift-non-specific
• yarpcConfigV2
• year
• zap
• zap-rc3

Build # 2901

Build Type

Pull #479

travis-ci

Committed by web-flow

Commit Message

Add start and stop timeout options (#476)

We have a fixed timeout for starting modules and nothing for stopping, that can be a hindrance, for e.g. a developer machine.

Moreover there are couple bugs:
We are trying to stop modules, that are not running
Ignore errors from stoping modules

Pull Request Pull Request #479: Merge dev to master

Run Details

388 of 388 new or added lines in 22 files covered. (100.0%)

3017 of 3277 relevant lines covered (92.07%)

143.83 hits per line