uber-go / cadence-client

65%

LAST BUILD ON BRANCH master

branch: master

CHANGE BRANCH

x

Reset

• master
• 0.10.0
• 0.10.1
• 0.11.0
• 0.11.1
• 0.12.1-forward
• 0.12.x
• 0.13.1
• 0.13.2
• 0.13.3
• 0.13.4
• 0.14.x
• 0.17.x
• 0.18.1
• 0.18.x
• 0.19.1
• 0.19.x
• 0.20.x
• 0.9.3
• 1023
• AddSizeProtections
• Add_WorkflowID_log
• ConsistentQuerySandbox
• GetRawHistoryDataImp
• GetRegisteredWorkflowTypes
• HEAD
• PopulateMissingInfoInAcitivityInfo
• RequestCancelWorkflow
• WFreset
• abg/unalias-interfaces
• apidiff-action
• badge
• bowei-reset
• bugfix
• bumpFeatureVersion
• cadence-idl
• cancelact
• cancellation
• child-workflow
• client-test-version-0.11.3
• compAct
• conitnue
• custErr
• dc
• dc2
• dep
• dev_mihneao
• dispatch
• ditimeout
• dmetzgar-migrate-docs
• doc
• domain
• domainCheck
• domainclient
• downgrade-thriftrw
• emo-0.9.3-debug
• encodefix
• extName
• firewall
• fix
• fix-flaky-test
• fixSig
• fixWFNil
• fix_coverage_make_rule
• fixd
• fixlint
• fixmetrics
• fixmocksa
• fixpoll
• fqn
• ftypo
• getInfo
• getmemo
• githubtemplate
• go-sdk
• go-version-check
• goland_scope
• grpc-1
• hb
• idl
• idl-update
• increase-timeout
• logfix
• logging
• make
• memofix
• memotest
• meta
• metric
• mfateev-patch-1
• mkol_fix
• p
• partial_history
• poll_backoff_timeouts
• qlong-0.15.0-patch-childWF-reset
• qlong-decision-task-started-id
• qlong-fix-childWF-reset-panic
• qlong-selector-doc
• query-size-check
• query_timeout
• ran-make-fmt
• readme_update
• regname
• release
• rename
• revert
• revert-474-cleaned
• revert-531-fix_decision_sent_2
• revert-976-workflow-interceptor
• sa
• sdk-v2
• serviceMetrics
• signal
• signaldi
• sigwithstart
• sixteen
• ss/header_support
• ss/release
• start-wait
• sticky-query
• stickyttl
• sync
• sync-idl
• tchan
• term
• termifrun
• test
• threaddump
• throttle
• time
• timer
• unhandled-signal
• update-version
• update_client_idls
• updsa
• upsert-mock-fix
• v0.12.x
• v0.3.0-beta
• v0.3.1
• v0.3.2
• v0.4.0
• v0.4.1
• v0.5.0
• v0.5.1
• v0.6.0
• v0.6.1
• v0.7.0
• v0.7.1
• v0.7.2
• v0.7.4
• v0.7.5
• v0.7.6
• v0.8.8_hotfix
• version-metric
• versions
• visapi
• wid
• yarpc
• yarpc_options
• zack

Build # 018eb00b-32fe-466e-a603-47b49670bc66

Build Type

push

buildkite

Committed by web-flow

Commit Message

Internal workflow client test improvements (#1331)

Followups from #1327:

1. simplifying the memo/search-attr encoding tests
2. making sure the dataconverter tests can detect correct vs incorrect encoder use 

1 is pretty simple: memos and search attrs are ALWAYS JSON because the server must interpret them, so the exact bytes should not change in the future.  A hardcoded string is easy to verify, and strengthens the guarantee that "this should not change even if other encoding changes".

2 is more interesting: as originally written, the test would still pass if the custom dataconverter was *not* saved and used.
The type-assertion to check the internal field somewhat prevents that, but it's unnecessary and a disjointed check.
So it has been rewritten: now the serialized request bytes must clearly come from the test encoder, not the default encoder, and they must be detectably different.

Run Details

13374 of 20678 relevant lines covered (64.68%)

316.02 hits per line