typhonius / acquia-php-sdk-v2

99%

master: 99%

LAST BUILD ON BRANCH catch-api-errors

branch: catch-api-errors

CHANGE BRANCH

x

Reset

• catch-api-errors
• master
• try-phpdbg
• update-dependencies
• tests
• 1.0.0
• drop-phpcs-version
• drop-phpcs-version-and-unused-deps
• 1.0.1
• new-coveralls-path
• add-account-method
• 1.0.4
• 1.1.0
• delete-cd-environment
• 2.0
• 1.1
• add-links-to-operations
• notifications
• logstream
• 2.0.0
• 1.1.1
• 2.0.1
• typhonius-funding
• funding
• download-db
• issue-templates
• add-getAdmin
• 2.0.2
• get-user
• getEnvironment-fix
• truncateDB
• 2.0.3
• alter-guzzle-options
• token-expiration
• 2.0.4
• inheritdoc
• phpmd
• hotfix-post-options
• move-options
• 2.0.5
• 2.0.6
• 2.0.7
• update-phpcs
• better-api-errors
• 2.0.8
• 7.4
• phpcs-to-dev
• 2.0.9
• 64-delete-database-backup
• 2.0.10
• 2.0.11
• change-role-fixture
• 2.0.12
• 1.1.2
• add-user-agent
• 2.0.13
• github-actions
• fix-user-agent-string-application
• 2.0.14
• php73

Build # 297

Build Type

push

travis-ci

Committed by typhonius

Commit Message

Adds final test case and resends the Exception.

The reason I have chosen to throw an exception
instead of catching the exception and printing
a message is twofold.

Firstly, we cannot test the use of an exit()
or die() that would be required to catch the
error and present a message alerting the user
of the issue.

Secondly, by handling the error, it prevents
consumming libraries from easily detecting an
error has been thown and handling it gracefully.

Both of these reasons have lead me to determining
that Exceptions should be handled in code by
consuming libraries. I'll document this on the
README so users can handle the exceptions if they
wish. I'll also have to use this in Acquia Cli
and Acquia Logstream. I don't catch errors in
these at all right now so it would be an
enhancement!

Run Details

790 of 802 relevant lines covered (98.5%)

13.23 hits per line