twitter / CocoaSPDY

76%

master: %

LAST BUILD ON BRANCH spdy-origin-endpoint-manager-runloop-crash

branch: spdy-origin-endpoint-manager-runloop-crash

CHANGE BRANCH

x

Reset

• spdy-origin-endpoint-manager-runloop-crash
• develop
• develop-qfe
• feature/nsurlcache
• master
• proxy-status
• v1.1
• v1.1.1
• v1.2

Build # 367

Build Type

push

travis-ci

Committed by kgoodier

Commit Message

Fix crash in removing the runloop source.

When using a proxy auto-configuration URL, we have to schedule the
execution on a runloop. This patch attempts two fixes, though both
are guesses as I cannot get a repro. The incidents of crashes in the
CFRunLoopRemoveSource() call in _removeRunLoopSource has gone up
dramatically for iOS 10.

1. Simplify run loop modes. Just use common modes.

2. Use CFRunLoopSourceInvalidate instead of CFRunLoopRemoveSource. It
will remove the source from all modes and invalidate it.

Run Details

3 of 3 new or added lines in 1 file covered. (100.0%)

3192 of 4186 relevant lines covered (76.25%)

64.43 hits per line