tusharmath / rwc

95%

master: 98%

LAST BUILD ON BRANCH remove-prop-getter

branch: remove-prop-getter

CHANGE BRANCH

x

Reset

• remove-prop-getter
• attachedCallback
• commit-updates
• custom-effect
• develop
• doc-update
• docs
• documentation-updates
• event-handle
• event-type
• examples
• fix-initial-values
• fixes
• greenkeeper-ava-0.17.0
• greenkeeper-benchmark-2.1.2
• greenkeeper-benchmark-2.1.3
• greenkeeper-coveralls-2.11.13
• greenkeeper-coveralls-2.11.14
• greenkeeper-coveralls-2.11.15
• greenkeeper-eslint-3.5.0
• greenkeeper-eslint-3.6.0
• greenkeeper-eslint-config-standard-6.0.1
• greenkeeper-ghooks-2.0.0
• greenkeeper-nyc-10.0.0
• greenkeeper-nyc-10.1.0
• greenkeeper-nyc-10.1.2
• greenkeeper-nyc-8.3.0
• greenkeeper-nyc-8.3.1
• greenkeeper-nyc-8.3.2
• greenkeeper-nyc-8.4.0
• greenkeeper-nyc-9.0.1
• greenkeeper-redux-3.6.0
• greenkeeper-semantic-release-6.3.2
• greenkeeper-sinon-1.17.6
• greenkeeper-sinon-1.17.7
• greenkeeper-tslint-4.0.0
• greenkeeper-tslint-4.0.1
• greenkeeper-tslint-4.0.2
• greenkeeper-tslint-4.1.1
• greenkeeper-tslint-4.2.0
• greenkeeper-tslint-4.3.0
• greenkeeper-tslint-4.3.1
• greenkeeper-typescript-2.0.10
• greenkeeper-typescript-2.0.6
• greenkeeper-typescript-2.0.7
• greenkeeper-typescript-2.0.8
• greenkeeper-typescript-2.0.9
• greenkeeper-typescript-2.1.4
• greenkeeper-typescript-2.1.5
• greenkeeper-validate-commit-msg-2.10.0
• greenkeeper-validate-commit-msg-2.10.1
• greenkeeper-validate-commit-msg-2.8.1
• greenkeeper-validate-commit-msg-2.8.2
• greenkeeper-validate-commit-msg-2.9.0
• init-component
• main-fix
• maquette-example
• master
• memoize-handler
• on-prop-changes
• perf-improvements
• refactor
• remove-redux
• remove-self-event-listeners
• toTuple-fixes
• typescript-migration
• v1-migration

Build # 148

Build Type

push

travis-ci

Committed by tusharmath

Commit Message

refactor(core): remove props default getter

Default getter returns the last cached prop which causes the virtual dom differ to not set the new property thus skips the prop event. For the system to be successfully reactive change should be detected at component level only and if needed optimizations should be using immutability.

BREAKING CHANGE: props should be accessed via `.props[<prop name>]` and not directly

Run Details

55 of 58 relevant lines covered (94.83%)

12.81 hits per line