thriftrw / thriftrw-python

74%

master: 92%

LAST BUILD ON BRANCH setup-dont-check-version

branch: setup-dont-check-version

CHANGE BRANCH

x

Reset

• setup-dont-check-version
• 1.2.0
• 1.2.1
• 1.2.2
• 1.2.3
• 1.2.4
• 1.2.5
• 1.3.0
• 1.4.0
• 1.5.0
• 1.5.1
• 1.6.0
• 1.7.0
• 1.7.1
• 1.7.2
• 1.8.0
• 1.8.1
• abg/fix-build
• abg/input-too-short
• abg/response-from-the-future
• abhinav-patch-1
• benchmark-underp
• chen/profile
• decimalfix
• enum-from-the-future
• enum-item-duplicates
• fixbuild
• hash
• license
• master
• message
• more-bench
• mutable-defaults
• no-malloc
• non-strict-exceptions
• opt2
• optread
• release-1.6
• saveopt2
• streaming
• streaming-dev
• streaming-read
• strfix
• struct-docfix
• testmasterbuild
• travis-migrate
• validation-opt

Build # 705

Build Type

Pull #156

travis-ci

Committed by web-flow

Commit Message

test_binary: Appease flake8 type hints

Newer versions of flake8 treat comments like the following as type
hints.

    # type:1 = FOO

Obviously, these are not valid type hints and cause issues with the
linter.

    tests/test_runtime.py:53:41: F723 syntax error in type comment '1 = ONEWAY'
    tests/protocol/test_binary.py:187:22: F723 syntax error in type comment '1 = bool'
    tests/protocol/test_binary.py:195:25: F723 syntax error in type comment '1 = i16'
    tests/protocol/test_binary.py:199:25: F723 syntax error in type comment '1 = list'
    tests/protocol/test_binary.py:203:37: F723 syntax error in type comment '1 = binary'
    tests/protocol/test_binary.py:234:22: F723 syntax error in type comment '1 = i16'
    tests/protocol/test_binary.py:238:34: F723 syntax error in type comment '1 = i32'
    tests/protocol/test_binary.py:246:22: F723 syntax error in type comment '1 = i16'
    tests/protocol/test_binary.py:250:34: F723 syntax error in type comment '1 = i32'
    tests/protocol/test_binary.py:361:20: F723 syntax error in type comment '1 = bool'
    tests/protocol/test_binary.py:369:20: F723 syntax error in type comment '1 = bool'
    tests/protocol/test_binary.py:377:26: F723 syntax error in type comment '1 = bool'
    tests/protocol/test_binary.py:386:26: F723 syntax error in type comment '1 = i16'
    tests/protocol/test_binary.py:395:26: F723 syntax error in type comment '1 = bool'

This change avoids using `type:` in comments in the relevant files.

Pull Request Pull Request #156: setup.py: Don't check cython version

Run Details

155 of 162 branches covered (95.68%)

2196 of 2951 relevant lines covered (74.42%)

0.74 hits per line