thorgate / django-esteid

72%

master: 75%

LAST BUILD ON BRANCH fix/eligibility-check

branch: fix/eligibility-check

CHANGE BRANCH

x

Reset

• fix/eligibility-check
• 3.0
• 3.1
• 3.1-alpha1
• 3.1-alpha2
• 3.1-alpha3
• 3.1.post1
• 3.1a4
• 3.1a5
• 3.2
• 3.2.rc1
• 3.3
• 3.4.b1
• add-gh-actions
• add-new-branding
• add-new-branding-updates
• authentication
• consistent-settings
• csrftoken
• fix/convert-time
• fix/release3.1
• fix/settings
• i18n
• master
• mid-default-lang
• mobileid-optional-phone-check
• release-3.0
• retry-on-network-error
• session-file-like
• test-coverage
• updates
• v4.0
• v4.1
• v4.2

Build # 359

Build Type

push

travis-ci

Committed by ykshatroff

Commit Message

Fix an issue with invalid container parameter being passed to `check_eligibility`

As it unwound a chain of different inconsistencies and potential problems,
some APIs have changed.
* `Signer.prepare()` now accepts a `pyasice.Container` instance instead of generics;
* `Signer.open_container()` now accepts a `pyasice.Container` instance instead of generics
  and performs a type check;
* `SignViewMixin.get_container()` may return a `pyasice.Container`
* `SignViewMixin.start_session()` handles the `SignViewMixin.get_container()` return value,
  promoting it to a `pyasice.Container` if necessary
* the concrete `Signer` implementations were updated to reflect these API changes.

Run Details

209 of 338 branches covered (61.83%)

Branch coverage included in aggregate %.

1175 of 1585 relevant lines covered (74.13%)

0.74 hits per line