theodi / open-data-certificate

82%

staging: 82%

LAST BUILD ON BRANCH fix-deadlocking-generator-updates

branch: fix-deadlocking-generator-updates

CHANGE BRANCH

x

Reset

• fix-deadlocking-generator-updates
• 2021-privacy-update
• CA-certificate
• account-confirmation-i18n
• additional-documentation
• airbrake
• answer-more-questions
• better-plurals
• blank-survey-translation-fallback
• bugfix-404-on-missing-survey
• bugfix-404-on-not-finding-dataset-for-url
• bugfix-add-italian-yes-label
• bugfix-add-more-special-cases-for-odlifier
• bugfix-always-set-levels
• bugfix-change-dcat-url
• bugfix-change-warning-wording
• bugfix-dataset-update-improvements
• bugfix-dont-class-draft-certficates-as-expired
• bugfix-dont-error-when-explanation-given
• bugfix-dont-show-datasets-with-unpublished-response-sets-on-dashboard
• bugfix-dont-show-expiring-status-against-draft-or-archived-certificates
• bugfix-double-accept-transfer
• bugfix-escape-urls-when-grouping
• bugfix-fix-broken-migrations
• bugfix-fix-compute-levels
• bugfix-fix-dashboard
• bugfix-fix-documentation-url-language
• bugfix-fix-licence-definitions
• bugfix-fix-non-updating-certificates
• bugfix-fix-publishing
• bugfix-fix-selects
• bugfix-fix-user-creation
• bugfix-fix-user-switching
• bugfix-google-drive-envs
• bugfix-improve-date-filtering
• bugfix-improve-reliability-of-google-docs-export
• bugfix-lookup-licenses-by-exact-id-or-sub
• bugfix-move-database-config-to-example
• bugfix-odibot-handle-transport-errors
• bugfix-order-matters
• bugfix-precompile-campaign-js
• bugfix-remove-html-from-dataset-descriptions
• bugfix-remove-removed-datasets
• bugfix-repeater-field-fails
• bugfix-rescue-on-empty-rows
• bugfix-restore-destroyed-documentation-urls
• bugfix-speed-up-status-page
• bugfix-start-surveys-in-other-jurisdictions
• bugfix-stop-choking-on-blank-rows
• bundle-cache
• canadian-certificate
• combined-jurisdiction-translations
• combined-survey-locale
• comments
• community-contributions-documentation
• convert-obsolete-translations
• cors-on-redirect
• cz-update
• de-translation-updates
• delayed-purge
• dependabot/bundler/aasm-4.12.0
• dependabot/bundler/aasm-4.12.1
• dependabot/bundler/aasm-4.12.2
• dependabot/bundler/aasm-4.12.3
• dependabot/bundler/airbrake-6.1.2
• dependabot/bundler/airbrake-6.2.0
• dependabot/bundler/airbrake-6.2.1
• dependabot/bundler/airbrake-6.3.0
• dependabot/bundler/airbrake-7.0.0
• dependabot/bundler/airbrake-7.0.1
• dependabot/bundler/airbrake-7.0.2
• dependabot/bundler/airbrake-7.0.3
• dependabot/bundler/airbrake-7.1.0
• dependabot/bundler/airbrake-7.1.1
• dependabot/bundler/airbrake-7.2.0
• dependabot/bundler/airbrake-7.2.1
• dependabot/bundler/airbrake-7.3.0
• dependabot/bundler/better_errors-2.2.0
• dependabot/bundler/better_errors-2.3.0
• dependabot/bundler/better_errors-2.4.0
• dependabot/bundler/binding_of_caller-0.7.3
• dependabot/bundler/binding_of_caller-0.8.0
• dependabot/bundler/coveralls-0.8.21
• dependabot/bundler/csvlint-0.4.0
• dependabot/bundler/cucumber-rails-1.4.5
• dependabot/bundler/database_cleaner-1.6.1
• dependabot/bundler/database_cleaner-1.6.2
• dependabot/bundler/database_cleaner-1.7.0
• dependabot/bundler/delayed_job_active_record-4.1.2
• dependabot/bundler/delayed_job_active_record-4.1.3
• dependabot/bundler/dotenv-rails-2.2.1
• dependabot/bundler/dotenv-rails-2.2.2
• dependabot/bundler/dotenv-rails-2.3.0
• dependabot/bundler/dotenv-rails-2.4.0
• dependabot/bundler/eventmachine-1.2.3
• dependabot/bundler/eventmachine-1.2.5
• dependabot/bundler/eventmachine-1.2.6
• dependabot/bundler/excon-0.72.0
• dependabot/bundler/factory_girl_rails-4.8.0
• dependabot/bundler/factory_girl_rails-4.9.0
• dependabot/bundler/fog-1.40.0
• dependabot/bundler/fog-1.41.0
• dependabot/bundler/foreman-0.84.0
• dependabot/bundler/formtastic-3.1.5
• dependabot/bundler/guard-2.14.1
• dependabot/bundler/guard-2.14.2
• dependabot/bundler/haml-5.0.4
• dependabot/bundler/high_voltage-3.0.0
• dependabot/bundler/httparty-0.15.5
• dependabot/bundler/httparty-0.15.6
• dependabot/bundler/httparty-0.15.7
• dependabot/bundler/httparty-0.16.0
• dependabot/bundler/httparty-0.16.1
• dependabot/bundler/httparty-0.16.2
• dependabot/bundler/jbuilder-2.6.4
• dependabot/bundler/jquery-rails-3.1.4
• dependabot/bundler/jquery-rails-3.1.5
• dependabot/bundler/json_spec-1.1.5
• dependabot/bundler/kaminari-0.17.0
• dependabot/bundler/less-rails-bootstrap-3.3.5.0
• dependabot/bundler/letter_opener-1.5.0
• dependabot/bundler/letter_opener-1.6.0
• dependabot/bundler/linkeddata-1.1.11.2
• dependabot/bundler/lograge-0.3.6
• dependabot/bundler/memoist-0.16.0
• dependabot/bundler/mocha-1.2.1
• dependabot/bundler/mocha-1.3.0
• dependabot/bundler/mocha-1.4.0
• dependabot/bundler/mustache-1.0.5
• dependabot/bundler/mysql2-0.4.10
• dependabot/bundler/mysql2-0.4.6
• dependabot/bundler/mysql2-0.4.7
• dependabot/bundler/mysql2-0.4.8
• dependabot/bundler/mysql2-0.4.9
• dependabot/bundler/mysql2-0.5.0
• dependabot/bundler/mysql2-0.5.1
• dependabot/bundler/nokogiri-1.8.2
• dependabot/bundler/nokogiri-1.9.1
• dependabot/bundler/oauth-0.5.6
• dependabot/bundler/parallel_tests-2.14.1
• dependabot/bundler/parallel_tests-2.14.2
• dependabot/bundler/parallel_tests-2.14.3
• dependabot/bundler/parallel_tests-2.15.0
• dependabot/bundler/parallel_tests-2.16.0
• dependabot/bundler/parallel_tests-2.16.1
• dependabot/bundler/parallel_tests-2.17.0
• dependabot/bundler/parallel_tests-2.18.0
• dependabot/bundler/parallel_tests-2.19.0
• dependabot/bundler/parallel_tests-2.21.0
• dependabot/bundler/parallel_tests-2.21.1
• dependabot/bundler/parallel_tests-2.21.2
• dependabot/bundler/parallel_tests-2.21.3
• dependabot/bundler/pry-byebug-3.4.2
• dependabot/bundler/pry-byebug-3.4.3
• dependabot/bundler/pry-byebug-3.5.0
• dependabot/bundler/pry-byebug-3.5.1
• dependabot/bundler/pry-byebug-3.6.0
• dependabot/bundler/puma-3.11.0
• dependabot/bundler/puma-3.11.1
• dependabot/bundler/puma-3.11.2
• dependabot/bundler/puma-3.11.3
• dependabot/bundler/puma-3.11.4
• dependabot/bundler/puma-3.12.4
• dependabot/bundler/puma-3.12.6
• dependabot/bundler/puma-4.3.8
• dependabot/bundler/rabl-0.13.1
• dependabot/bundler/rack-cors-0.4.1
• dependabot/bundler/rack-cors-1.0.1
• dependabot/bundler/rack-cors-1.0.2
• dependabot/bundler/rack-protection-1.5.5
• dependabot/bundler/rails-3.2.22.5
• dependabot/bundler/rails-footnotes-4.1.8
• dependabot/bundler/rake-12.0.0
• dependabot/bundler/ransack-1.8.3
• dependabot/bundler/ransack-1.8.4
• dependabot/bundler/ransack-1.8.6
• dependabot/bundler/ransack-1.8.7
• dependabot/bundler/ransack-1.8.8
• dependabot/bundler/redcarpet-3.4.0
• dependabot/bundler/redcarpet-3.5.1
• dependabot/bundler/ruby-prof-0.16.2
• dependabot/bundler/ruby-prof-0.17.0
• dependabot/bundler/sass-3.4.24
• dependabot/bundler/sass-3.4.25
• dependabot/bundler/sass-3.5.0
• dependabot/bundler/sass-3.5.1
• dependabot/bundler/sass-3.5.2
• dependabot/bundler/sass-3.5.3
• dependabot/bundler/sass-3.5.4
• dependabot/bundler/sass-3.5.5
• dependabot/bundler/sass-3.5.6
• dependabot/bundler/shoulda-context-1.2.2
• dependabot/bundler/sqlite3-1.3.13
• dependabot/bundler/terminal-notifier-guard-1.7.0
• dependabot/bundler/test-unit-3.2.6
• dependabot/bundler/test-unit-3.2.7
• dependabot/bundler/therubyracer-0.12.3
• dependabot/bundler/thin-1.7.1
• dependabot/bundler/thin-1.7.2
• dependabot/bundler/timecop-0.8.1
• dependabot/bundler/timecop-0.9.0
• dependabot/bundler/timecop-0.9.1
• dependabot/bundler/twitter-bootstrap-rails-confirm-1.0.6
• dependabot/bundler/twitter-bootstrap-rails-confirm-1.0.7
• dependabot/bundler/twitter-bootstrap-rails-confirm-2.0.0
• dependabot/bundler/uglifier-3.2.0
• dependabot/bundler/uglifier-4.0.1
• dependabot/bundler/uglifier-4.0.2
• dependabot/bundler/uglifier-4.1.0
• dependabot/bundler/uglifier-4.1.1
• dependabot/bundler/uglifier-4.1.10
• dependabot/bundler/uglifier-4.1.2
• dependabot/bundler/uglifier-4.1.3
• dependabot/bundler/uglifier-4.1.4
• dependabot/bundler/uglifier-4.1.5
• dependabot/bundler/uglifier-4.1.6
• dependabot/bundler/uglifier-4.1.7
• dependabot/bundler/uglifier-4.1.8
• dependabot/bundler/uglifier-4.1.9
• dependabot/bundler/uuidtools-2.1.5
• dependabot/bundler/validate_url-1.0.2
• dependabot/bundler/vcr-3.0.3
• dependabot/bundler/vcr-4.0.0
• dependabot/bundler/webmock-3.0.1
• dependabot/bundler/webmock-3.1.0
• dependabot/bundler/webmock-3.1.1
• dependabot/bundler/webmock-3.2.0
• dependabot/bundler/webmock-3.2.1
• dependabot/bundler/webmock-3.3.0
• dependabot/bundler/webmock-3.4.0
• deprecations
• double-english-locale
• duplicate-translation-check
• error_message
• es-certificate
• feature-404-draft-badges
• feature-404-for-bad-spider
• feature-about-links
• feature-active-record-optimisation
• feature-add-context-about-automatically-completing-answers
• feature-add-full-stop
• feature-add-timeout-and-error-message
• feature-add-user-to-autogen-certificates
• feature-admin-powers
• feature-administer-users
• feature-all-certificate-data
• feature-all-ssl-all-the-time
• feature-always-send-response-header
• feature-associate-campaigns-with-user
• feature-autocertification-docs
• feature-autocomplete-via-api
• feature-branding-guidelines
• feature-bulk-export
• feature-bump-data-kitten
• feature-campaign-info
• feature-campaign-reporting-improvements
• feature-certificate-campaigns
• feature-certificate-generation-refactor
• feature-certificate-list-tweaks
• feature-claiming-certificate-transfers
• feature-clarify-publisher-origin-question
• feature-cleanup-and-refactor
• feature-clone-data-kitten
• feature-compute-answers-for-data-gov
• feature-create-certificates-asynchronously
• feature-cz-translation
• feature-cz-translation-update
• feature-de-translation
• feature-detailed-tracking
• feature-display-certificate-level-requirements
• feature-document-i18n
• feature-dont-allow-duplicates-via-api
• feature-env-config
• feature-expand-kitten-data-field
• feature-extract-certificate-details
• feature-extract-italian-translations
• feature-filter-by-certificate-type
• feature-filter-by-jurisdiction
• feature-fix-question-wording
• feature-flowchart
• feature-flowchart-documentation
• feature-gdpr
• feature-get-engaged-users
• feature-google-analytics-event-tracking
• feature-greek-translation-update
• feature-greek-translations
• feature-handle-more-request-errors
• feature-handle-refreshes-on-certificate-form
• feature-imporove-embed-stats
• feature-import-draft-existing-datasets
• feature-improve-atom-feed
• feature-improve-certificate-model-code-quality
• feature-improve-certificate-model-gpa
• feature-improve-ckan-import
• feature-improve-ckan-mapping
• feature-improve-code-climate
• feature-improve-dependency-condition
• feature-improve-kitten-data
• feature-improve-question-model-gpa
• feature-improve-user-handling
• feature-include-existing-dataset-url
• feature-include-ip-in-report
• feature-index-datasets-created-at
• feature-italian-licences
• feature-link-to-about-page-from-menu
• feature-load-balancer-check-endpoint
• feature-master-translation-file
• feature-mexico-questionniare
• feature-minor-campaign-improvements
• feature-move-certificate-factory-into-app
• feature-new-statistics
• feature-one-click-update
• feature-optimise-survey
• feature-petes-docs
• feature-policy-pages
• feature-questionnaire-logic-flip
• feature-questionnaire-wording-changes
• feature-rackspace-certificate-download
• feature-rails-security-fixes
• feature-rebrand
• feature-recency-filter-feed
• feature-remove-memcache
• feature-remove-newrelic
• feature-report-certificates
• feature-report-job-errors-to-airbrake
• feature-rerun-autogenerated-certificates
• feature-return-email-of-new-user-in-api
• feature-run-campaigns-from-ui
• feature-save-publish-speedups
• feature-setup-assetpipeline-clearly
• feature-show-expiring-status-on-list
• feature-show-missing-responses-in-campaign-view
• feature-stable-certificate-links
• feature-store-admin-in-database
• feature-the-cors-forgiven-not-forgotten
• feature-track-badge-embeds
• feature-track-campaigns
• feature-track-jurisdiction-usage
• feature-transifex
• feature-uk-transifex
• feature-update-badge
• feature-update-branding-images
• feature-update-certificate-api
• feature-update-certificates-from-feed
• feature-us-questionnaire
• feature-use-nonconflicting-param-name-for-search
• feature-user-account-details
• feature-valid-html-form
• feature-validate-locales
• feature-vendor-surveyor
• fix-access-to-kitten-data-fields
• fix-atom-feed-certificate-level
• fix-attained-level
• fix-campign-processing
• fix-certificate-generation-deadlock
• fix-ckan-feed-reading
• fix-create-link
• fix-csv-export-column-order
• fix-czech-translation-typos
• fix-dataset-export
• fix-determining-licences
• fix-edit-question-link
• fix-editing-with-new-survey
• fix-email-error-reporting
• fix-embed-stat-csv-generation
• fix-en-requirement-messages
• fix-hide-verify-button-from-owner
• fix-i-cant-spell-supersede
• fix-jurisdiction-json
• fix-kitten-data-legacy
• fix-language-support-files
• fix-legacy-kitten-data-fields
• fix-legacy-show
• fix-linked-in-urls
• fix-linkedin-check
• fix-login-clickable-labels
• fix-login-redirect
• fix-make-setup-script-safe
• fix-mermaid-issues
• fix-mx-yesno
• fix-not-found-certificate-errors
• fix-one-true-brand
• fix-only-claim-autogenerated-certificates
• fix-out-of-order-sign
• fix-over-requesting-resources
• fix-over-zealous-question-requirements
• fix-per-page-feed-reading
• fix-public-dataset-csv-location
• fix-questionnaire
• fix-questionnaire-typo
• fix-rakefile
• fix-reporting-discrepancies
• fix-rerun-campaigns
• fix-resolve-test
• fix-response-set-states
• fix-response-set-update-queries
• fix-rights-statement-display
• fix-show-embed-link-to-admins
• fix-sidekiq-delay-method
• fix-start-page
• fix-stats-generation
• fix-stupid-hiding-bug
• fix-survey-build
• fix-switch-jurisdictions
• fix-unnecessary-env-vars
• fix-uri-validation-checks
• fix-url-field-length-truncation
• fix-wording
• fix-wording-on-improvements
• frequently-fixed-questions
• github-collaboration-resources
• handle-more-internet-errors
• handle-rerunning-generators
• heroku
• homepage-content-update
• homepage-tweaks
• hotfix-account-update-page
• hotfix-cors-badge-js
• hotfix-dont-display-altered-warning
• hotfix-edit-questionnaire-link
• hotfix-embed-stats-csv
• hotfix-handle-invalid-uri
• hotfix-update-airbrake
• hotfix-url-copying-from-old-response-set
• improve-ckan-answers
• improved-docs
• json-search
• license
• locale-based-layout-breakage
• locale-path-for-cors
• locale-switching
• mailer-test-fix
• mandrill-subaccount
• master
• missing-general-translations
• missing-l10n
• never-bundle-again
• new-foreman
• new-infra
• newbie-cleanup
• no-robots
• open-data-monitor-logo
• optimise-json-search
• optimising-survey
• parallel-tests
• patch-update-PR-template
• pet-the-data-kitten
• port-in-procfile
• post-new-cookware
• puma
• ready-for-deploy
• relative-dates-i18n
• remove-default-locale-name
• remove-prototype-translations
• remove-rack-env
• requirement-cleanup
• rights-help-text-typo
• routing-404
• simplified-certificate-process
• staging
• start-page-translations
• static-page-i18n
• support-ckan-on-nonroot-path
• survey-cleanup-and-merge
• survey-translations
• surveyor-rspec
• take-page-translations
• testicicle
• tiny-unit-testing-branch
• translations
• tw-translations
• two-point-one-new-rubies
• uk-final
• update-badgers-table
• update-community-resources
• update-contact-email
• update-datakitten
• update-de-translations
• update-gdpr
• update-logo
• update-rails
• update-rbenv
• update-ruby
• update-versions
• validate-attained-level
• validation-changes
• website-content-updates
• yes-no-translation
• zh-TW-translations

Build # 1748

Build Type

push

travis-ci

Committed by pkqk

Commit Message

Retry `save!` when a deadlock aborts the update

Two update queries in MySQL can deadlock if one
transaction gets the lock for the row and another
gets the lock for the index first (if it’s near by
in the index, i.e. close id numbers)

I tried shuffling the order the updates when into
the queue but that was not enough distribution to
solve this. The only solution is to retry the
query. Though ActiveRecord does not make this
easy.

Run Details

7 of 7 new or added lines in 1 file covered. (100.0%)

2423 of 2965 relevant lines covered (81.72%)

132.08 hits per line