team-telnyx / telnyx-python

95%

master: 93%

LAST BUILD ON BRANCH ENGDESK-4618

branch: ENGDESK-4618

CHANGE BRANCH

x

Reset

• ENGDESK-4618
• 1.2.1_add-faxes
• 1.2.2_release
• 2.0_Update
• DEVREL-994
• ENG-31284
• ENGDESK---31284
• ENGDESK-4037
• ENGDESK-4279
• ENGDESK-4420
• ENGDESK-5552
• ENGDESK-5754
• Hosted_SMS_Addition
• PORTAL-1014
• PORTAL-1018
• PORTAL-1019
• PORTAL-1030
• PORTAL-1679
• PORTAL-769
• PORTAL-862
• PORTAL-866
• PORTAL-867
• PORTAL-869
• PORTAL-872
• Python-2.1.0
• Python-2.1.1
• Update_README.md
• alphanumeric_sender_id
• bump-version
• call-conference
• call-control-and-conference-endpoints
• call-control-endpoints
• call-queue
• clean-up-tests
• fax_resources
• fix-faxes-pluralness
• fix-tests
• fix/DEVREL-1062-client-state
• fixes
• github-actions-test
• hosted_sms_resources
• hostedsms_feature
• jira-PORTAL-1630
• linter
• master
• number-reservation-extended
• number_pool_fix
• pipfile-to-reqs
• porting-endpoints
• porting-order-resource
• porting-orders
• revisit-simcard-tests
• telephony-credentials
• telnyx_id_off
• transcription-call-control-support
• tweet-release
• update-telnyx-mock
• update_setup-dot-py-1.2
• v1.0.0b1
• v1.0.0b2
• v1.0.0b3
• v1.0.0b4
• v1.0.0b5
• v1.3.0_updates
• v1.5.0
• v1.5.0_release
• v2.0.0
• v2.1.1
• v2.1.2
• v2.1.3
• v2.1.4
• v2.1.5
• v2.1.5-Bump-and-Lint
• verification-addition
• verification-endpoints
• verify-endpoint-specs
• version-1.0.0b2
• webhook_signature_validation
• whitesource/configure

Build # 188

Build Type

Pull #21

travis-ci

Committed by web-flow

Commit Message

ENGDESK-4618: Rewrite reserved words on nested resource class methods

`nested_resource_class_methods` methods use their own API requestor
instance to make the HTTP request. It was forgotten to rewrite the
reserved words before using them in this request.

When testing this change, I noticed we didn't seem to handle the
returned response at all. If the API returned an response body with
`{"from": "foo"}`, the attribute would be initialised with `obj.from =
"foo"`. This meant future updates would fail as attempting to set
`obj.from` would result in an error due to the reserved keyword. You
would have to use `setattr(obj, "from", "baz")`.

I've fixed this by ensuring reserved words are rewritten not only before
sending them to the API but also when handling the response.

This means you can now do:

    obj = BaseClass.nested_resource.create(from_="foo")
    obj.from_ = "baz"
    obj.save()

    assert obj.from_ == "baz"

Pull Request Pull Request #21: ENGDESK-4618: Rewrite reserved words on nested resource class methods

Run Details

8 of 8 new or added lines in 3 files covered. (100.0%)

1306 of 1369 relevant lines covered (95.4%)

7.62 hits per line