tarantool / graphql

91%

master: 91%

LAST BUILD ON BRANCH gh-253-test-nulls-in-multihead

branch: gh-253-test-nulls-in-multihead

CHANGE BRANCH

x

Reset

• gh-253-test-nulls-in-multihead
• Totktonada/add-rockspec
• Totktonada/fix-external-pull-requests
• Totktonada/fix-shard-optional-test
• Totktonada/gh-283-fix-record-inside-map-avro-schema-gen
• Totktonada/gh-88-connections-name-clash
• Totktonada/skip-unsupported-spaces
• Totktonada/update-distros-and-repos
• add-apidoc-lint-into-ci
• bastida-graphql
• bastida-graphql-pr
• drop-avro-schema-2-support
• experiment-use-raw-msgpack-for-unflatten
• expressions-constant-propagation
• factor-out-find-index-module
• gh-228-find-index-for-expr
• gh-262-support-aliases-in-bfs-executor
• increase-coverage-target-time-limit
• master
• test-increase-timeout-for-accessor_funcs.test.lua
• use-merger-when-available
• user-query-context-for-accessor-funcs

Build # 601

Build Type

push

travis-ci

Committed by Totktonada

Commit Message

Give an empty multihead connection as null

This commit changes behaviour in the following cases:

1. When a union variant to which a connected object belongs is not appear
   in a query, the library returns box.NULL w/o any wrappers.

2. When no connected object is found, the library returns box.NULL as
   well even if all-nulls check before fails (typically because of
   disable_dangling_check option, but also it is possible because of
   using different source fields across multihead connection variants).

The first case is tested with to_avro_multihead.test.lua. The latter one
does not tested.

In these cases we could receive `{"collection_name": null}` as a result
instead of just `null`. Only `null` is valid result for a avro-schema
union.

Both variant however are valid by our avro-schema generated for a query,
because a multi-head connection represented as an object with nullable
fields. There is a reason for that, see the comment for the
union_to_avro() function in graphql/query_to_avro.lua.

Fixes #253.

Run Details

5504 of 6023 relevant lines covered (91.38%)

19779.73 hits per line