tarantool / crud

89%

master: 89%

LAST BUILD ON BRANCH DifferentialOrange/gh-437-fix-sharding-many

branch: DifferentialOrange/gh-437-fix-sharding-many

CHANGE BRANCH

x

Reset

• DifferentialOrange/gh-437-fix-sharding-many
• 0x501D/ci-tt
• AnaNek/check-for-incorrect-call-mode
• AnaNek/gh-314-fix-vshard-sharding-func
• AnaNek/parameterization-for-call-test
• AnaNek/select-no-indexes-fix
• DIfferentialOrange/release-1.3.0
• DifferentialOranage/gh-373-datetime-conditions
• DifferentialOrange/HTTP-API-improvements
• DifferentialOrange/ci-health
• DifferentialOrange/ci-health-tt
• DifferentialOrange/clarify-license
• DifferentialOrange/crud-metrics-params
• DifferentialOrange/fix-0.10.0-changelog
• DifferentialOrange/fix-dev-checks
• DifferentialOrange/fix-flaky-schema
• DifferentialOrange/fix-flaky-vshard-test
• DifferentialOrange/fix-readme-update-links
• DifferentialOrange/fix-tests-2.10.1
• DifferentialOrange/gh-211-cluacov-fix
• DifferentialOrange/gh-212-reload-sharding-keys
• DifferentialOrange/gh-212-reload-sharding-keys-final
• DifferentialOrange/gh-213-optimize-map-reduce
• DifferentialOrange/gh-224-operation-stats
• DifferentialOrange/gh-225-vshard-performance
• DifferentialOrange/gh-234-optimize-know-bucket_id
• DifferentialOrange/gh-236-tmp-test-master
• DifferentialOrange/gh-236-tmp-test-new
• DifferentialOrange/gh-241-field-number-doc
• DifferentialOrange/gh-249-fix-luacov
• DifferentialOrange/gh-253-design-doc-reload
• DifferentialOrange/gh-255-forbid-len-by-id
• DifferentialOrange/gh-271-select-nil-err-merger
• DifferentialOrange/gh-278-sharding-mismatch
• DifferentialOrange/gh-284-tolerated-error-lost
• DifferentialOrange/gh-286-age-nan
• DifferentialOrange/gh-308-fail-after-drop
• DifferentialOrange/gh-310-ddl-record-delete
• DifferentialOrange/gh-312-yield
• DifferentialOrange/gh-326-improve-warning-message
• DifferentialOrange/gh-328-flatten-for-sequence
• DifferentialOrange/gh-332-role-cfg
• DifferentialOrange/gh-365-drop-old-select
• DifferentialOrange/gh-377-no-rows-error
• DifferentialOrange/gh-403-names-as-keys
• DifferentialOrange/gh-404-follow-up
• DifferentialOrange/gh-407-no-uuid
• DifferentialOrange/gh-409-master-discovery
• DifferentialOrange/gh-412-3.0-grants
• DifferentialOrange/gh-412-test-stabilization
• DifferentialOrange/gh-415-role-for-tarantool3
• DifferentialOrange/gh-418-conditions-order
• DifferentialOrange/gh-422-nil-conditions
• DifferentialOrange/gh-44-vshard-groups
• DifferentialOrange/iproto-tuple-formats-fixes
• DifferentialOrange/no-gh-fix-coveralls
• DifferentialOrange/no-gh-new-vshard-for-reusable
• DifferentialOrange/no-gh-remove-metrics-for-master
• DifferentialOrange/no-gh-retry-tests
• DifferentialOrange/no-gh-schema
• DifferentialOrange/no-gh-update-readme
• DifferentialOrange/readme-sharding-duplicate-rows
• DifferentialOrange/readme-version
• DifferentialOrange/release-0.11.0
• DifferentialOrange/release-0.11.1
• DifferentialOrange/release-0.11.2
• DifferentialOrange/release-0.11.3
• DifferentialOrange/release-0.12.1
• DifferentialOrange/release-0.13.0
• DifferentialOrange/release-0.14.0
• DifferentialOrange/release-1.0.0
• DifferentialOrange/release-1.1.0
• DifferentialOrange/release-1.1.1
• DifferentialOrange/release-1.2.0
• DifferentialOrange/release-1.4.0
• DifferentialOrange/release-1.4.1
• DifferentialOrange/release-1.4.2
• DifferentialOrange/release-1.4.3
• DifferentialOrange/release-1.5.0
• DifferentialOrange/release-1.5.1
• DifferentialOrange/release-1.5.2
• DifferentialOrange/run-ci
• DifferentialOrange/support-older-cartridges
• DifferentialOrange/tarantool-version-parsing-3.x
• Totktonada/add-a-license
• Totktonada/add-playground
• Totktonada/ci-add-tarantool-2.10
• Totktonada/doc-enhancements
• Totktonada/fix-tarantool-2-10-determination
• Totktonada/gh-203-add-tarantoolctl-install-into-readme
• Totktonada/gh-220-bucket-id-is-ignored
• Totktonada/polish-version-checks
• Totktonada/readme-fix-update-cache-recipe
• Totktonada/release-0.10.0
• Totktonada/release-0.12.0
• Totktonada/release-0.9.0
• Totktonada/skip-merger-creation-for-one-replicaset
• Totktonada/test-fix-timeout-error-message
• Totktonada/update-cartridge-dependency
• Totktonada/use-setup-tarantool-for-1.10.6
• Totktonada/workaround-luacov-coveralls-installation-fail
• batch-insert-upsert
• better0fdead/gc-fix-readview
• better0fdead/readview
• count-implementation
• doc-add-full-space-format
• drop-heap
• fix-cluacov-rockspec-uri
• fix-opts-damage
• fix-timeout-select-pairs
• fix-typo-readme
• igrishnov/gh-204-add-hardcoded-versioning-support
• igrishnov/gh-236-update-stale-schema-metadata-gen
• igrishnov/gh-236-update-stale-schema-metadata-gen-new-approach
• igrishnov/gh-250-change-dev-env-var-naming
• igrishnov/gh-267-noreturn-opt-for-DML-operations
• igrishnov/gh-331-master-conn-check-for-get-space-utils
• igrishnov/gh-95-master-timeout-fetch-for-get-space-utils
• igrishnov/gh-x-test-master-ci
• ligurio/bump-luatest
• ligurio/fix-coveralls-paths
• ligurio/gh-166-sharding-keys
• ligurio/gh-219-jsonpath-sharding-key
• ligurio/ldoc-support
• ligurio/not_covered
• ligurio/remove-extra-whitespaces
• ligurio/revert-remove-tuple-keydef
• ligurio/typo
• ligurio/update-test-matrix
• ligurio/update_test_matrix
• ligurio/use_luatest_native_asserts
• master
• oleg-jukovec/fix-after-behavior
• oleg-jukovec/gh-276-log-select-nil
• oleg-jukovec/gh-364-vshard-tests
• oleg-jukovec/gh-366-vshard-user-experience
• oleg-jukovec/no-gh-readme_many_fix
• perf-test
• psergee/fix-crud-delete-error-message
• psergee/gh-229-crud-storage-init-status
• psergee/gh-consistent-select-error-description
• refs/heads/igrishnov/gh-236-update-stale-schema-metadata-gen
• refs/pull/330/merge
• refs/pull/335/merge
• refs/pull/374/merge
• refs/pull/387/merge
• refs/pull/390/merge
• refs/pull/393/merge
• refs/pull/400/merge
• refs/pull/410/merge
• refs/pull/444/merge
• refs/tags/0.10.0
• refs/tags/0.11.0
• refs/tags/0.11.1
• refs/tags/0.11.2
• refs/tags/0.11.3
• refs/tags/0.12.0
• refs/tags/0.12.1
• refs/tags/0.13.0
• refs/tags/0.14.0
• refs/tags/0.14.1
• refs/tags/0.9.0
• refs/tags/1.0.0
• refs/tags/1.1.0
• refs/tags/1.1.1
• refs/tags/1.2.0
• refs/tags/1.3.0
• refs/tags/1.4.0
• refs/tags/1.4.1
• refs/tags/1.4.2
• refs/tags/1.4.3
• refs/tags/1.5.0
• refs/tags/1.5.1
• refs/tags/1.5.2
• support-custom-sharding-func
• update-errors
• ylobankov/bump-actions-version

Build # 9127688038

Build Type

Pull #438

github

Committed by DifferentialOrange

Commit Message

crud: fix explicit bucket_id in *_many operations

In case `insert_many`, `insert_object_many`, `replace_many`,
`replace_object_many`, `upsert_many` or `upsert_object_many` has been
called on a space with custom sharding info and every tuple/object
in the request had `bucket_id`, `ShardingHashMismatchError` has been
returned even though there are no issues with sharding info. For
example, some users met this issue while working with tt-ee
`tt crud import` command.

The reason is as follows. To ensure sharding info consistency between
the storage and the router, some metainfo is calculated for a request
in case bucket_id is generated. In case no bucket_id is generated, no
sharding info is passed and consistency check is skipped (since it is
not needed). Before this patch, `*_many` operations haven't skipped
consistency check when it was expected due to improper
`skip_sharding_hash_check` flag setup.

Closes #437

Pull Request Pull Request #438: crud: fix explicit bucket_id in *_many operations

Run Details

3 of 3 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

4854 of 5473 relevant lines covered (88.69%)

6081.28 hits per line