tarantool / crud
89%
master: 89%

LAST BUILD BRANCH: fix-cluacov-rockspec-uri
DEFAULT BRANCH: master
Repo Added
Files 63
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH DifferentialOrange/gh-418-conditions-order
branch: DifferentialOrange/gh-418-conditions-order
CHANGE BRANCH
x

coverage: 88.608% (+0.002%) from 88.606%
7783904305

Pull #419

github

DifferentialOrange 
scan: fix filter erroneous early exit

The issue described below is related to the read operations which
allows to scan: `crud.select`, `crud.pairs`, `crud.count`,
`readview:select` and `readview:pairs`.

The erroneous behavior reported by [1] and #418 is as follows:
- result changes when reordering operation conditions;
- when `>=` condition operation is changed to `=`, there are more rows
  in the result.

The reason is as follows. Scanning read operates with two entities:
an iterator and a filter. The iterator includes an index, a starting
value and iterator type (EQ, GT, etc.). The iterator is built from
conditions, if possible, otherwise primary index is used. Remaining
conditions form the filter, so the actual result satisfies all operation
conditions.

The filter supports early exit. Let's consider the following example.
For `crud.select(space, {{'>=', 'id', 1}, {'<=', 'id', 10}})`, where
`id` is an index (or an indexed field), the iterator uses index
`id`, starts from key = `1` and goes by GE rules, covering [1, +inf)
ordered keys. On the other hand, when iterator reaches the tuple
with `id` = `11`, all tuples after this one will never satisfy
the second condition, because our iterator yields tuples sorted by `id`
(due to underlying index). So filter tells than there is no reason
to scan anymore, and we finish the scanning procedure.

Before this patch, the function behind early exit decision had worked
as follows: "if the condition is an index, we go in forward (reverse)
order and `<=` or `<` (`>=` or `>`) condition is violated, there is no
reason to scan anymore". But the valid approach is "if the condition is
SCANNING index...". Before this patch, filter had assumed that if the
condition for index is specified, tuples are ordered, but it works only
if iterator uses the same index as in the condition. This patch fixes
the issue.

The erroneous behavior may happen in the following case:
- there are multiple conditions,
- there are at least tw... (continued)
Pull Request #419: scan: fix filter erroneous early exit

11 of 12 new or added lines in 4 files covered. (91.67%)

1 existing line in 1 file now uncovered.

4729 of 5337 relevant lines covered (88.61%)

6308.12 hits per line

Relevant lines Covered
5337 RELEVANT LINES 4729 COVERED LINES
6308.12 HITS PER LINE
Source Files on DifferentialOrange/gh-418-conditions-order

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
7783904305 DifferentialOrange/gh-418-conditions-order scan: fix filter erroneous early exit The issue described below is related to the read operations which allows to scan: `crud.select`, `crud.pairs`, `crud.count`, `readview:select` and `readview:pairs`. The erroneous behavior reported by [1] and... Pull #419 DifferentialOrange github
88.61
7781050686 DifferentialOrange/gh-418-conditions-order scan: fix filter erroneous early exit The issue described below is related to the read operations which allows to scan: `crud.select`, `crud.pairs`, `crud.count`, `readview:select` and `readview:pairs`. The erroneous behavior reported by [1] and... Pull #419 DifferentialOrange github
88.61
7758011815 DifferentialOrange/gh-418-conditions-order scan: fix filter erroneous early exit The issue described below is related to the read operations which allows to scan: `crud.select`, `crud.pairs`, `crud.count`, `readview:select` and `readview:pairs`. The erroneous behavior reported by [1] and... Pull #419 DifferentialOrange github
88.61
See All Builds (1162)